From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33C903E7BAD; Wed, 30 Sep 2026 19:28:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790796506; cv=none; b=Py85ab5Fb0Is2sHILSxrwmefwAJ4j+qEcsJ2krtqLYwQZQg48TpR2alVSbyT61Z40dddlGXlKj7SinYXsU4BbMY7v5JL0x+GCqA6U/iCXYyk2Mc/IZel5pm9WZu0nILBMgAgaqBtUiCURCR4L/l30MhiEdb4E4jFM9H65eJEL6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790796506; c=relaxed/simple; bh=0xIQ8VYsqpy6Y/uVfKZs4ZhkOtPtOr4NN7Ej68YMAsA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d6eKLBMmR2fKnVdbZg0wrZJ5MWKfQhy5OBh1NW8qGuuUf4bnsfy6dsZdpYSGVzfEKlgkul1IcZDIZgjSqP5Y6hykmzPlvRKlOjIjsW3Y41PTAVOkw4U3Z8la0wl412AqVxQqQ1GtqHGUe61b3z2v3woxarkyPmIk5gGI87PXdac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=swtt3Mpk; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="swtt3Mpk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82D681F000FF; Wed, 30 Sep 2026 19:28:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1790796505; bh=V5MYtvHVTmQ/u8GWccn4VZE0ajhfM4D3fO/taVfLo6Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=swtt3Mpkr5A6Pw3Hs77UGCWajzknINOrE2RqSnWstqdTEra//PpdmoBWoimNAMOlK NTY5wccOMd8LzZjbeqzYIgZ7nSTKuvup/BdNP9wi3A6my1k6RTNKGxWNHdjt/k/vYy Ut/g1VoAUWehK9zH7KfQHh+XMKTVv3FLnuE5kHxY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Namjae Jeon , Paulo Alcantara , Tom Talpey , Stefan Metzmacher , Shyam Prasad N , Ronnie Sahlberg , Bharath SM Subject: [PATCH 6.6 0936/1193] smb: client: fix smbd_connection leak on cifs_get_tcp_session() error Date: Wed, 30 Sep 2026 17:27:00 +0200 Message-ID: <20260930152455.036199302@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260930152434.301151190@linuxfoundation.org> References: <20260930152434.301151190@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Paulo Alcantara commit e75c96157d45e498970158c8f7373d90102e33b9 upstream. When an RDMA connection is successfully established via smbd_get_connection() but cifs_get_tcp_session() later fails (e.g. kthread_create() returns an error), the error path frees tcp_ses without first destroying the smbd_connection. Fix this by calling smbd_destroy() in the out_err cleanup path before kfree(tcp_ses). smbd_destroy() safely handles the case where smbd_conn is NULL, so it can be called unconditionally. Closes: https://sashiko.dev/#/patchset/20260912165503.521597-1-pc%40manguebit.org Fixes: 2f8946464b11 ("CIFS: SMBD: Upper layer connects to SMBDirect session") Reviewed-by: Namjae Jeon Signed-off-by: Paulo Alcantara Cc: Tom Talpey Cc: Stefan Metzmacher Cc: Shyam Prasad N Cc: Ronnie Sahlberg Cc: Bharath SM Cc: Namjae Jeon Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/smb/client/connect.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/smb/client/connect.c +++ b/fs/smb/client/connect.c @@ -1901,6 +1901,7 @@ out_err: kfree(tcp_ses->leaf_fullpath); if (tcp_ses->ssocket) sock_release(tcp_ses->ssocket); + smbd_destroy(tcp_ses); kfree(tcp_ses); } return ERR_PTR(rc);