From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28EB7473C8D; Fri, 9 Oct 2026 14:19:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791555564; cv=none; b=UrFQSZ1SKz1PlFX3hVSuolyxPXJy8cqUpggDEpkS71RMvLDHJ/y4Z9zDGgcUXhuh6kUROC/GwTas1leUEwStgq+GckXmGLOarvdppDibuhuKBGNbeD66QQPclojaeQ8GreNcVLEgAsXnP+ay61ko3dEX7n5+e3dSevwpbq8B4XM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791555564; c=relaxed/simple; bh=N6rUez+US0G3x7+V295j7nO1LCsFJKBzU0zh+5jiWw0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HD2m10xExmXZSzAAY9DZaRLPxw0LKWSvU0Dbzvd/oQxJxL4FZAA+P0n3o/vPvrApFIucMhDTyd4kJlYd+3s+T5DV7uFQN2YVe27UVWQ4B+5dfI7/sBLcpB815UKMY5pKxD9EOKigAhUbhbIYq9quV00ROevVc1yj8tCrIsnFsNg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DPp5Wjkr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DPp5Wjkr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63AA21F000FF; Fri, 9 Oct 2026 14:19:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1791555562; bh=GF3HyubV2au+0PYI4MP+7YQ9rcWIY27t4J8DEdAunhQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=DPp5Wjkr0nzDXxnaSt/cGEl1P8oBAkFziSXLSN3+k1kcUwyR0DOiD1Z6pRAC7ocNB SE2aap9YwUuKM/i60PaC1BSXMjpSLV9JsFN884fhhEz1SDG5KgVorS1GJzBAfBF9+N 3Lvvk5T+wTUdwMO05+RYcHAfKoQAsGPP4MlnhOyk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Leon Hwang , "Masami Hiramatsu (Google)" Subject: [PATCH 7.2 029/428] kprobes: Skip disarmed probes when checking optkprobe overlap Date: Fri, 9 Oct 2026 16:06:06 +0200 Message-ID: <20261009140946.717840682@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261009140946.008206689@linuxfoundation.org> References: <20261009140946.008206689@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Leon Hwang commit 7a39c732a22ec4a369af9e19fbe3d666ec83eec4 upstream. On x86, an optkprobe at A replaces five bytes with a jump. If a disabled probe B is at A+2, get_optimized_kprobe() stops at B when arming a new probe C at A+4. It leaves A optimized: A A+1 A+2 A+3 A+4 A's jump | e9 | d0 | d1 | d2 | d3 | after C | e9 | d0 | d1 | d2 | cc | The INT3 for C overwrites the last byte of A's jump displacement, so execution can jump to the wrong address. B can have prepared optinsns while disarmed, but has no jump to unoptimize. Continue past disarmed and unprepared probes to find the active optimized probe before arming a probe in its jump. Link: https://lore.kernel.org/all/20260930053618.104498-1-leon.hwang@linux.dev/ Fixes: afd66255b9a4 ("kprobes: Introduce kprobes jump optimization") Cc: stable@vger.kernel.org Signed-off-by: Leon Hwang Signed-off-by: Masami Hiramatsu (Google) Signed-off-by: Greg Kroah-Hartman --- kernel/kprobes.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) --- a/kernel/kprobes.c +++ b/kernel/kprobes.c @@ -496,14 +496,16 @@ static bool kprobe_queued(struct kprobe static struct kprobe *get_optimized_kprobe(kprobe_opcode_t *addr) { int i; - struct kprobe *p = NULL; + struct kprobe *p; struct optimized_kprobe *op; /* Don't check i == 0, since that is a breakpoint case. */ - for (i = 1; !p && i < MAX_OPTIMIZED_LENGTH / sizeof(kprobe_opcode_t); i++) + for (i = 1; i < MAX_OPTIMIZED_LENGTH / sizeof(kprobe_opcode_t); i++) { p = get_kprobe(addr - i); + /* A disabled probe can have prepared, but inactive, optinsns. */ + if (!p || !kprobe_optready(p) || kprobe_disarmed(p)) + continue; - if (p && kprobe_optready(p)) { op = container_of(p, struct optimized_kprobe, kp); if (arch_within_optimized_kprobe(op, addr)) return p;