From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AAAA37E2E9; Fri, 9 Oct 2026 14:25:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791555950; cv=none; b=ULDo5M7jLSE3SDKEFVla0ZNEC5Sqo+JGbAieKjai3z23irloT0szu0cdZCaoLlNSEc33Uwavy0PuYin806CSORo4ldXq5jGWH8RnL18ESP6EpCm87REeJtttoiflA4DxjeFHqd1/bPewCC14+wZ5TC2b0Kh+2O84wqLjuMEOMKk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791555950; c=relaxed/simple; bh=jFY9tIuD1WIgQRBmF6SQS4aetv0Y62oahtOsk0JrZjQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ie1Re4HM8fBhIOTUWLkyC7jtFYYMLx2gdMLBFgE6dlXE0pJ9UAihFwDUslnl3vZJlZduqEXV1EXfoK9blPdF8irdnk90Lrr/PsgxVFAfbhhJOcxFKRCYWFiTj35rcVANtkGBV69K4Zbu5vIWLjsnWvwmOHSiI8uDb0d3hNJJvL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=QzXKdYRk; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="QzXKdYRk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 619E31F000FF; Fri, 9 Oct 2026 14:25:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1791555948; bh=PCDXxKyuYLfbgQPdVeC0ViK8+kLDOWQcG3Cv1V8AL/w=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=QzXKdYRkt31Mi3CeSSOeA80q9yAGV5E+TtwtBrgPctrW9R62BpBL1YVAS7bB8aZWc 1JdekY4ULLhamdA86MiBZj2cvewD4qzx3W99+QfWIkViiZpzQYxnE70HcQV295Gcgl ez4kcEgKJwZG7upqHj7BNU5YAZaVEsXx5CAeqSXI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sai Teja Aluvala , Luiz Augusto von Dentz , Sasha Levin Subject: [PATCH 7.2 095/428] Bluetooth: btintel: validate DDC record lengths Date: Fri, 9 Oct 2026 16:07:12 +0200 Message-ID: <20261009140948.293578624@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261009140946.008206689@linuxfoundation.org> References: <20261009140946.008206689@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sai Teja Aluvala [ Upstream commit c9c15d4d8956df8c564f7c210e4dc5b9b820d97a ] Parse DDC record lengths in unsigned storage so 0xFF does not wrap. Reject records smaller than the mandatory three-byte header, records exceeding U8_MAX, and records exceeding remaining firmware bytes before issuing Intel_Write_DDC. This issue was reported by Claude Mythos. Fixes: 145f2368c5fd ("Bluetooth: btintel: Add Device Configuration support") Signed-off-by: Sai Teja Aluvala Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Sasha Levin --- drivers/bluetooth/btintel.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index 96a55d5badda1..689cfe4cbacf8 100644 --- a/drivers/bluetooth/btintel.c +++ b/drivers/bluetooth/btintel.c @@ -407,8 +407,16 @@ int btintel_load_ddc_config(struct hci_dev *hdev, const char *ddc_name) /* DDC file contains one or more DDC structure which has * Length (1 byte), DDC ID (2 bytes), and DDC value (Length - 2). */ - while (fw->size > fw_ptr - fw->data) { - u8 cmd_plen = fw_ptr[0] + sizeof(u8); + while (fw->size > (size_t)(fw_ptr - fw->data)) { + size_t remaining = fw->size - (fw_ptr - fw->data); + unsigned int cmd_plen = fw_ptr[0] + 1U; + + if (cmd_plen < 3 || cmd_plen > U8_MAX || cmd_plen > remaining) { + bt_dev_err(hdev, "Malformed DDC record (plen=%u, remaining=%zu)", + cmd_plen, remaining); + release_firmware(fw); + return -EINVAL; + } skb = __hci_cmd_sync(hdev, 0xfc8b, cmd_plen, fw_ptr, HCI_INIT_TIMEOUT); -- 2.53.0