From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BFD738654F; Sat, 17 Oct 2026 16:26:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792254389; cv=none; b=jeP3XpPM4g19vWBp6Kse2F8rL4tdaQuFdAeYiaeDLuMaK1oNag8ZSzJ+VO8zkEjsf/XzskJ/1Nr6uhLruQdKp83SNlTnYdhaQErzFl02A+ukhVXHIGXQfC9czD0T+/WmWMc7RP+tAmOyzxI9LFmWjmvtfU4vGspLg/CIx9Jp/5U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792254389; c=relaxed/simple; bh=l888a/LxHS97Gk0TfcyYFJIQCjELjcVZKNsFr0WNB4A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CQXuuHs1W3xvLYnGneP5e4y1MYNsr0mjJ+9v5KtsS6UOdhSBCrM3H2ii+KeFR8cSkMIqsEaDqylk0kYbxRWJmJQ88Av5VBhoirMLMHzVZti8sWfgWL/chO2tolWE6Ti/JI/tcHMr5O1hrtYHv+4krNolRIcKU+gJlbl/xzs17sM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=eDvpKHVo; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eDvpKHVo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8AB71F000C4; Sat, 17 Oct 2026 16:26:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1792254388; bh=DEFo2+m2Ia9Q442jo0oOq4FkxmCZkJjxLg6yOJsvnN4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=eDvpKHVoYUVEumlh8AV+9X7sWD+fKHGYUf/kDu/Vkb8gqqurKKiY7tjDkPFsy9NrG AlyGyToVhwSf42yluYaFsDuZHSQOHTIgZbFgwrmmqmQS+v59U+judkNFcKDQHdzscx N85nC70KSV/OKl7gENBjt+aqy7Q9LmxuvuMszNYw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alain Volmat , Hans Verkuil , Sasha Levin Subject: [PATCH 6.12 378/869] media: stm32: dcmipp: use v4l2_subdev_is_streaming Date: Sat, 17 Oct 2026 17:53:39 +0200 Message-ID: <20261017160046.807697595@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261017160036.979869304@linuxfoundation.org> References: <20261017160036.979869304@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alain Volmat [ Upstream commit 255e0cc62b9b1afad9b9ba7738d5c53cd0d157fb ] Rely on v4l2_subdev_is_streaming in order to know if the subdev is streaming or not instead of relying on a local variable. Signed-off-by: Alain Volmat Signed-off-by: Hans Verkuil Stable-dep-of: ffc8eec06378 ("media: stm32-dcmipp: Return queued buffers on start_streaming() failure") Signed-off-by: Sasha Levin --- .../media/platform/st/stm32/stm32-dcmipp/dcmipp-byteproc.c | 6 +----- .../media/platform/st/stm32/stm32-dcmipp/dcmipp-parallel.c | 5 +---- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-byteproc.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-byteproc.c index 5a361ad6b0234..50500112eab9a 100644 --- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-byteproc.c +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-byteproc.c @@ -78,7 +78,6 @@ struct dcmipp_byteproc_device { struct v4l2_subdev sd; struct device *dev; void __iomem *regs; - bool streaming; }; static const struct v4l2_mbus_framefmt fmt_default = { @@ -239,11 +238,10 @@ static int dcmipp_byteproc_set_fmt(struct v4l2_subdev *sd, struct v4l2_subdev_state *sd_state, struct v4l2_subdev_format *fmt) { - struct dcmipp_byteproc_device *byteproc = v4l2_get_subdevdata(sd); struct v4l2_mbus_framefmt *mf; struct v4l2_rect *crop, *compose; - if (byteproc->streaming) + if (v4l2_subdev_is_streaming(sd)) return -EBUSY; mf = v4l2_subdev_state_get_format(sd_state, fmt->pad); @@ -495,8 +493,6 @@ static int dcmipp_byteproc_s_stream(struct v4l2_subdev *sd, int enable) } } - byteproc->streaming = enable; - return 0; } diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-parallel.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-parallel.c index 62c5c3331cfec..05e8897ae37a4 100644 --- a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-parallel.c +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-parallel.c @@ -129,7 +129,6 @@ struct dcmipp_par_device { struct v4l2_subdev sd; struct device *dev; void __iomem *regs; - bool streaming; }; static const struct v4l2_mbus_framefmt fmt_default = { @@ -230,7 +229,7 @@ static int dcmipp_par_set_fmt(struct v4l2_subdev *sd, struct dcmipp_par_device *par = v4l2_get_subdevdata(sd); struct v4l2_mbus_framefmt *mf; - if (par->streaming) + if (v4l2_subdev_is_streaming(sd)) return -EBUSY; mf = v4l2_subdev_state_get_format(sd_state, fmt->pad); @@ -370,8 +369,6 @@ static int dcmipp_par_s_stream(struct v4l2_subdev *sd, int enable) reg_clear(par, DCMIPP_PRCR, DCMIPP_PRCR_ENABLE); } - par->streaming = enable; - return ret; } -- 2.53.0