From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793207306; b=HyxjRuRWcqsAoEj+o5OyVzlxGXvr0SUYk1smXC8yh90MNB01Dsm23OQnEwhFEvAqXx5i LiCI2YbSjJV90RTvoOpuUi/qdjtx470ycCgB6ZjTQ5UoHC4Yc+D/3bP6ojKMg1CDgqf2S my+h0He6sEJ24kd3ufD47NHhjIc2xsnNY5MCaPVhV2olPaZU5FJnDrZXa3jms7AaNGoDY 5TLr2hnQJI/3iRUeYnFzgzRLXGLAEhsVmz6H++ak3dDGNi54VAmyUsg2kRBDADdBfmEX9 mv/3YiemlVqTbpoRKBmTiBV9B1aZBavURTQ7IK/BkrX3UcY/BlDUrTM09btrk7Yy1ag== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793207306; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=93mxF0/wZ+PyBBqjzSOqGpKSfb9zMEvY5EZaXrHvn0Q=; b=IhCNXD8jt41yv7IzQHI2ETUXWnwEm83OTijru0rqJ4nqIQDiztqSI+w/4qsp0tM5t4US Sdut+t1EE8KCzF4XLDVWECpI2nyGSrN8bjOd4JV8CUAkEy+/ozXuFlAnRD8wi4wQupLYH s1xQ9RwuOR3BJtxOXO5ceBCQ3617KQGUwaaSXmPJ19sjThxPZAKQHaVWNQZvwoDVhLFLd BSfLeG/JNnnFTiB5MUkdIorUNkM7rj0O81X9E5c1t9du7miFJzJj0pz2E1Tf8Cw5/xf0C 414OCH+C8/nBmNbRXIzUdg0uwXlm4XzFvukl7Q3zR+IsAtC9DwrR45zszldipGIerJA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ZSrCWUcd; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CA31606A31A; Wed, 28 Oct 2026 17:08:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ZSrCWUcd Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF9331F01825; Wed, 28 Oct 2026 17:08:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793207306; bh=93mxF0/wZ+PyBBqjzSOqGpKSfb9zMEvY5EZaXrHvn0Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ZSrCWUcd0mdkgKzHgd3DrlKcyySCyRxThyN4urPyrqv/3DqdzxRunFbqlCjYC1gKo k2jdM+cQbsInlAsg9mD+nOue5zlWcqd2YYo01ll+M4pRzpDSdkIPGMaocGafHqrBY+ B411pTC7KEPfUqA3bqH/sz0sCXvh3VrV9BfmfLmg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Josef Bacik , Jens Axboe Subject: [PATCH 7.2 22/88] io_uring: dont flood a cancelling task with task_work Date: Wed, 28 Oct 2026 17:59:30 +0100 Message-ID: <20261028165942.640244449@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261028165942.107695352@linuxfoundation.org> References: <20261028165942.107695352@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Josef Bacik Commit 22e643e61b9b6299b42ff7d88bab48bccada8a5d upstream. io_ring_exit_work() asks each task which has used the ring to remove its tctx node, by task_work, and repeats that until the list is empty. io_tctx_exit_cb() doesn't touch the node while the task is in io_uring_cancel_generic(), which removes all the nodes at its end. So the work item queues the callback again as soon as it has completed, for nothing. That is more than a waste of time. task_work_run() only returns when it finds the list empty. If the rings are released from inside the cancellation, because requests of other rings held the last references to their files, up to 64 work items keep sending callbacks to the one task which is running them. It never finds the list empty, never gets back to the cancellation, the nodes stay, and so it goes on: a task with 60 pairs of rings which poll each other ran 280000 callbacks in 5 seconds, 20 seconds after exit_group(). It ends when all the senders happen to be late at the same time. Until then the task keeps a CPU and the work items busy. An exiting task can't be killed meanwhile. execve() cancels the requests in the same way, so a live task can get stuck there as well, for minutes. If it takes more than five, the work items run into the WARN_ON_ONCE(time_after(jiffies, timeout)) of io_ring_exit_work(). No privilege is needed for any of this. If the callback has met a task in cancellation, wait a little before it is sent again. Nobody has to wake the work item up for that: either the node is gone by then, or it is the turn of the next round. Fixes: d56d938b4bef ("io_uring: do ctx initiated file note removal") Assisted-by: LLM Signed-off-by: Josef Bacik Link: https://patch.msgid.link/20261015-b4-io-uring-fixes-v1-6-c1556f5d7bf5@toxicpanda.com Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- io_uring/io_uring.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -2310,6 +2310,7 @@ struct io_tctx_exit { struct callback_head task_work; struct completion completion; struct io_ring_ctx *ctx; + bool in_cancel; }; static __cold void io_tctx_exit_cb(struct callback_head *cb) @@ -2324,7 +2325,8 @@ static __cold void io_tctx_exit_cb(struc * tctx can be NULL if the queueing of this task_work raced with * work cancelation off the exec path. */ - if (tctx && !atomic_read(&tctx->in_cancel)) + work->in_cancel = tctx && atomic_read(&tctx->in_cancel); + if (tctx && !work->in_cancel) io_uring_del_tctx_node((unsigned long)work->ctx); complete(&work->completion); } @@ -2418,6 +2420,14 @@ static __cold void io_ring_exit_work(str * wait is marked as interruptible. */ wait_for_completion_interruptible(&exit.completion); + /* + * The task removes the node when it is done with its + * cancellation. Give it the time for that: it doesn't get back + * to it as long as it finds new task_work each time it has run + * the old one, and we may be one of many who send it. + */ + if (exit.in_cancel) + schedule_timeout_idle(HZ / 20); mutex_lock(&ctx->uring_lock); mutex_lock(&ctx->tctx_lock); }