From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793210261; b=GBXYta2tSwd2JF+wcQO2rqm0vHQZ5BQbWulOeHYVXdQO4lTSsqvEvnYCht05yo7x8JPQ 1yFGWLPV9pU83dJkMbqXSZ029N7nj1M9Nx78NVrioHSo0i9Cj2xYJ2U2oColSkm7B4bJC bhgxIKfw+08S+E1XdKcNWVQtwoJKFazsyCgfskD44i2yLYGLBBmJnjqJ6yNWkNiuFOWfH 9FEpIhin7j4Fin4qkkib/SgV+E+UaMMvfvzR0ciqBdt/ku06+QDQU/+Jhp4HOv1hMFeTy RV87DlWtQZVQC7UnNdOoXXlfFXeTJOzt22WL4aAxssWjcVHxqE2kUi1+DNGQTXZgK6w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793210261; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=YsXwUxINCXr1wpIVBxoy0a/TQ7/ejUEftpcv3mIktw8=; b=AryHkUsBrjs4f7Hm+unOWN84bMMm9VOUp7xhjPItYWveRV3kRtvftUH5hK0D61/fiFI1 7TVkG+UhY7S3woW1o4ZYS0Z/OJtmEyV42/aDZ9bg2xyMvrK/2w5ZYjObMgWE0vGn/UPyn Rvh37ZzDfP8sfUBCJ5/BklJrPjYWz6+dZjtiPaeNOagtHpTkDMFMttNvmzNgYjm05U87w K/gaMwZ2Mgxbtf+F4ytOwkkYU5OfA0K3xN1LE8PRBNiGOkm976LodPlh6XZyuoWmLZrGN E+L3QNx/BGACqQd3f+Li3CoYMjBy7CmZ8mMdvrS5ew5NGED3W7uw1Sy1IYK+9tN5g1g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=1iWQshg6; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 830B6606A31C; Wed, 28 Oct 2026 17:57:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=1iWQshg6 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7F981F01828; Wed, 28 Oct 2026 17:57:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793210261; bh=YsXwUxINCXr1wpIVBxoy0a/TQ7/ejUEftpcv3mIktw8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1iWQshg6sJjCQJGe9W8A9zsKYFJs53De/ASMF3jdmU+cipmiejY0xMAzntdQzO3Xt EjQWUGTXb3CXityl8Q7G12/451BlgbbEHgZPd8COCIsfXwSvs3I3RDS2NxX3p7wVWs ufMQh2CNkdoGOdNvKHsBcfgrWo0W6OkLQJLqAKwk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Josef Bacik , Jens Axboe , "Claude Fable 5.1" Subject: [PATCH 6.6 132/168] io_uring/io-wq: dont exit with a creation pending Date: Wed, 28 Oct 2026 18:01:08 +0100 Message-ID: <20261028165946.209507415@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261028165943.089486480@linuxfoundation.org> References: <20261028165943.089486480@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Josef Bacik Commit e231d2e8f80d3649ecd3851b7f2abdfbe606c04b upstream. A worker that is the last one to go to sleep while work is pending asks for another worker. io_wq_dec_running() bumps ->nr_running on behalf of the new worker and queues create_worker_cb() as task_work for the owner of the io-wq. Until that has run, everybody else takes it that a worker is running which is going to look after the work list: io_wq_enqueue() doesn't create one, and other workers that go to sleep don't find themselves to be the last. If the worker that made the request exits, io_worker_exit() cancels the task_work, and io_worker_cancel_cb() drops ->nr_running without a look at the work list: worker A worker B io_wq_enqueue() blocks, work is pending nr_running++ queues create_worker_cb() wakes, handles the work idle timeout, decides to exit picks up work 1 queues work 2 B is on the free list still: wakes B work 1 blocks nr_running 2 -> 1 io_worker_exit() io_worker_cancel_cb() nr_running 1 -> 0 Work 2 has to wait for work 1, although there is room for more workers. It takes an owner that doesn't get around to run its task_work for the time of the idle timeout, less if the worker exits because its affinity was changed or the io-wq is marked exit-on-idle. Let the worker stay around until its request has been dealt with. Only the worker itself sets ->create_state, so it can't be set behind its back once it has decided to leave. [ 6.6: no exit-on-idle state ] Fixes: 1d5f5ea7cb7d ("io-wq: remove worker to owner tw dependency") Assisted-by: LLM Signed-off-by: Josef Bacik Link: https://patch.msgid.link/20261015-b4-io-uring-fixes-v1-12-c1556f5d7bf5@toxicpanda.com Signed-off-by: Jens Axboe Co-Authored-By: Claude Fable 5.1 Signed-off-by: Greg Kroah-Hartman --- io_uring/io-wq.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- a/io_uring/io-wq.c +++ b/io_uring/io-wq.c @@ -708,8 +708,12 @@ static int io_wq_worker(void *data) /* * Last sleep timed out. Exit if we're not the last worker, * or if someone modified our affinity. + * Not as long as a request of ours for another worker is + * pending, though. It is accounted as a running worker, which + * others rely on, and io_worker_exit() would cancel it. */ - if (last_timeout && (exit_mask || acct->nr_workers > 1)) { + if (last_timeout && (exit_mask || acct->nr_workers > 1) && + !test_bit(0, &worker->create_state)) { acct->nr_workers--; if (test_and_clear_bit(IO_WORKER_F_FREE, &worker->flags)) hlist_nulls_del_init_rcu(&worker->nulls_node);