From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793210558; b=CeZTCfICT4JcBLzy8yw4ELFzk0Qpn3dHj105xQ27kiIYWeydaspX9OgmMQFVk1OzyTsv gElmyGKGNb0MmgRKx1j5RZ3ZGcsGEAEQFEs+hRiDBJ3meXxhhCfE7+BTpA/96RYwcfFM/ ++pnVfqogNJpWqTHnFpSCYALYTtjW8KAe/QHRF1MjQSfe1FHuUkEUnJ/gAD6eLiRk6i85 UfeJ6z6gOkGdhF7Um0tMgXmDlOcNObpaVwiuk6uz8uwRinXHGO1hovwt+k+DOfe2fRbv9 HEfcoNsonVkhxuDJsWjI7f0OtdoRbWdsIfYuJvF6Vr+DegFRXv/Z6gOYms6DxLNFKFw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793210558; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=q2FbSc6QxhQP9CL8nWHemAsC9/3VGUBgo+e58KsAHok=; b=v58a1fYzdhaJwLaa8ull3h2wuDoaiIJi9aJfafU7S6foc/yJ9LqNMWzurbjslZSdnU3B m6Y14vwCuKnH9IEs2DNjEY/Q5OZBa5OWnTFWZ4dRb50X5gzXweO6a5Ep3nYVKqYXZcV79 pxnOx9+DIDkzP5qSZg3HxG8STQUY6lSeW8z0llq2RpkRQeHXFdvz7ai2H7hAiciKOsnCV 7Chxy0b2gtkGZbJ2O1CtWs4r2ghM0xJ0SD9rUPRryLywtKtcQup9mTaUjOHNiNlC/SAnB egW5Fvf7UFLId5FEVnnTwnRMVpzPThoqawTI57yDVnYQU2uVuJBVtKW1qcuGbhTnCkw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=nlULERoj; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ECAE606A31D; Wed, 28 Oct 2026 18:02:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=nlULERoj Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54C201F01825; Wed, 28 Oct 2026 18:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793210557; bh=q2FbSc6QxhQP9CL8nWHemAsC9/3VGUBgo+e58KsAHok=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nlULERojl6XhiYoujsQ9YpBDScNs1vtkVBWtbcOJvIU6HdLKKbLW8DRVVuM9zla1d 9mpffwIAfQdsxXrCgvQYWRkYSye9CtlrrOK2zJq0ci2/n95GOMqS4PsaZayX48BqEf fwZUkcuz5AvbTvdrfm/8+KIRKQgV9W4oEyvwPSi8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fan Wu , Sebastian Reichel , Sasha Levin Subject: [PATCH 5.15 067/571] power: supply: rt9455: quiesce delayed work before teardown Date: Wed, 28 Oct 2026 17:53:34 +0100 Message-ID: <20261028170009.615325954@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261028170008.009143722@linuxfoundation.org> References: <20261028170008.009143722@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fan Wu [ Upstream commit 3e7a1ebc32fad5a558254a478efd401c17a24381 ] The threaded IRQ handler can queue pwr_rdy_work, max_charging_time_work and batt_presence_work. pwr_rdy_work and batt_presence_work can also queue max_charging_time_work, while batt_presence_work can requeue itself. rt9455_remove() cancels max_charging_time_work before batt_presence_work. The latter can therefore queue max_charging_time_work after it has already been cancelled: rt9455_remove() workqueue cancel pwr_rdy_work cancel max_charging_time_work batt_presence_work queues max_charging_time_work cancel batt_presence_work return devres frees rt9455_info max_charging_time_work dereferences rt9455_info The IRQ also remains registered until devres cleanup and can queue more work after any of the cancellation calls. If rt9455_hw_init() fails after the IRQ has been requested, probe returns without cancelling work that may already have been queued. A pending callback can then access rt9455_info after it has been freed. Register rt9455_cancel_all_delayed_works() through devm_add_action_or_reset() right after devm_power_supply_register(). devres invokes the action in reverse registration order, after the managed IRQ has been freed and before rt9455_info is released, so the delayed works are drained in both rt9455_remove() and the probe error path. Cancel pwr_rdy_work and batt_presence_work before max_charging_time_work because both can queue the latter. This issue was found by an in-house static analysis tool. Fixes: e86d69dd786e ("power_supply: Add support for Richtek RT9455 battery charger") Cc: stable@vger.kernel.org Assisted-by: Codex:gpt-5.6 Signed-off-by: Fan Wu Link: https://patch.msgid.link/20260723225310.12663-1-fanwu01@zju.edu.cn Signed-off-by: Sebastian Reichel [ retained the int-returning rt9455_remove() callback required by the older I²C interface. ] Signed-off-by: Sasha Levin --- drivers/power/supply/rt9455_charger.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/rt9455_charger.c b/drivers/power/supply/rt9455_charger.c index 6f6adc7446a6d..310cae3f61f09 100644 --- a/drivers/power/supply/rt9455_charger.c +++ b/drivers/power/supply/rt9455_charger.c @@ -1583,6 +1583,19 @@ static const struct regmap_config rt9455_regmap_config = { .cache_type = REGCACHE_RBTREE, }; +static void rt9455_cancel_all_delayed_works(void *data) +{ + struct rt9455_info *info = data; + + /* + * Both pwr_rdy_work and batt_presence_work can queue + * max_charging_time_work, so cancel them first. + */ + cancel_delayed_work_sync(&info->pwr_rdy_work); + cancel_delayed_work_sync(&info->batt_presence_work); + cancel_delayed_work_sync(&info->max_charging_time_work); +} + static int rt9455_probe(struct i2c_client *client) { struct i2c_adapter *adapter = client->adapter; @@ -1673,6 +1686,10 @@ static int rt9455_probe(struct i2c_client *client) goto put_usb_notifier; } + ret = devm_add_action_or_reset(dev, rt9455_cancel_all_delayed_works, info); + if (ret) + goto put_usb_notifier; + ret = devm_request_threaded_irq(dev, client->irq, NULL, rt9455_irq_handler_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT, @@ -1714,10 +1731,6 @@ static int rt9455_remove(struct i2c_client *client) usb_unregister_notifier(info->usb_phy, &info->nb); #endif - cancel_delayed_work_sync(&info->pwr_rdy_work); - cancel_delayed_work_sync(&info->max_charging_time_work); - cancel_delayed_work_sync(&info->batt_presence_work); - return ret; } -- 2.53.0