From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793210732; b=hmXmAmwi39amyT/f75Bbv7pyntWFHgCDSJN//RzQNSZmXZi0OhxM7v5fGd3Prr1cqHzN Ej1z5CZo7lDsBoEppNclAldboMLUGpy5FyazJCsOp7n9++ZowHLh8GpdtEqoOc51sSW0C EGsvBRM2Gf5WZpNla4f96Qn01oe6bYZsJm400WGf6qKLWMEsOHT89BvKB4HPGEBvcsVdM QhxZ9/vR5JweDuXE0N8hGYt073yEGVeI7HCuFXrwLJ1z9jmLOWi1Xu9NXwh5/bdfMXiod AJMfBGGW5ujLVSLTZEA70TVBj6mifh+GUJU/ooHaVjWO6ylbAjUeoaeHnRZvbryzI8A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793210732; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=J3NR+pLgnMf1+FQY2N5Sgs8e2mMKKpJb8X4uhAKEmk0=; b=3hgyKjv7U04hSCXzSux5PA8GBaC4wiSR7SZ1eh6e6Pz8XBPkcMwjZ74m1D/UX5YrGjXy UBOgoj/3dZx5yeW1wUpvi185TmNJoEKJ85YOrKNBgl76yldamhais2j0cV2qUftUVNEn6 YtwgnW5lhR/0KNoOpdc0cF5fEcDhEPc6BWkPIDrKCrP1xj8fBSEFue49m4G4Bere33Fqd VvuQ9yZAbvnLNqjzAxOMzOGpLNDiqvWrENRqOSh0JO0bRp2pewgC21jNG1WDOEUunWcbt 0OdcwfmCkjY+g/GJbHem0Ztcbj7AIoBalk8nR9K7LCOnWM5zGnYKL0w/oCCFlaPZWIg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=OjWkN1iB; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DB1A606A31A; Wed, 28 Oct 2026 18:05:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=OjWkN1iB Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D99C1F01825; Wed, 28 Oct 2026 18:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793210732; bh=J3NR+pLgnMf1+FQY2N5Sgs8e2mMKKpJb8X4uhAKEmk0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=OjWkN1iBf/QQWuE23QRGSixa9bkjCVFRFa5ibaYwrUnkTPJdAgfIEzesmELVyBN31 8CupLzE54IRRoFTInyHFBlPs/MoJ0dY6LlsjlvRVQsin1kYYTYs2RLu8PWtx/e7kv8 3zhLeRGPeda26CnXBzRa3SeAMwdIO7/pv2r85pyw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sashiko , Nilesh Javali , "Martin K. Petersen (Oracle)" , Sasha Levin Subject: [PATCH 5.15 085/571] scsi: qla2xxx: Null out freed pointers in qla2x00_mem_alloc() error path Date: Wed, 28 Oct 2026 17:53:52 +0100 Message-ID: <20261028170010.043497137@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261028170008.009143722@linuxfoundation.org> References: <20261028170008.009143722@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nilesh Javali [ Upstream commit 6d90f0feb929f6c0f3010f9af4747c7230b75993 ] When qla2x00_mem_alloc() fails, qla2x00_probe_one() jumps to probe_hw_failed and calls qla2x00_mem_free(). Several error labels in qla2x00_mem_alloc() freed adapter members (elsrej.c, purex_dma_pool, flt, sfp_data, loop_id_map, async_pd, sf_init_cb, ex_init_cb, npiv_info) but left the pointers dangling. qla2x00_mem_free() then freed them a second time. Worse, for the dma_pool members it issued dma_pool_free(ha->s_dma_pool, ...) after s_dma_pool had already been destroyed and set to NULL at fail_s_dma_pool, dereferencing a NULL pool. Clear each freed pointer (and its DMA handle) in the error labels so the subsequent qla2x00_mem_free() skips them. Cc: stable@vger.kernel.org Reported-by: Sashiko Signed-off-by: Nilesh Javali Link: https://patch.msgid.link/20260730155838.2119230-13-njavali@marvell.com Signed-off-by: Martin K. Petersen (Oracle) [ adapted cleanup changes for missing fail_lsrjt and fail_flt_data blocks. ] Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_os.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 31d9eec75ee18..2e787858f9d50 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -4431,23 +4431,36 @@ qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_t req_len, uint16_t rsp_len, fail_elsrej: dma_pool_destroy(ha->purex_dma_pool); + ha->purex_dma_pool = NULL; fail_flt: dma_free_coherent(&ha->pdev->dev, sizeof(struct qla_flt_header) + FLT_REGIONS_SIZE, ha->flt, ha->flt_dma); + ha->flt = NULL; + ha->flt_dma = 0; fail_flt_buffer: dma_free_coherent(&ha->pdev->dev, SFP_DEV_SIZE, ha->sfp_data, ha->sfp_data_dma); + ha->sfp_data = NULL; + ha->sfp_data_dma = 0; fail_sfp_data: kfree(ha->loop_id_map); + ha->loop_id_map = NULL; fail_loop_id_map: dma_pool_free(ha->s_dma_pool, ha->async_pd, ha->async_pd_dma); + ha->async_pd = NULL; + ha->async_pd_dma = 0; fail_async_pd: dma_pool_free(ha->s_dma_pool, ha->sf_init_cb, ha->sf_init_cb_dma); + ha->sf_init_cb = NULL; + ha->sf_init_cb_dma = 0; fail_sf_init_cb: dma_pool_free(ha->s_dma_pool, ha->ex_init_cb, ha->ex_init_cb_dma); + ha->ex_init_cb = NULL; + ha->ex_init_cb_dma = 0; fail_ex_init_cb: kfree(ha->npiv_info); + ha->npiv_info = NULL; fail_npiv_info: dma_free_coherent(&ha->pdev->dev, ((*rsp)->length + 1) * sizeof(response_t), (*rsp)->ring, (*rsp)->dma); -- 2.53.0