From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793209065; b=f7NeZkBHmtFaSrZvT6InOoa4NkHanYqz6KOF9WbkhuI8qvSzSxavOv/omuy4dRpgYWxS ctJWZ3PVJcH8WbCEtRGh6a/rbBEHokYWxQVnNNuw9juID9OENXxehUM2yVQz7NiDXliey IFlOgIq1i/3Sz5mYIVsYKZvFfQfwOKxfYZTlfMKAJrEDJ5pP/biH1HPvqw/TBrFTOSkV5 zfmYwqZpVkgOhX61cDvdTg7PNDxQJ1wqwcFNq9SoO0ZXJRztNRAZPPexA+jerPSxQH59C DIQ1EaWuMgjmH7LnUVYU2+Zl8M92gKLZFXDdhXL31LJZHuDfGhr557hWEZxxRhjPpDQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793209065; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=dG7G3rj9RHleX98gsGwayNZNSfIVbP10O/skZU+rlfA=; b=BGIxrk60f1Rrnwl9CInHKzoP0Sp27+SeOK913eTgy6XJ+N35sZXA+K7r4VtopzeqByEL sVXcS68OPBHxA3fX2JkEEQHOzZt+Vsbw+/3CRM/wE1lldtDqh7A80JmYuxkthA3TEhaLc 5FFdOjzS3n2wyQYO1/jXJ+aJaoiOA5kwsDarSU7YrAs+uTxB7jA4U6H+yrEyk/1jM9bKp HKhAaVJ6GKYyO0S0d2MWifzb3TN1AbGGQDCBHkcyhdZAvQb50nY/14G1SPu0Lz6pUnl92 DWAgMNlwBmMNAjYm6Rqs5TcUn7UJtpf8G8EUOMnT7dT7AuzIRBeJUeF6rbo1xwpvrdg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=aPu6c0MY; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6441960A5BCD; Wed, 28 Oct 2026 17:37:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=aPu6c0MY Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5C7B1F031E6; Wed, 28 Oct 2026 17:37:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793209065; bh=dG7G3rj9RHleX98gsGwayNZNSfIVbP10O/skZU+rlfA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=aPu6c0MYAH+oNBse3OwBMhfKQUnxgIgVPTps9QDjmFtdACL3hVGTQMYRgFdC/31+5 QTuKTe5KzF+9S9ElDS4/YlQcBGA8NjcTChqdbF/+NYQZqOpyppO/lSBSnZtXmBQKhU pQMo+zWyYnqRiX5gJLmnwG4DysfZf0wWi0Zgj0sk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Abhishek Ojha , Mark Brown Subject: [PATCH 5.10 341/516] regulator: ltc3676: dont read the write-only HRST and CLIRQ registers Date: Wed, 28 Oct 2026 17:58:13 +0100 Message-ID: <20261028170011.565025802@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261028170003.522232767@linuxfoundation.org> References: <20261028170003.522232767@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Abhishek Ojha commit 28c2388ee24cdbefbcc458fa41ef7bffaaa1cc83 upstream. HRST (0x1e) and CLIRQ (0x1f) are write-only command strobes. Writing HRST triggers a hard reset of the chip and writing CLIRQ clears the interrupt; reading them returns nothing useful, and the read itself fires the command. The result is that a plain register dump resets the board: cat /sys/kernel/debug/regmap/2-003c/registers walks every readable register, hits HRST, and the board reboots. Split the callback back in two so HRST and CLIRQ stay writable but are no longer readable. The readable range is left unchanged (LTC3676_BUCK1 ... LTC3676_IRQSTAT). Fixes: 37b918a034fe ("regulator: Add LTC3676 support") Cc: stable@vger.kernel.org Signed-off-by: Abhishek Ojha Link: https://patch.msgid.link/20260902010701.3360310-1-Abhishek.ojha@savoirfairelinux.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/regulator/ltc3676.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) --- a/drivers/regulator/ltc3676.c +++ b/drivers/regulator/ltc3676.c @@ -232,7 +232,7 @@ static const struct regulator_desc ltc36 LTC3676_FIXED_REG(LDO4, ldo4, LDOB, 2), }; -static bool ltc3676_readable_writeable_reg(struct device *dev, unsigned int reg) +static bool ltc3676_writeable_reg(struct device *dev, unsigned int reg) { switch (reg) { case LTC3676_BUCK1 ... LTC3676_IRQSTAT: @@ -243,6 +243,15 @@ static bool ltc3676_readable_writeable_r return false; } +static bool ltc3676_readable_reg(struct device *dev, unsigned int reg) +{ + switch (reg) { + case LTC3676_BUCK1 ... LTC3676_IRQSTAT: + return true; + } + return false; +} + static bool ltc3676_volatile_reg(struct device *dev, unsigned int reg) { switch (reg) { @@ -255,8 +264,8 @@ static bool ltc3676_volatile_reg(struct static const struct regmap_config ltc3676_regmap_config = { .reg_bits = 8, .val_bits = 8, - .writeable_reg = ltc3676_readable_writeable_reg, - .readable_reg = ltc3676_readable_writeable_reg, + .writeable_reg = ltc3676_writeable_reg, + .readable_reg = ltc3676_readable_reg, .volatile_reg = ltc3676_volatile_reg, .max_register = LTC3676_CLIRQ, .use_single_read = true,