From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793831802; b=Eiw/FEkIPE9SG6p91NA8/NsUjn8tFznVg281+9s3kpx5F7UXy14WCssYuXSMtmdnwdXq VYY3u9jlu40bE13lZShwJFDGh2QEBviWOE47CkvG53WKpasKIxcdbeM5PYHrQwn9Moq0K uKvduqz9eQwFPYVLo7WHOk85Sw2l+T/uCOYWlXMYdVtvJ/gBO61gdhqNpVdZY7ePiMjf5 TlMnYRdTiaNCR3iZ++mmyxxNfn2lHNZLT9EG4B1t8AnC9JkvnywXz4LscL+ODJ0U8FD4r IeIKlgQLRAdxQY4duYJ7IvlJPoRM6vGiJnxJ8oCDbDL6LXMK/58xgwXAu44nhFwOvVA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793831802; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=n0AefsBXzAlVErziXEDXspeqaZrjTqhOAF/BM0k4Chk=; b=HHlhKEiF3yHut4iq7LHE3CvaAgzzojlNs3LT0P3cJ6Y/sdQwZUPlnoH4k0zKlBdvpfyY G885LCOGx690xKr6P3mwrWx4y9IQbRzUI0X9KiI6/aZHoaTUJUBPZF2ND/Lu0iX3q6dwF +j73ISsRj185lA/YwxjuCaXGje9H3SoXaWHi0Lj+qvOZIJhFL+Z+iDr9ZAie4BWWEgktN difpDua2r0Y6zax4sddtFIZHfr4uQm3HIDrguG/qFFxUj1LeZGf/X4r7B1slW65xXmyt+ mjCL4B2ndM8vtN0tOb8NB2E6p1Janhbxjuf6IXwNOg1g64KntjFp9uXwjbxprF9Qh6A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Zsdag5N3; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C7A9606A33A; Wed, 4 Nov 2026 22:36:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Zsdag5N3 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4418D1F000C1; Wed, 4 Nov 2026 22:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793831802; bh=n0AefsBXzAlVErziXEDXspeqaZrjTqhOAF/BM0k4Chk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Zsdag5N3v+XvUzO9Ggq/OLqn+9qEgAYq0EDgwKfSPyOhd2ZLP8rp1TR34z/zgsjqB 4Lk1YjpJTf2xlQ6EarsuUcobldNM9Q8LBX4rSIPCw62ffdj465PYJQDCNiNNT4Ishn tfIB1cZ4FM+WZ/IfpPoKWQybopuLECQDBLcjvSSo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, David Howells , Marc Dionne , Eric Dumazet , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-afs@lists.infradead.org, stable@kernel.org Subject: [PATCH 6.18 0921/1005] rxrpc: Fix double IRQ enablement Date: Wed, 4 Nov 2026 16:10:54 -0500 Message-ID: <20261104211108.947574916@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261104211043.516122098@linuxfoundation.org> References: <20261104211043.516122098@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Howells commit 41eb0af096ba8754e584d47e6de42f1e4980ceae upstream. rxrpc_notify_socket() explicitly disables and then re-enables IRQs, but one of its call chains (rxrpc_input_queue_data() -> rxrpc_end_rx_phase() -> rxrpc_call_completed() -> rxrpc_set_call_completion()) has IRQs disabled around it. Fix this by making rxrpc_notify_socket() use irqsave spinlocks. Fixes: a2ea9a907260 ("rxrpc: Use irq-disabling spinlocks between app and I/O thread") Link: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260812110129.979970-6-dhowells@redhat.com Signed-off-by: David Howells cc: Marc Dionne cc: Eric Dumazet cc: "David S. Miller" cc: Jakub Kicinski cc: Paolo Abeni cc: Simon Horman cc: linux-afs@lists.infradead.org cc: stable@kernel.org Link: https://patch.msgid.link/20261006133011.531806-9-dhowells@redhat.com Signed-off-by: Paolo Abeni Signed-off-by: Greg Kroah-Hartman --- net/rxrpc/recvmsg.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) --- a/net/rxrpc/recvmsg.c +++ b/net/rxrpc/recvmsg.c @@ -24,6 +24,7 @@ void rxrpc_notify_socket(struct rxrpc_ca { struct rxrpc_sock *rx; struct sock *sk; + unsigned long flags; _enter("%d", call->debug_id); @@ -38,16 +39,16 @@ void rxrpc_notify_socket(struct rxrpc_ca sk = &rx->sk; if (rx && sk->sk_state < RXRPC_CLOSE) { if (call->notify_rx) { - spin_lock_irq(&call->notify_lock); + spin_lock_irqsave(&call->notify_lock, flags); call->notify_rx(sk, call, call->user_call_ID); - spin_unlock_irq(&call->notify_lock); + spin_unlock_irqrestore(&call->notify_lock, flags); } else { - spin_lock_irq(&rx->recvmsg_lock); + spin_lock_irqsave(&rx->recvmsg_lock, flags); if (list_empty(&call->recvmsg_link)) { rxrpc_get_call(call, rxrpc_call_get_notify_socket); list_add_tail(&call->recvmsg_link, &rx->recvmsg_q); } - spin_unlock_irq(&rx->recvmsg_lock); + spin_unlock_irqrestore(&rx->recvmsg_lock, flags); if (!sock_flag(sk, SOCK_DEAD)) { _debug("call %ps", sk->sk_data_ready);