From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794063850; b=RgigGVVbUYpzC41eoYiK+c4OJPvNfef9QEuoRnVwa6E6Z2iT+gXPgWB0/64GgWWpM+ai JyKOOlBjtkRQLeZ2Q+LzrLgwQp/r8iEmZ+DQdtRAI29IVvEJ2njNjlitk/X7ORsYgJbc0 R2uCBycCIZ1oBqvl7a+COEIJA1mGvQ0vUUTI9hz+5DGcJGHxEBqe6JtszOneCr7YEQbKe bzsoxafKx+B848BHkVlo04O3g7NG7cw4Qi+IxCBTsaAHi2U2YsWAo9R679LsfFqLeM9AR isyQrgRbd5/3byZsXdutmozPvXYdo8mErtI3InAtmFKGQMdlUwvmRWnG+CmGyqFSMLw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794063850; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=1DAgQEgV1Yd+vSG98eT6oFALO7oReuXq3Aj8DvFpeGY=; b=ImHq8xF9tZMZsJUtv9Q+XFg+HZrDHxgBAIoHIOONZEyQ55IAEpXzwo9Doo84T+eLaDN9 3OjawYFF58JejI+Av2Fke/D+tHE4ZtkkqmfQ/9+tYqydZudP8ekhWOkgQRWYVPrvNEisP SxlOhu5DgHEoiQhU8ChA4lJjdFIM29fK6MyX5usMbzc0h9DLQcUh2WsaCfYCSCzhhA4z4 A3gJDkxHSWGR+TV7rx/CTsWlaFCQFYXn43lbunaYJc+B3hQOGRwiw1i/eLaS3uoG9MnF7 67RhmAT0AiLuAXGa8BA3/LZXBvas8BDLVEEQx0BxsNOz5TDcQuS2igexy+Dr9tgk/yw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=kxGucAQb; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45084606C011; Sat, 7 Nov 2026 15:04:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=kxGucAQb Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1DBE1F0089F; Sat, 7 Nov 2026 15:04:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794063849; bh=1DAgQEgV1Yd+vSG98eT6oFALO7oReuXq3Aj8DvFpeGY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=kxGucAQbY+aWPwAuir3dsLLk8D3yNCufCDIQRbC3fjjuWan67WRF6bmmnvbH9JQLZ BeQS+JPdEhfZA50jFEZt90fxpX6x8bV+sw+h9hdLNPqob1peuvN953owER/dnrVzFT SpqIxc1hcHKFeh3AnGS6weJOxS9uAjkzSTdz4zMQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sakari Ailus , Ricardo Ribalda , "Rafael J. Wysocki (Intel)" , Daniel Scally , Sasha Levin Subject: [PATCH 7.3 0060/1257] platform/x86: int3472: Fix uninitialised variable warning Date: Sat, 7 Nov 2026 08:39:16 -0500 Message-ID: <20261107134941.059671601@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134939.434104957@linuxfoundation.org> References: <20261107134939.434104957@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sakari Ailus [ Upstream commit 70e6384fe0f4cf9768944f81924f6c1478b0ce43 ] Fix a compiler warning about an uninitialised err_msg variable by printing the error where it is handled: drivers/platform/x86/intel/int3472/discrete.c:440:24: warning: ‘err_msg’ may be used uninitialized [-Wmaybe-uninitialized] 440 | return dev_err_probe(int3472->dev, ret, err_msg); Fixes: 5de691bffe57 ("platform/x86: Add intel_skl_int3472 driver") Cc: stable@vger.kernel.org Signed-off-by: Sakari Ailus Reviewed-by: Ricardo Ribalda Acked-by: Rafael J. Wysocki (Intel) Reviewed-by: Daniel Scally Signed-off-by: Sasha Levin --- drivers/platform/x86/intel/int3472/discrete.c | 25 +++++++++++-------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c index 6c729fcfce5db..9cd4f78875abf 100644 --- a/drivers/platform/x86/intel/int3472/discrete.c +++ b/drivers/platform/x86/intel/int3472/discrete.c @@ -329,7 +329,6 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, unsigned long gpio_flags; union acpi_object *obj; struct gpio_desc *gpio; - const char *err_msg; const char *con_id; int ret; @@ -375,7 +374,8 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, case INT3472_GPIO_TYPE_HOTPLUG_DETECT: ret = skl_int3472_map_gpio_to_sensor(int3472, agpio, con_id, gpio_flags); if (ret) - err_msg = "Failed to map GPIO pin to sensor\n"; + dev_err_probe(int3472->dev, ret, + "Failed to map GPIO pin to sensor\n"); break; case INT3472_GPIO_TYPE_CLK_ENABLE: @@ -387,7 +387,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, gpio = skl_int3472_gpiod_get_from_temp_lookup(int3472, agpio, con_id, gpio_flags); if (IS_ERR(gpio)) { ret = PTR_ERR(gpio); - err_msg = "Failed to get GPIO\n"; + dev_err_probe(int3472->dev, ret, "Failed to get GPIO\n"); break; } @@ -395,14 +395,16 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, case INT3472_GPIO_TYPE_CLK_ENABLE: ret = skl_int3472_register_gpio_clock(int3472, gpio); if (ret) - err_msg = "Failed to register clock\n"; + dev_err_probe(int3472->dev, ret, + "Failed to register clock\n"); break; case INT3472_GPIO_TYPE_PRIVACY_LED: case INT3472_GPIO_TYPE_STROBE: ret = skl_int3472_register_led(int3472, gpio, con_id); if (ret) - err_msg = "Failed to register LED\n"; + dev_err_probe(int3472->dev, ret, + "Failed to register LED\n"); break; case INT3472_GPIO_TYPE_POWER_ENABLE: @@ -413,7 +415,8 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, ret = skl_int3472_register_regulator(int3472, gpio, enable_time_us, con_id, second_sensor); if (ret) - err_msg = "Failed to register regulator\n"; + dev_err_probe(int3472->dev, ret, + "Failed to register regulator\n"); break; default: /* Never reached */ @@ -436,11 +439,11 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, int3472->ngpios++; ACPI_FREE(obj); - if (ret < 0) - return dev_err_probe(int3472->dev, ret, err_msg); - - /* Tell acpi_dev_get_resources() to not make a copy of the resource */ - return 1; + /* + * Either return an error or tell acpi_dev_get_resources() to not make a + * copy of the resource. + */ + return ret < 0 ? ret : 1; } int int3472_discrete_parse_crs(struct int3472_discrete_device *int3472) -- 2.53.0