From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794064656; b=mb2SvtMVoZj7m3vJvnrbxEVny8sPC7gdcgkcDcrCFPcIEnMghv/5E/AvLnUQSDNwae6O 0lyvzE6O7W8uCmTSNkuB1IW4iPXOZtYIQvmL/CQjFNp+84yVmI3E4QprO4IBTjjgJWEDO 4KPJFtIIENcu2wRbk3NM2uI5V6MvdOLZX4tTrEcK6VyjkWAcI8vxWswibXqt9TxQlpdj1 kB7pDTuI6qEDz1CMuGn836eVL54hWB9Mse/7PkznbL9kO5OPe2ZIVirHPiahUyMKgtzom xlQy1u6G58jATV/ktrn3pwUn8z+RNU5XhAhzP++GJvNEr0k7uDeuplsjQMgAWvL6J/w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794064656; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=Xdt/jX6KkjhVkmcKEvlL1IHyaPzatXXzbd6fc7aTAFE=; b=Gyq+pn5dB4dFe9FaVlelkNSSaKFDvHlgiS3iLR5Y4JndOoC8vXXqNFb5QozCurT8TBOD tuDTM9t0FXLXX8vrRSFKn2jnvXeJYWdo3YYbrKYLipvKX4favKW//tOJe5Mm4dAEkJvWX nB+YlalSVqDHWcT7ru9qFB55IbO76bL9eJtUoyDhRRZdZdS3VbuQPDiewDnZMHZjr/Mqn hOtcllo8PK/5BwJe1vuLwKMki3Gvu4beohAJAa9pEl1wvg0vN3/jWZi00GVlETQXUPAjP mZE1Sw8LjkV1LmNaABzIBP9kdKzzLPlVE9ZvkV64JqVQ/hqV9QQaj2zIpMpykiKGx9Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=UmeooTaI; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4CF7606A9D5; Sat, 7 Nov 2026 15:17:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=UmeooTaI Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EC531F008A1; Sat, 7 Nov 2026 15:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794064655; bh=Xdt/jX6KkjhVkmcKEvlL1IHyaPzatXXzbd6fc7aTAFE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=UmeooTaI+uEcHUawtgOBisV96WWlQ7rrPhUYkGMNm2Y6X0NXzSR2LD5f8oAeA4e/S 24YcGwiYFLjFnFmpnCYi7W3Hn9oNbttzQqaU+DXMi+D7YQOTjEplr3b3iJqUJ2Wmkk 49u23CtRs/HXpEfGnpORuLxuyM/OcrYUdYL6VO94= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gregory Price , Andrew Morton , sashiko-bot , "David Hildenbrand (Arm)" , Jann Horn , Jason Gunthorpe , "Liam R. Howlett" , Lorenzo Stoakes , Pedro Falcato , Peter Xu , Vlastimil Babka , Sasha Levin Subject: [PATCH 7.3 0656/1257] proc/task_mmu: handle special PMDs in clear_refs and pagemap Date: Sat, 7 Nov 2026 08:49:12 -0500 Message-ID: <20261107134957.379529607@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261107134939.434104957@linuxfoundation.org> References: <20261107134939.434104957@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gregory Price [ Upstream commit d350956d829f4b620faf294c86116de640f1518c ] mshv_vtl_low can install a special PMD from a PFN supplied in the mmap file offset. That PFN need not have a memmap entry. Reading /proc/PID/pagemap or writing /proc/PID/clear_refs for such a mapping oopses the kernel. With a test driver mapping the PFN at the 1 TiB mark: echo 1 > /proc/self/clear_refs BUG: unable to handle page fault for address: fffffb5b80000008 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page RIP: 0010:clear_refs_pte_range+0xb1/0x1e0 Call Trace: walk_pgd_range+0x50a/0xad0 __walk_page_range+0x6a/0x1d0 walk_page_range_mm_unsafe+0x193/0x230 clear_refs_write+0x18e/0x3f0 pread(pagemap_fd, buf, 512 * 8, addr / PAGE_SIZE * 8) BUG: unable to handle page fault for address: fffff57840000008 RIP: 0010:pagemap_pmd_range+0x3cf/0x6b0 Call Trace: walk_pgd_range+0x50a/0xad0 __walk_page_range+0x6a/0x1d0 walk_page_range_mm_unsafe+0x193/0x230 pagemap_read+0x1dc/0x350 clear_refs_pte_range() passes the PMD to pmd_folio(), while pagemap_pmd_range_thp() uses pmd_page() followed by page_folio(). Both paths assume the PFN has a struct page and dereference bad address. Use vm_normal_folio_pmd() and vm_normal_page_pmd() so clear_refs skips folio operations and pagemap skips folio-derived flags for special PMDs. This matches the PTE paths, which already use vm_normal_folio() and vm_normal_page(). User-facing notes: - Pagemap still reports PM_PRESENT and the PFN to a CAP_SYS_ADMIN reader. - For a special PMD backed by a valid memmap entry and for the huge zero PMD, PM_FILE changes from set to clear. - PM_MMAP_EXCLUSIVE is already clear in both cases. - The output for an anonymous THP is unchanged. Tested in QEMU with the test driver on broken and fixed kernels. Both proc operations oops before the fix and return 0 after it. This is technically reachable via mshv_vtl_low, so I tagged it stable. Link: https://lore.kernel.org/20260912122822.3348978-1-gourry@gourry.net Fixes: 3c8e44c9b369 ("mm: mark special bits for huge pfn mappings when inject") Signed-off-by: Gregory Price Signed-off-by: Andrew Morton Reported-by: sashiko-bot Closes: https://sashiko.dev/#/patchset/20260912034833.2952750-1-gourry%40gourry.net Acked-by: David Hildenbrand (Arm) Assisted-by: LLM Cc: Jann Horn Cc: Jason Gunthorpe Cc: Liam R. Howlett Cc: Lorenzo Stoakes Cc: Pedro Falcato Cc: Peter Xu Cc: Vlastimil Babka Cc: # v6.19+ Signed-off-by: Sasha Levin --- fs/proc/task_mmu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index dd025474b0fc9..a2db957aa7996 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -1786,7 +1786,9 @@ static int clear_refs_pte_range(pmd_t *pmd, unsigned long addr, if (!pmd_present(*pmd)) goto out; - folio = pmd_folio(*pmd); + folio = vm_normal_folio_pmd(vma, addr, *pmd); + if (!folio) + goto out; /* Clear accessed and referenced bits. */ pmdp_test_and_clear_young(vma, addr, pmd); @@ -2106,7 +2108,7 @@ static int pagemap_pmd_range_thp(pmd_t *pmdp, unsigned long addr, goto populate_pagemap; if (pmd_present(pmd)) { - page = pmd_page(pmd); + page = vm_normal_page_pmd(vma, addr, pmd); flags |= PM_PRESENT; if (pmd_soft_dirty(pmd)) -- 2.53.0