From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794590899; b=wN9peeSiQI9pBCvSdEyHNggTZ25KpcqdBhGTNXq4CaKAMjirL0YMEWi23fdiN86ZUPRh 0NKpw/mk4fhZjapIVYARGhKGTRuVBXIUn8wuhmppiQG0VnGaze2CLVOKSxu0y5FscMs8c 2AuCz0+zo8bAxNdX5mgGzBvEZAlzfvOi3BVRQPdiz3Q0eIx6ixra2V7RtrQLgzuBLRLrG GsDm4ulOKka9CfgB80ltrhzNVRLebYbxGK6IjUQ1lOSQB/XsCypC2u2IyJfxUnKGOmRd1 W1zna6UIfsvnn8PMh8T954+jnkQGYLuSlg2dXI82j6vAH44k7/yBId52U8j4VIVZHng== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794590899; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=ec3avjnKbG4VFlO55MdyD9YtCYn0NSsMaLDS5oXnb4A=; b=clCtrzWMMUfwDtNsKlyrjjf3CDBNvoz8psPryFdm1X0/0rE1+Cay43sZtiQcHIr9ZWUd fNFWbVryevqYQqRaLz2dq+Jn9kYfsqLEpKT1T97KMzyeK1kA0mEqg3ZTJvtNIU/+KtV4p EzQ4Gh84Nc5O2W91EiKApnz9AFMOVnJAXUIn6gMNGWCETh8tpGRY75mvz2TM99LYmczUU RZJMazDlQJ/HHNaLyzxVWic8l9GhO1SHkTPeP5Ot7MvjhLXLrZEm7QlZibotbk7Z9XfLJ ToS0Ok+Rf24jfJqIhyLTT1NxTsA+j/WGi+eXgfCsbGkkodBe219Mqi3HznnYKFhO4Tg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=yQQaoYFK; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC230606E220; Fri, 13 Nov 2026 17:28:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=yQQaoYFK Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E3941F000C5; Fri, 13 Nov 2026 17:28:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794590898; bh=ec3avjnKbG4VFlO55MdyD9YtCYn0NSsMaLDS5oXnb4A=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=yQQaoYFK3OSoNLP8zLXYZZLtrEzOU1oyN7tHDXVYDa+kqavHTKeonApL/OxwDHbb5 CRyFxKRDjN8JBC1rZKqqJYZMvxM2q9a6GuQBzWcmvFbpkqeGOcfGDOLrsmrpuuOV/6 GtFcLRK6uoKtuDkesJgTvej9vjSRdsoVQ1GQrGos= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Rosen Penev , Daniel Machon , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.12 089/670] net: bgmac: enable interrupts only after NAPI is ready Date: Fri, 13 Nov 2026 10:44:13 -0500 Message-ID: <20261113153814.930763235@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261113153811.177190860@linuxfoundation.org> References: <20261113153811.177190860@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Rosen Penev [ Upstream commit ac1f6e58cb77bb66b8811f7d98703e0f076a8f65 ] bgmac_open() calls bgmac_chip_init(), which unmasks the interrupts and enables the MAC receiver, before request_irq() and napi_enable(). bgmac_enet_resume() also enables NAPI only after bgmac_chip_init(). When frames arrive in that window, the first RX interrupt masks all interrupts in bgmac_interrupt() and calls napi_schedule() on a NAPI instance that is still disabled, so nothing is scheduled. Nothing unmasks the interrupts again, the RX ring fills up and the interface stays deaf until it is brought down and up without traffic. On an Asus RT-N16 (BCM4716) a single "ip link set eth0 down/up" while a host sends UDP to the router left INT_MASK at 0, INT_STATUS with RX pending and the RX DMA idle on a full ring, with the RX packet and interrupt counters no longer moving. With this change, 10 of 10 such cycles recovered on their own. Request the IRQ and enable NAPI before the chip is initialized. Fixes: dd4544f05469 ("bgmac: driver for GBit MAC core on BCMA bus") Fixes: f3537b3494c0 ("net: ethernet: bgmac: driver power manangement") Cc: stable@vger.kernel.org Signed-off-by: Rosen Penev Reviewed-by: Daniel Machon Link: https://patch.msgid.link/20261010070011.60403-1-rosenp@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/bgmac.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c index 6ffdc42294074..258b3b5a1cdb7 100644 --- a/drivers/net/ethernet/broadcom/bgmac.c +++ b/drivers/net/ethernet/broadcom/bgmac.c @@ -1183,9 +1183,6 @@ static int bgmac_open(struct net_device *net_dev) if (err) return err; - /* Specs say about reclaiming rings here, but we do that in DMA init */ - bgmac_chip_init(bgmac); - err = request_irq(bgmac->irq, bgmac_interrupt, IRQF_SHARED, net_dev->name, net_dev); if (err < 0) { @@ -1195,6 +1192,9 @@ static int bgmac_open(struct net_device *net_dev) } napi_enable(&bgmac->napi); + /* Specs say about reclaiming rings here, but we do that in DMA init */ + bgmac_chip_init(bgmac); + phy_start(net_dev->phydev); netif_start_queue(net_dev); @@ -1609,10 +1609,10 @@ int bgmac_enet_resume(struct bgmac *bgmac) if (rc) return rc; - bgmac_chip_init(bgmac); - napi_enable(&bgmac->napi); + bgmac_chip_init(bgmac); + netif_tx_lock(bgmac->net_dev); netif_device_attach(bgmac->net_dev); netif_tx_unlock(bgmac->net_dev); -- 2.53.0