From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794591003; b=fu1TXQhYYKGZRNKGGkdgJy3oxItdh/JgWAWoOmFuC5RUvHvyVCssR2a8wKFpGaMEduXP WgMmcggDHktxpLfH4PlM2YUuca72ikyrlnLnKYyPLKMyEIpjXDhk2uH5UOKELWeLfOVF9 majbFF+Y++2k0s3JrUac9ITTE6z7Gt7mgu4TvdPZwxpDDxrD7WK++oA0fmY5NHfpuq7Id 8Mrn8aAPGUPV3b/B9fqjW6B+ExfijLUmLQjFZQmoEQW9d20BEeE0boQBGrbyIdDXSzty6 icu1iCZQLz964Gn2JCt3WDz6xj9pWp1Fe1D70V8JV4SYND1pjRsaZkBOQcDFHcYtuxA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794591003; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=/8qzwCOdTvvc2YQe8NhNxuzmBO408kcH5oCe1mGQutQ=; b=1K6XD98pTANQRAaQBEuRe6iYRQzF6PVN4VhJuo023Y/BptbkYVWWd93o8VFcac+PKDAz zfEIJifdXO03rPqHt9bCY4lR1lz3aYjxS0Wy/LvDSSp/cXeyBWyMdX89ThjjOjQa0hNoe PyhXLFZ/uqzICwmOdOVr9j0pCIkvEB9OMI4pjWm8nS/aRlupObErtQunYkc580eZoCxYc jcfG8ZvS4ChwA4wq+dXgN5T9AElNNIomoM4vt0B64CmHrqJnvOHM6QeUh1ZE2dIaug+RF VF3Vc14PNBCF/wKsYsfT2E6IjxWljrWzjN68EtEfQlyfAoh40fn0LqSAk4/mTe3ZujA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=gZn9feTX; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB5166070F08; Fri, 13 Nov 2026 17:30:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=gZn9feTX Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F5DD1F000C4; Fri, 13 Nov 2026 17:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794591003; bh=/8qzwCOdTvvc2YQe8NhNxuzmBO408kcH5oCe1mGQutQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=gZn9feTXTBpxk9KB1wTS4VxAzMnsMzcn4rXqMao9UKPn7sLdbddmd7WrzvfSn07ri 98ibEf+KSTkQEM7r0oWkFn/gkG826OdxbWtfr+hSIasZLL9g34mZSI4ipXyDfyYo7R FqTKjHzhrK0oQa1dBBrnU8fPwKWGsns19mrLgSzI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yizhou Zhao , Yuxiang Yang , Ao Wang , Xuewei Feng , Qi Li , Ke Xu , Michael Grzeschik , Dominique Martinet , Sasha Levin Subject: [PATCH 6.12 174/670] net/9p/usbg: Fix use-after-free in disable_usb9pfs() Date: Fri, 13 Nov 2026 10:45:38 -0500 Message-ID: <20261113153817.953034707@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261113153811.177190860@linuxfoundation.org> References: <20261113153811.177190860@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yizhou Zhao [ Upstream commit 6f401e350939442b2ac905f7e5ac952e3802a5d8 ] disable_usb9pfs() frees the IN and OUT usb_request objects before it disables the corresponding endpoints. If either request is still queued, the later usb_ep_disable() call cancels the endpoint queue and the UDC driver can still access the already freed request. With dummy_hcd and KASAN, this is reproducible by queueing the OUT request and then disconnecting the configfs gadget: BUG: KASAN: slab-use-after-free in dummy_disable+0x2b4/0x300 Read of size 8 at addr ffff888009702400 by task sh/1 usb_ep_disable+0x8e/0x1f0 usb9pfs_func_unbind+0x193/0x350 gadget_dev_desc_UDC_store+0x135/0x280 dummy_free_request() also warns because the request is freed while its queue entry is still linked. Disable both endpoints before freeing the request objects. This lets usb_ep_disable() cancel any queued transfers and invoke the completion callback while the request storage is still valid. The request objects are then freed only after they have been removed from the endpoint queues. Fixes: a3be076dc174 ("net/9p/usbg: Add new usb gadget function transport") Cc: stable@vger.kernel.org Reported-by: Yizhou Zhao Reported-by: Yuxiang Yang Reported-by: Ao Wang Reported-by: Xuewei Feng Reported-by: Qi Li Reported-by: Ke Xu Assisted-by: GLM:GLM-5.1 Signed-off-by: Yizhou Zhao Acked-by: Michael Grzeschik Message-ID: <20260607130118.16579-1-zhaoyz24@mails.tsinghua.edu.cn> Signed-off-by: Dominique Martinet Signed-off-by: Sasha Levin --- net/9p/trans_usbg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/9p/trans_usbg.c b/net/9p/trans_usbg.c index c682947dfb885..cd45d4a8597ad 100644 --- a/net/9p/trans_usbg.c +++ b/net/9p/trans_usbg.c @@ -277,6 +277,9 @@ static void disable_usb9pfs(struct f_usb9pfs *usb9pfs) struct usb_composite_dev *cdev = usb9pfs->function.config->cdev; + disable_ep(cdev, usb9pfs->in_ep); + disable_ep(cdev, usb9pfs->out_ep); + if (usb9pfs->in_req) { usb_ep_free_request(usb9pfs->in_ep, usb9pfs->in_req); usb9pfs->in_req = NULL; @@ -286,9 +289,6 @@ static void disable_usb9pfs(struct f_usb9pfs *usb9pfs) usb_ep_free_request(usb9pfs->out_ep, usb9pfs->out_req); usb9pfs->out_req = NULL; } - - disable_ep(cdev, usb9pfs->in_ep); - disable_ep(cdev, usb9pfs->out_ep); dev_dbg(&cdev->gadget->dev, "%s disabled\n", usb9pfs->function.name); } -- 2.53.0