From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794590557; b=C4/8nbYVSlNzeYyUUklHBafQvPiU56+rYtPBVEjeYgPXNvwL6c587EE9R+TRj6xLP4D7 +FN0hnTrKBwLH4rebLXmmUB40HiLhrBwzX2lHR8mMLguLbzrKuZ3kmEtx1r4A5j6AwdkA Ujo5/LOxy3jLkS1jJwXdHAJG9yqh9ugvnbf0l6erG/Mkz59iY2+5Htbku5b9V0ti/bIOc yIE9xU+W3j9b0FPlNOnVUr4N5XZNljXF/+3oaM/YVA/PqNttrZIuxm96p3RW/EB0iVpzl WpS8OcUy8oZ78Ypl6etnGOgLKb1P0Qv/5jeCWURm90fsq9CTehmlD+SpUZNSEvT3Hvg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794590557; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=OF5ltjXB/5yNtxL/C3g7DNYWKI43CwD98BIAHfCuvaQ=; b=DUaNGbsHlW1p9VAbnxKiRlSuppsv7RAs4C3C3EM4BH/C1EPZikSoPjEOcLuIM2XT/MO7 bGSM2UgXQ544oXUQCV/mqtc/BhrDBgBklq5StCGqC4iW94L5xepMEvyMZn3ICLgWAz+MP WkSqcPula0nHoI+ZJOAPkhOzEWF4HdE6f3ragnz7pbrJpQrDtcgt/V6yEDiwwinzahk3n CdWKvQy2CrFMoLhj9mERT1G3FZva0JDHjQ3etSCWooa/5wXyKf/KQtntinABGU109jkZ+ r5/x1llo78WwJWMFSiMVXix/nJqsdGOgTwMGPpLn/Zveh9SKCV5rMNcYPw/rcKIyjwQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=VC7wpJLY; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 586456084362; Fri, 13 Nov 2026 17:22:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=VC7wpJLY Received: by smtp.kernel.org (Postfix) with ESMTPSA id C58DD1F000C8; Fri, 13 Nov 2026 17:22:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794590557; bh=OF5ltjXB/5yNtxL/C3g7DNYWKI43CwD98BIAHfCuvaQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=VC7wpJLYbfjRfB9Av+2/4CcyhKCI4vXDA9ggVjnlsAGYxZ1IyOE45Jfdnpz82Dor/ t1unQvNZCw6tlTHU/ETCLZBkwBzOqiHxJykGwoIC0/8HxjhniL8grX/fiTaszsagLo n8cegHF5xVn06qqR/Dm/MD9neFnxhAPBXqyOaxq0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Joshua Crofts , Fabio Cesari , Jonathan Cameron , Sasha Levin Subject: [PATCH 6.18 493/686] iio: light: isl29028: fix runtime PM reference leak on error paths Date: Fri, 13 Nov 2026 10:50:26 -0500 Message-ID: <20261113153837.636544732@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261113153820.902362109@linuxfoundation.org> References: <20261113153820.902362109@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fabio Cesari [ Upstream commit 0e30d15b15647df786e60022650613e16dd70645 ] isl29028_read_raw() and isl29028_write_raw() take a runtime PM reference with pm_runtime_resume_and_get() but return directly on their error paths without dropping it. The usage count never balances again and the device stops entering autosuspend for good. In isl29028_read_raw() this needs a regmap access to fail; in isl29028_write_raw() one rejected sysfs write is enough, for example echo 200 > in_proximity_sampling_frequency which is outside the [1:100] range and returns -EINVAL with the reference still held. Take the reference with PM_RUNTIME_ACQUIRE_AUTOSUSPEND() instead, so it is released on every return path. This also stops the return value of pm_runtime_put_autosuspend() from reaching userspace. That value only says whether the device could be suspended right away, so -EAGAIN or -EPERM turns a successful access into a failure, and with CONFIG_PM=n the stub returns -ENOSYS on every access. Fixes: 2db5054ac28d ("staging: iio: isl29028: add runtime power management support") Suggested-by: Joshua Crofts Cc: stable@vger.kernel.org Assisted-by: LLM coccinelle Signed-off-by: Fabio Cesari Reviewed-by: Joshua Crofts Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/light/isl29028.c | 33 ++++++++------------------------- 1 file changed, 8 insertions(+), 25 deletions(-) diff --git a/drivers/iio/light/isl29028.c b/drivers/iio/light/isl29028.c index 7590efcf8dedb..408b32d096a86 100644 --- a/drivers/iio/light/isl29028.c +++ b/drivers/iio/light/isl29028.c @@ -342,8 +342,9 @@ static int isl29028_write_raw(struct iio_dev *indio_dev, struct device *dev = regmap_get_device(chip->regmap); int ret; - ret = pm_runtime_resume_and_get(dev); - if (ret < 0) + PM_RUNTIME_ACQUIRE_AUTOSUSPEND(dev, pm); + ret = PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) return ret; mutex_lock(&chip->lock); @@ -392,14 +393,7 @@ static int isl29028_write_raw(struct iio_dev *indio_dev, mutex_unlock(&chip->lock); - if (ret < 0) - return ret; - - ret = pm_runtime_put_autosuspend(dev); - if (ret < 0) - return ret; - - return 0; + return ret; } static int isl29028_read_raw(struct iio_dev *indio_dev, @@ -408,10 +402,11 @@ static int isl29028_read_raw(struct iio_dev *indio_dev, { struct isl29028_chip *chip = iio_priv(indio_dev); struct device *dev = regmap_get_device(chip->regmap); - int ret, pm_ret; + int ret; - ret = pm_runtime_resume_and_get(dev); - if (ret < 0) + PM_RUNTIME_ACQUIRE_AUTOSUSPEND(dev, pm); + ret = PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) return ret; mutex_lock(&chip->lock); @@ -461,18 +456,6 @@ static int isl29028_read_raw(struct iio_dev *indio_dev, mutex_unlock(&chip->lock); - if (ret < 0) - return ret; - - /** - * Preserve the ret variable if the call to - * pm_runtime_put_autosuspend() is successful so the reading - * (if applicable) is returned to user space. - */ - pm_ret = pm_runtime_put_autosuspend(dev); - if (pm_ret < 0) - return pm_ret; - return ret; } -- 2.53.0