From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795057677; b=hLKDmScgx8rzmFjEgAgGEEBngYKE8jqSU2HKuyPAqpVCoAVQ49MpnjC5hJa6h6xo9rkI pskFf6iNZLPnMYUlflMX9PaBtz9OjTJUyGzEiKmHAfbZNVPUBkVyxCQjiR+uUkJ0//k19 8TvA5Oq/fTMxUeePHNVsqub4yLAISspbgoMZRkvpQcmtOHaHozLBDMVr5e/8stnO1HtpL OSUITJ/Qnu++QfRKftGagYMSJrjdkyoy9G3wJJJ8lAB7WdFsie74B8MppW1Qub62MZsmC RlfN/Uwh431YhssiXNB+dASMo81KB+gsrnEI4284zF3VJ9piyAbLwlKnN1oKzJi9TRA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795057677; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=knalVSElEvenOO04EAFRu+FoKg/1vm5Htv3JdADWFSo=; b=Ku2rH4A+Q9atRHm6A7mu2kWQpJgAK0l1er5JfLxUClROhcZxn84LALpeekLfBKJS+Gts dRDKF7yX6ND6RZeD/HGvqHMJ/e0aHxjXfgTT6dKvdnJ6hFHvBpmytwQ3e3VY0oWYEA8c+ YqQSZaQxW9SID3Z3W4tIpgBQfQMuE8bNKJJiacpZFYVz3frW52NaoWp9Id+tdZ7zzWKg8 BqvrIM19skSvJfCJemvZJptcmoWlnLFahiUsf60BXmNdhidVu7oZi3wdje0BAgXtsVMlv d0A+U8tSEXmdkZyo5AbbYX0N++e0lnhaVrW3HEhrQpWzy1LbAdOyql1pSEJ1Z4PmdkQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=xr746e2w; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F8B760A2601; Thu, 19 Nov 2026 03:07:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=xr746e2w Received: by smtp.kernel.org (Postfix) with ESMTPSA id 750521F000C4; Thu, 19 Nov 2026 03:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795057677; bh=knalVSElEvenOO04EAFRu+FoKg/1vm5Htv3JdADWFSo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=xr746e2wNQNLmJru+z+LCAxi3j5iTFXGOv1IW+t+7rr/aGhJgfeMYId3EP3MQy/RK lAV1kKGjIXxyRXZsc2N0B9pg/lLETbgMKPMheRyJN1+/vDZNlhkmcsDAIUp7979ZRr 6Knz/TZDeVr3WYHs6xQJkuQvHS0kI4VYZzlCI03I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xiang Mei , Hans Verkuil Subject: [PATCH 5.10 0214/1848] media: go7007: only set audio_enabled if go7007_snd_init() succeeded Date: Wed, 18 Nov 2026 15:37:32 +0100 Message-ID: <20261118145920.995322625@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xiang Mei commit 2eacf058d2dbb0ae3aaf576459da9e5f2b6bbfbd upstream. go7007_register_encoder() sets go->audio_enabled before calling go7007_snd_init() and discards its return value. go7007_snd_init() assigns go->snd_context only on success, so a failed ALSA setup leaves audio_enabled set with snd_context still NULL. The disconnect path tests audio_enabled and calls go7007_snd_remove(), which dereferences snd_context unconditionally. go7007_snd_init() returns -ENODEV once its never-decremented static card counter reaches SNDRV_CARDS, so SNDRV_CARDS attach/detach cycles arm the next attach; no memory pressure is needed. Set go->audio_enabled only once go7007_snd_init() has succeeded. Oops: general protection fault, probably for non-canonical address ... KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] Workqueue: usb_hub_wq hub_event RIP: 0010:go7007_snd_remove (drivers/media/usb/go7007/snd-go7007.c:273) Call Trace: go7007_usb_disconnect (drivers/media/usb/go7007/go7007-usb.c:1336) usb_unbind_interface (drivers/usb/core/driver.c:461) device_remove (drivers/base/dd.c:618) device_release_driver_internal (drivers/base/dd.c:1349) bus_remove_device (drivers/base/bus.c:664) device_del (drivers/base/core.c:3965) usb_disable_device (drivers/usb/core/message.c:1478) usb_disconnect hub_event (drivers/usb/core/hub.c:5966) process_one_work (kernel/workqueue.c:3396) worker_thread (kernel/workqueue.c:3560) kthread (kernel/kthread.c:436) ret_from_fork (arch/x86/kernel/process.c:158) ret_from_fork_asm (arch/x86/entry/entry_64.S:245) Kernel panic - not syncing: Fatal exception Cc: stable@vger.kernel.org Fixes: 866b8695d67e ("Staging: add the go7007 video driver") Assisted-by: LLM Signed-off-by: Xiang Mei Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/go7007/go7007-driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/drivers/media/usb/go7007/go7007-driver.c +++ b/drivers/media/usb/go7007/go7007-driver.c @@ -306,10 +306,9 @@ int go7007_register_encoder(struct go700 if (ret < 0) return ret; - if (go->board_info->flags & GO7007_BOARD_HAS_AUDIO) { + if ((go->board_info->flags & GO7007_BOARD_HAS_AUDIO) && + go7007_snd_init(go) == 0) go->audio_enabled = 1; - go7007_snd_init(go); - } return 0; } EXPORT_SYMBOL(go7007_register_encoder);