From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795057883; b=JjjKQQ8jLYJr2zI0Ma/ljxbLl8/R6P9PvOUUwfu24LdrvNhI4i2NBRRudYmEWkRfUqwg hS8hZruPE7yFCcVg2fB7XgZCLRWnfMJG+FtIamoPYZIVlW4AfDDVTF4mnsh6oksopoIvK igYvOjdE6iMqywDIHsDnMquuxIQ9xPNCRIVuEGc7vkU2uPGPi7kqRwKoLAr4M4bVXrOkq N9NzeETFzZsLuONDC83f6pWOSjaJqeFu8v5nD1KqE4eybohJ6PT012GoDyf/Ngsst/VMN ACe/CjWg3Y32XrbLeMxmwPbt7HguDlB9rNrV+9zjZEvvh6x4mypouVycdcvGyOPIcew== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795057883; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=L6hSyPQbr+iiKM1yHQElDZJ5CKo8Gg1yVE5jVsNCJts=; b=O0gO3G9dPUtVIJ5/9D3g/d/PGflk52lnZ67HKlm2F18wElyoOYzitf1HxHTc6nEYtKCb 8JbIlkpt9caJ9Paq12zYl6yxC5u87NSuLq9DhesfY0Iaav/JvesDMTKiuKMlzVm5MbNoB Dh1kn25SWWJzUwQr3rDZuqs3Xo86KwrEiaup1zbTjKMg5ft/yqJXcRQHC52utqFxB3EyB wJexv59T61A6FS5qzg9B81/3nAgj3NYUaB12V5W83yulvV3YN+O35o1xggJ278G7yo2k5 UzkpIJl/ABB/jqqlPqqfRvOmxZIHquoVikeB0Csv/63lyoJKiFmm8z2W1NFiuqxfJng== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ND3OarmA; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAB83606A31C; Thu, 19 Nov 2026 03:11:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ND3OarmA Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C49A1F000C4; Thu, 19 Nov 2026 03:11:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795057883; bh=L6hSyPQbr+iiKM1yHQElDZJ5CKo8Gg1yVE5jVsNCJts=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ND3OarmAstrWSa6tgMZq2jT/0xcCxs5jjsm/uFDTubn3lEYDT22nuJCT7kwRsiRy5 ilLG9ypilmD7fdJcil7TGQXdVa9o+p3Y8mpR/mrjhDXSYh77Y1/7ZZZKW/Y2z5aJ30 CR+B+G4iNdCfiRO01L8tZhKeUoav3RcgLXTfoKo0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Aldo Ariel Panzardo , Jeff Layton , Chuck Lever Subject: [PATCH 5.10 0288/1848] NFSD: copy SETXATTR data from all XDR buffer segments Date: Wed, 18 Nov 2026 15:38:46 +0100 Message-ID: <20261118145924.188568846@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Aldo Ariel Panzardo commit b01319947c69b0e3ea0fcd4b675eb892f9cad8a0 upstream. nfsd4_vbuf_from_vector() manually copies the head followed by whole pages starting at offset zero. This assumes that all remaining data starts at the beginning of the page array and that no data is stored in the tail. However, nfsd4_decode_setxattr() passes an xdr_buf returned by xdr_stream_subsegment(). Such a sub-buffer can have a nonzero page_base and can span its page and tail segments. Ignoring that layout can copy the wrong bytes into the value passed to vfs_setxattr(). Use read_bytes_from_xdr_buf(), which observes the complete xdr_buf layout. Fixes: c1346a1216ab ("NFSD: Replace the internals of the READ_BUF() macro") Cc: stable@vger.kernel.org Signed-off-by: Aldo Ariel Panzardo Reviewed-by: Jeff Layton Link: https://patch.msgid.link/20260915160022.3105295-1-qwe.aldo@gmail.com Signed-off-by: Chuck Lever Signed-off-by: Greg Kroah-Hartman --- fs/nfsd/nfs4xdr.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c @@ -2117,10 +2117,8 @@ static __be32 nfsd4_vbuf_from_vector(struct nfsd4_compoundargs *argp, struct xdr_buf *xdr, char **bufp, u32 buflen) { - struct page **pages = xdr->pages; struct kvec *head = xdr->head; - char *tmp, *dp; - u32 len; + char *tmp; if (buflen <= head->iov_len) { /* @@ -2135,19 +2133,8 @@ nfsd4_vbuf_from_vector(struct nfsd4_comp if (tmp == NULL) return nfserr_jukebox; - dp = tmp; - memcpy(dp, head->iov_base, head->iov_len); - buflen -= head->iov_len; - dp += head->iov_len; - - while (buflen > 0) { - len = min_t(u32, buflen, PAGE_SIZE); - memcpy(dp, page_address(*pages), len); - - buflen -= len; - dp += len; - pages++; - } + if (read_bytes_from_xdr_buf(xdr, 0, tmp, buflen)) + return nfserr_bad_xdr; *bufp = tmp; return 0;