From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795058975; b=D6sIfkyLD5RYAfXSz4M5V0DANreXhTOfG94JlzqzLHY37DwFnHOPK72m5lLt640mm8un RTa1LuBlWiA+Dn1vLM6gE1FHHSvS0yiBTxzraC38JO9PCy+MJwG/WU5awZT2oRify6Ivs IsreqVYBwtf0r9oEdLonUR1r6+o9qG418cqV2N0kLZWKoB8IKyEeVcI+26SLnm2A4EPX/ hoTCS76iANG+Vv1/yJAwHHBMeAvJOebukXZGefQp4/sOzWBQGm2S1fYBv/nRiFyR/ZBY/ nSjElLFJnlllg6kKGgocvXPN03BZhNb27A8kvxqemnu3PEpo1Q4DW2DqQFJe1KHgBIQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795058975; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=68MN2Hxf/2muT9DEahFbnPDqj+SfUw1kj60nuGyyihg=; b=4J02g/vds71aixI4KtxVB+f4CjYlZpIchR3JD4iuFe4qwo56tR4QUu7SCZoU9IWhzAiy 2ELQsGRMjidkrcL7wwhjdtFBchJHZqtuPgZMDCfxVwk9H0NJuaox4id+hMAsB7hf8TEUX nXhD9jvDJuML6IHIo2Igl+8JeupHTGKsaDVlX8X+mVs35vWUKJWq8jUtsKSfrSYXgIkpp hZaPkqssKGRi3SPwgz2a2gP3L4hwG7eW+5+T3bnRBGkHR8TqoEpAaxOCNyA3Zkv8sIgY9 FdHai17AFLFr9+6nAKEhUZWgPU29K3Yk+BbszmvAZjJ7mKU/nRM8KVjJud1aKhrWA/Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=LKIfBMs+; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7328F606A332; Thu, 19 Nov 2026 03:29:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=LKIfBMs+ Received: by smtp.kernel.org (Postfix) with ESMTPSA id A72AC1F000C5; Thu, 19 Nov 2026 03:29:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795058975; bh=68MN2Hxf/2muT9DEahFbnPDqj+SfUw1kj60nuGyyihg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=LKIfBMs+c+5xWMqEj4k4j2P0DuSdrT7XVnvndYvn29+oVHLqzypmk2CHTRGWYnu4f XVdan8uklgOi6h3RnZQfDlA10guAkP2OWYZ8enncX9xdt32i5sIROpToyfvczkmz/F 32xt1id4YfiEhRX+RTTwazBino4uugb3wd8tsZc0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Andr=C3=A9=20Draszik?= , Philipp Stanner , =?UTF-8?q?Christian=20K=C3=B6nig?= , Sasha Levin Subject: [PATCH 5.10 0678/1848] drm/drm_crtc: ensure dma_fence_ops remain valid during device unbind Date: Wed, 18 Nov 2026 15:45:16 +0100 Message-ID: <20261118145944.274910315@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: André Draszik [ Upstream commit 3be436cbd3d265fe4fcfbb5b650edad7b2108443 ] In [1], sashiko reported the following issue: === snip === Looking at how these fences are managed, drm_crtc_create_fence() creates a dma_fence without taking a reference to the drm_device or drm_crtc. Because the sync_file framework exposes this fence to userspace, the fence can outlive the CRTC. The dma_fence contract requires that data accessed by dma_fence_ops (like get_driver_name) must remain valid for an RCU grace period after the fence is signaled. However, drm_crtc_cleanup() and the subsequent freeing of the device do not wait for an RCU grace period via synchronize_rcu(). If userspace calls ioctl(SYNC_IOC_FILE_INFO) concurrently with a device hot-unplug: CPU1 (Userspace) sync_file_get_name() ops = rcu_dereference(fence->ops); if (!dma_fence_test_signaled_flag()) // Preempted or delayed here CPU2 (Driver Teardown) Signals the fence (setting fence->ops = NULL) Destroys and frees the CRTC without waiting for an RCU grace period CPU1 (Resumes) ops->get_driver_name(fence) -> drm_crtc_fence_get_driver_name() crtc = fence_to_crtc(fence); // Casts to the freed CRTC return crtc->dev->driver->name; // Use-after-free ... Does the CRTC or DRM device need to be kept alive for the RCU grace period, or should the fence hold a proper reference to prevent the use-after-free when get_driver_name() and get_timeline_name() access the freed CRTC structure? === snap === I believe this to be a correct observation and this patch implements the suggestion of waiting for an RCU grace period before proceeding with destruction of the drm_crtc, so that get_driver_name() and get_timeline_name() can still work. Link: https://sashiko.dev/#/patchset/20260618-linux-drm_crtc_fix2-v1-1-c03e77b36f34@linaro.org?part=1 Fixes: 6d6003c4b613 ("drm/fence: add fence timeline to drm_crtc") Cc: stable@vger.kernel.org Signed-off-by: André Draszik Reviewed-by: Philipp Stanner Reviewed-by: Christian König Link: https://lore.kernel.org/r/20260721-linux-drm_crtc_fix2-v3-1-afa8c71506e6@linaro.org Signed-off-by: Christian König Signed-off-by: Sasha Levin --- drivers/gpu/drm/drm_crtc.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 5d2cbff02df12..e833a52e33693 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -336,14 +336,23 @@ EXPORT_SYMBOL(drm_crtc_init_with_planes); * drm_crtc_cleanup - Clean up the core crtc usage * @crtc: CRTC to cleanup * - * This function cleans up @crtc and removes it from the DRM mode setting - * core. Note that the function does *not* free the crtc structure itself, - * this is the responsibility of the caller. + * This function cleans up @crtc and removes it from the DRM mode setting core, + * after first waiting an RCU grace period to ensure @crtc->dev can safely be + * dereferenced by our dma_fence_ops. + * + * Note that the function does *not* free the crtc structure itself, this is the + * responsibility of the caller. */ void drm_crtc_cleanup(struct drm_crtc *crtc) { struct drm_device *dev = crtc->dev; + /* Ensure our dma_fence_ops remain valid for an RCU grace period after + * the fence is signaled. This is necessary because our dma_fence_ops + * dereference crtc->dev. + */ + synchronize_rcu(); + /* Note that the crtc_list is considered to be static; should we * remove the drm_crtc at runtime we would have to decrement all * the indices on the drm_crtc after us in the crtc_list. -- 2.53.0