From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795059497; b=tRjTS4OjgNTE5kSYU7oreMi45dHrSyELtTTZTFOqODFnI8hlqoYZcJBGZD3xvtqUkG/i 8vD6ndO90+76fThJwokloFN7UR5kpXBlI5uqQw0KG6RLp75EJqHvT8FecsSO1p+L8c7CX Zqtz0sT2QVQW0qWZHKVL8qVsIITo6UQKd9cr0gv7yBcFFAPP8QFXJ6pfaKGVkM/YPcXvQ 5cvKEVs6/6BBqaHsyXukeeMP5oK5a3z26oQaNutgC1K6TjrjL6/7DUdWkwe1e+I+D4iBi idj25irBunsLvBdSMZuIn8+woAhASFFrf3+mM01S6MavBCd4uEdcTMDlPnjmOApCIHw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795059497; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=zWIG+tUlhQNQI/qwKnq+W+2XdmP904WmFTPvrbLPFHY=; b=EV9TH4jguXsiTcMp3oUn3b6+8WStmZXeSnobwwHjgVJrDnnPfwncKTuWoVlK6D15Zb5J M0N4gZX5X1Szdrb7im8YOj4rwpv2B1wEg0wiqt9oILxcCxJcZc7WpJ+JuenYk74kp96L4 kFHTpQ4AYN3QFsjrbgmiJuoHLabTTz84kpclAElzOSzNIHEcvx8PguSb0GbMZ5gvVtwvI 0WA4KmkzMXy2SCsOcQvUveGass569QvoyieBHh3pQ0JtlnHmW30/zrLdRlXgvBrASVcUS KREqcjPDdQn1OarRTls95u+LMmTuLajwbabOVkskPHz7naMRIn9nNHfgHEld6g+uH6w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=2ZLkWxPS; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C44A606A320; Thu, 19 Nov 2026 03:38:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=2ZLkWxPS Received: by smtp.kernel.org (Postfix) with ESMTPSA id C60671F000C4; Thu, 19 Nov 2026 03:38:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795059497; bh=zWIG+tUlhQNQI/qwKnq+W+2XdmP904WmFTPvrbLPFHY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=2ZLkWxPSjtthH/FPGSkIT2qmKmzut1qPUsscJ53tqeJ+7SRAt3Bg006U5HAT1cTmi 6/RaxxQEyya/a6NJ+8KPX7jKI7uy660k0zpeCdT4Pt4vyY5cwyznUkeBAL4CNFzrdI m5PGlYOFwjxMBYhDWiT5fqDyX9sZy5NLdTwnRWyQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yunpeng Tian , Gongming Wang , Mingda Zhang , Qinrun Dai , Jan Kara , Sasha Levin Subject: [PATCH 5.10 0863/1848] udf: validate the device specification EA before using it Date: Wed, 18 Nov 2026 15:48:21 +0100 Message-ID: <20261118145952.619884036@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yunpeng Tian [ Upstream commit 9a2390959685ac35a58c80c8016120849a2babf6 ] udf_get_extendedattr() bounds an extended attribute only against struct genericFormat, which is 12 bytes. A type-12 device specification is struct deviceSpec, which is 24 bytes plus a flexible impUse array. Thus a corrupted filesystem can contain extended attribute that is accepted by udf_get_extendedattr() but udf_write_inode() or udf_read_inode() may access beyond the end of provided buffer. Provide a udf_device_spec_valid() check to validate correctness of extended attribute that is a deviceSpec. While here, check the result of udf_add_extendedattr() before dereferencing it as it can return NULL in case of error. [JK: Removed duplicated validity checks] Reported-by: Yunpeng Tian Reported-by: Gongming Wang Reported-by: Mingda Zhang Reported-by: Qinrun Dai Cc: stable@vger.kernel.org Signed-off-by: Yunpeng Tian Signed-off-by: Jan Kara [ sashal: adapted write-side changes to udf_update_inode() instead of udf_write_inode() ] Signed-off-by: Sasha Levin --- fs/udf/inode.c | 42 +++++++++++++++++++++++++++++++++++++----- 1 file changed, 37 insertions(+), 5 deletions(-) diff --git a/fs/udf/inode.c b/fs/udf/inode.c index 849fb64fdb8e5..f7ecee0a333fc 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -1284,6 +1284,26 @@ int udf_setsize(struct inode *inode, loff_t newsize) return 0; } +/* + * Verify validity of struct deviceSpec on disk. udf_get_extendedattr() has + * already verified the generic header and made sure attribute fits in the + * inode so we just have to make sure attribute space is large enough for + * deviceSpec struct and required impUse information. + */ +static bool udf_device_spec_valid(struct deviceSpec *dsea) +{ + u32 attr_length, imp_use_length; + + attr_length = le32_to_cpu(dsea->attrLength); + imp_use_length = le32_to_cpu(dsea->impUseLength); + if (attr_length < sizeof(struct deviceSpec) || + imp_use_length < sizeof(struct regid) || + imp_use_length > attr_length - sizeof(struct deviceSpec)) + return false; + + return true; +} + /* * Maximum length of linked list formed by ICB hierarchy. The chosen number is * arbitrary - just that we hopefully don't limit any real use of rewritten @@ -1598,13 +1618,12 @@ static int udf_read_inode(struct inode *inode, bool hidden_inode) if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode)) { struct deviceSpec *dsea = (struct deviceSpec *)udf_get_extendedattr(inode, 12, 1); - if (dsea) { - init_special_inode(inode, inode->i_mode, + + if (!dsea || !udf_device_spec_valid(dsea)) + goto out; + init_special_inode(inode, inode->i_mode, MKDEV(le32_to_cpu(dsea->majorDeviceIdent), le32_to_cpu(dsea->minorDeviceIdent))); - /* Developer ID ??? */ - } else - goto out; } ret = 0; out: @@ -1752,6 +1771,10 @@ static int udf_update_inode(struct inode *inode, int do_sync) udf_add_extendedattr(inode, sizeof(struct deviceSpec) + sizeof(struct regid), 12, 0x3); + if (!dsea) { + err = -ENOSPC; + goto out_unlock; + } dsea->attrType = cpu_to_le32(12); dsea->attrSubtype = 1; dsea->attrLength = cpu_to_le32( @@ -1759,6 +1782,10 @@ static int udf_update_inode(struct inode *inode, int do_sync) sizeof(struct regid)); dsea->impUseLength = cpu_to_le32(sizeof(struct regid)); } + if (!udf_device_spec_valid(dsea)) { + err = -EFSCORRUPTED; + goto out_unlock; + } eid = (struct regid *)dsea->impUse; memset(eid, 0, sizeof(*eid)); strcpy(eid->ident, UDF_ID_DEVELOPER); @@ -1898,6 +1925,11 @@ static int udf_update_inode(struct inode *inode, int do_sync) brelse(bh); return err; + +out_unlock: + unlock_buffer(bh); + brelse(bh); + return err; } struct inode *__udf_iget(struct super_block *sb, struct kernel_lb_addr *ino, -- 2.53.0