From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795059716; b=bo38CaMbcbSb5Iyi22/qBbuJ5Ea44BRpA2drsTpYKo8olDhOYYQ3w5xQtI+Ap+FwHOlV 9SQwhF82QulbeafVqbd9AyRxc57Vkx5koD0WlL2OwA95zU2c/jJf8HPlJAjKQHENyguKK W7C5i9IZOt+nHIKfNZX8MTjL35hfQVoRQYuPiUJC5rjIzF16PQjRTg8X5ytjXJDdct4Ms chVdv2mEkpmkCE6Y6ql8lJ69SMzWQsIDtoQsVBRsXUf+QCJChhNlxAmwggelE4VjVtriM vYZkbNBt5YriD3GsLZR0ho1qZVOAndTxrz1VqskcuLsrvumw8HgC/xyOkY8rdp796Uw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795059716; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=QAcbxhLRb1a4BzJ1iU0oqqk3n164YD4l6esFDLwPewc=; b=xVKSEg3Ixjw2QZuzrGnmVhEsgWz9edTw7mV+qhMkeIBI0EF+DDLrDjn8wvTbA/0G3CRl 062MeNiPge+0uwcREiD8tm6yYiCnyfa8OzM0tdzsYOb9tyOGT+dgnSMXMkwHQbu1THM3C WDsrOCOTWPuAJ9IXxByYzU6h8QC2czcl2sE2b3m2437exA3kq+ouJcF99ay4bNSFjLhc+ Dt44l9GbCGl2DXIUISz588qaQX47rJQMQQNOipsICzW0CbW7Gn2NCoTU1dbRTZ28e7MIz DcJMD3ImHEM3Xlb2S4vzB+iICqbHj4s2E/7XUgcPE3l/pN1gD9k3W3Ffu/3uoqAV/aQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ADA96HS5; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B17F8606A320; Thu, 19 Nov 2026 03:41:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ADA96HS5 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E0E81F000C4; Thu, 19 Nov 2026 03:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795059716; bh=QAcbxhLRb1a4BzJ1iU0oqqk3n164YD4l6esFDLwPewc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ADA96HS5+mBRi+mP7rurAnV0dwdJB/bWhDw3FJ7yUsZIDBQvR9jcFJJEjKE0cc91M oeKEfjkdkkw2BO79oIELUUj88XkgfJk/wPigCGVwyYGk7tIEOBZ//q1co5JQuBd92j Dn0RaaKpa0Sf11v/YwuWlyZr+uKGYxNZEWTu4sAE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Lee Jones , Hongyan Xu , Sasha Levin Subject: [PATCH 5.10 0942/1848] mfd: da903x: Cancel IRQ work during teardown Date: Wed, 18 Nov 2026 15:49:40 +0100 Message-ID: <20261118145956.425859753@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118145911.150052362@linuxfoundation.org> References: <20261118145911.150052362@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hongyan Xu [ Upstream commit fd2258999ecdc7164ef0cda2d4102e4558a5660f ] The IRQ handler disables the IRQ and schedules irq_work. Releasing the IRQ does not drain that work, which can continue to use the devm-allocated chip and notifier state. Manage both IRQ-work cancellation and subdevice removal with devres. Register the subdevice-removal action before requesting the IRQ, then add the IRQ-work action after the request. This avoids leaving a live IRQ without work cancellation if action registration fails. Devres cleanup then disables the IRQ and drains the work before releasing the IRQ and removing child devices. Register both actions before creating the children so partial probe failures use the same ordering. This issue was found by the author's in-house static analysis tool. The patch was reviewed by the author against the latest mainline tree. Fixes: 26b8f5e1e2d1 ("mfd: add base support for Dialog DA9030/DA9034 PMICs") Cc: stable@vger.kernel.org Suggested-by: Lee Jones Assisted-by: Codex:GPT-5 Signed-off-by: Hongyan Xu Link: https://patch.msgid.link/20260814153019.1114-1-getshell@seu.edu.cn Signed-off-by: Lee Jones [ sashal: adapted da903x_remove() deletion to its int return type by also removing the return 0 statement ] Signed-off-by: Sasha Levin --- drivers/mfd/da903x.c | 35 +++++++++++++++++++++++++---------- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c index a818fbb559888..3ff1a00b409c3 100644 --- a/drivers/mfd/da903x.c +++ b/drivers/mfd/da903x.c @@ -421,6 +421,14 @@ static irqreturn_t da903x_irq_handler(int irq, void *data) return IRQ_HANDLED; } +static void da903x_cancel_irq_work(void *data) +{ + struct da903x_chip *chip = data; + + disable_irq(chip->client->irq); + cancel_work_sync(&chip->irq_work); +} + static const struct da903x_chip_ops da903x_ops[] = { [0] = { .init_chip = da9030_init_chip, @@ -456,6 +464,13 @@ static int da903x_remove_subdevs(struct da903x_chip *chip) return device_for_each_child(chip->dev, NULL, __remove_subdev); } +static void da903x_remove_subdevs_action(void *data) +{ + struct da903x_chip *chip = data; + + da903x_remove_subdevs(chip); +} + static int da903x_add_subdevs(struct da903x_chip *chip, struct da903x_platform_data *pdata) { @@ -484,7 +499,6 @@ static int da903x_add_subdevs(struct da903x_chip *chip, return 0; failed: - da903x_remove_subdevs(chip); return ret; } @@ -520,6 +534,11 @@ static int da903x_probe(struct i2c_client *client, chip->ops->mask_events(chip, chip->events_mask); chip->ops->read_events(chip, &tmp); + ret = devm_add_action_or_reset(&client->dev, + da903x_remove_subdevs_action, chip); + if (ret) + return ret; + ret = devm_request_irq(&client->dev, client->irq, da903x_irq_handler, IRQF_TRIGGER_FALLING, "da903x", chip); @@ -529,15 +548,12 @@ static int da903x_probe(struct i2c_client *client, return ret; } - return da903x_add_subdevs(chip, pdata); -} - -static int da903x_remove(struct i2c_client *client) -{ - struct da903x_chip *chip = i2c_get_clientdata(client); + ret = devm_add_action_or_reset(&client->dev, da903x_cancel_irq_work, + chip); + if (ret) + return ret; - da903x_remove_subdevs(chip); - return 0; + return da903x_add_subdevs(chip, pdata); } static struct i2c_driver da903x_driver = { @@ -545,7 +561,6 @@ static struct i2c_driver da903x_driver = { .name = "da903x", }, .probe = da903x_probe, - .remove = da903x_remove, .id_table = da903x_id_table, }; -- 2.53.0