From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795028572; b=bJWEQaKMntIf6XwGAUlvXL1DswIle6KGKE7oS8k384bvtIObHZL5w4fJyprAEQXQnPus vLsH2mVStIiXaCtNOTfeXmwdTqVjC+CRNBo6plOYcoHuKVb4anYZyGVD/e4iIirOVfY9j RJYC5bmny5ERPtHMEWlHgC2pPjD81IMaapxteHwfqHVl+XmFrq3HqKVxa/vz15a88DnEU kjzIxuNc5RSWQ97o0g96u1alckcDvWoz7r6qM5fJOS7aSQ9+P+xzEdrVgT+sNnxu7bClp zTF7stJ8FDOAq2BHMOWTs1HwGJ5sO1yA+tia4bjYNc2wJJPZSsVvePhLdAlsp1QGrvA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795028572; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=879SzlcN/0HY0evkiIpvvWkgpXrXXMkoLg5Tr8S1NJ8=; b=uI7r/zKh91QJAGxlVM7kHO38izKHjB9BR59A04dgEqKiQ05UGEnSvgGkVCnqKSU9fPBQ yoRJVv71w3t794aJ6ZmedAfyI/RtFeUr9CzOtP8yp3dpXU2v3832hUz6LtlKr+uK+QD7O r0QurEcE15KLJr2z8llVdbxPtobh2B6C07uEkpyas4UYAWXlHwZuGg6BX5MDRwmkel4xh 4Xd6rhSc4waJ9FCNDs+8AqkRngZQ/lim6HOrRT/gyMhOV4YfbfpmpBj24i62oH6+cVWPJ teTGqhOUkuLVWp7Zy/WL43ZEBUz5ZbixRhq+NPHhDb0W2BnuK3LGGRw74ypFJwND/Bg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=hi4fILrX; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 973A0606A320; Wed, 18 Nov 2026 19:02:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=hi4fILrX Received: by smtp.kernel.org (Postfix) with ESMTPSA id E34B91F000C4; Wed, 18 Nov 2026 19:02:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795028572; bh=879SzlcN/0HY0evkiIpvvWkgpXrXXMkoLg5Tr8S1NJ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=hi4fILrXPB2dASQBqJsDVir/oKJJOn4D2/G01WAtZDyNVGldmDPk2vPtIgIYCzeaP ZlF16Uo9AN/5FEiP2lClxkpLkvipT5AxCsvUc8WDQPthUW80KkfbKU9duDVFuUNGKi 45EuYMfuIAGvIC5FUad1j6FokULVkS63WpCfrFqk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bo Cao , Takashi Iwai , Sasha Levin Subject: [PATCH 6.12 0043/1756] ALSA: pcm: Prevent O_APPEND open on OSS streams Date: Wed, 18 Nov 2026 15:36:10 +0100 Message-ID: <20261118150009.735993738@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150007.957976754@linuxfoundation.org> References: <20261118150007.957976754@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Takashi Iwai [ Upstream commit 9017bc3d13da0ea4e63be618c87143a7b69185e6 ] ALSA PCM core accepts to re-use the existing stream when O_APPEND is passed, and it's been used for dmix, etc. However, this mode isn't supposed to be used for OSS: the OSS stream allows re-configuration via its hw_params/hw_refine procedure even while it's being mmapped, so it implies the usage of only a single stream. Because of this assumption, the sanity check is skipped for OSS streams, and if user may attach to an existing OSS stream with O_APPEND, it may result in a UAF of the mapped pages which could be used as a privilege escalation exploit. For addressing it, this patch simply prohibits the O_APPEND behavior on the OSS stream. O_APPEND is never used for OSS layer itself, so this can't break for the right applications. Fixes: 0df63e44c3e3 ("[ALSA] Add O_APPEND flag support to PCM") Cc: stable@vger.kernel.org Reported-by: Bo Cao Link: https://lore.kernel.org/tencent_E90BB4F086165FAA3313723567A5C675EA06@qq.com Link: https://patch.msgid.link/20261103155844.120838-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/core/pcm.c | 2 ++ sound/core/pcm_local.h | 6 ++++++ sound/core/pcm_native.c | 6 ------ 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/sound/core/pcm.c b/sound/core/pcm.c index ff1e9f8c1ecae..18979f88f7159 100644 --- a/sound/core/pcm.c +++ b/sound/core/pcm.c @@ -923,6 +923,8 @@ int snd_pcm_attach_substream(struct snd_pcm *pcm, int stream, return -ENODEV; if (! SUBSTREAM_BUSY(substream)) return -EBADFD; + if (is_oss_stream(substream)) + return -EINVAL; substream->ref_count++; *rsubstream = substream; return 0; diff --git a/sound/core/pcm_local.h b/sound/core/pcm_local.h index ecb21697ae3a4..4b134d435c24f 100644 --- a/sound/core/pcm_local.h +++ b/sound/core/pcm_local.h @@ -80,4 +80,10 @@ static inline void snd_pcm_dma_buffer_sync(struct snd_pcm_substream *substream, snd_dma_buffer_sync(snd_pcm_get_dma_buf(substream), mode); } +#if IS_ENABLED(CONFIG_SND_PCM_OSS) +#define is_oss_stream(substream) ((substream)->oss.oss) +#else +#define is_oss_stream(substream) false +#endif + #endif /* __SOUND_CORE_PCM_LOCAL_H */ diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index f3b17ec2f1778..24b923aabc9a2 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -745,12 +745,6 @@ int snd_pcm_runtime_buffer_set_silence(struct snd_pcm_runtime *runtime) } EXPORT_SYMBOL_GPL(snd_pcm_runtime_buffer_set_silence); -#if IS_ENABLED(CONFIG_SND_PCM_OSS) -#define is_oss_stream(substream) ((substream)->oss.oss) -#else -#define is_oss_stream(substream) false -#endif - static void pcm_qos_req_clear(struct snd_pcm_substream *substream) { if (cpu_latency_qos_request_active(&substream->latency_pm_qos_req)) -- 2.53.0