From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795029587; b=L9QQn3BBSeWZSSO1wIIbVSbmkPJaJbTVqGdEhGw+9H3c2nzWSjsztSO8fK+YSjxCmr0+ t6if7eE/zta+OgOU9a45sazniSm2o6vNlWNy5ZNPT65q7LRwqojS9vRwG4/0fv0jDzcqj j5Q4CA6zJfoDJunm+DDP6WINnGKcPQE0QZ6wMlGix9ZgRxuqtqwXD+LV6HZ8Ty7ztl39i +aY5jpoSI9MMe06MJqgGKw+opHEyp0/OhY2FX4ORr2xhUadlMyeHC1V+V8i8c5DMNpW4b q4TyIqtxxLFvfmI5MrnBv4mfF2YUsNVMxpQw9YE3nYt6w8JqJ6Di9mXs+hA5ORwr+vQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795029587; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=xAwtyB1S8wNEc5tKZjqvlJrdX9ojzuTHzK48sAju4E4=; b=Q38rtJTeR6rPhITBltUcPWq9Nn1vuNW7afn06CI1WBl5WrEjH7kLeIyFNxdmVS0tXqOH heq+B2tEVPz0YOKde73Rd8JcVaPXtPWbDX1IXv13/17t4KzVk6/VjQZedv5VSl3/CIa/s vDtv7dX2a4BgDEaC3OE95ZSQ89VclcpsJ7tspih2rTmjjiZPdKDGtCzNIGxrl+S/Q5uGR bpkSpb4G+tPK/Vwe8s405wSDQsybVoOmNuRK4FI2EJ5nE90jsA2/PJ8Ed1cPb8eZNascS BXPnjnkn1ZWfYR7BkkVVrzJD+zulWRSAhuq4CLhPJ8cT+iVdJTVg52xIv3WXynXjzeQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=w6SwG116; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1CA9606A32C; Wed, 18 Nov 2026 19:19:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=w6SwG116 Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFA111F000C4; Wed, 18 Nov 2026 19:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795029587; bh=xAwtyB1S8wNEc5tKZjqvlJrdX9ojzuTHzK48sAju4E4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=w6SwG116xbP6Qd/ASeehajNnwc4Dhwa7fezkezvMs+/ewZMjUuu1l+W3Vq7g83KJn hYxerjtjsG6H4h38ijQCMi0yMc2Zr33G1aIP/3MhmSBpUDzfDp/xNmtM3k0P0K/xWW JU4moENkfNwdhT5B/Ytt6vaNF8yyZU7TgmYPsKyU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chaithanya Lagisetty , Sean Christopherson , Sasha Levin Subject: [PATCH 6.12 0376/1756] x86/svm: Avoid sign extension of SVM_EVTINJ_VALID in 64-bit expressions Date: Wed, 18 Nov 2026 15:41:43 +0100 Message-ID: <20261118150023.436934355@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150007.957976754@linuxfoundation.org> References: <20261118150007.957976754@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chaithanya Lagisetty [ Upstream commit c5991239b148d40d4981901968b3a6a838ff517b ] SVM_EVTINJ_VALID is defined as (1 << 31), i.e. as an int with the sign bit set. Whenever it is used in a 64-bit expression the int is sign extended, so bits 63:32 end up set as well. Two 64-bit users are affected. verify_exception_info() uses the macro as a mask against a 64-bit value when it sanity checks hypervisor supplied exception information: u64 info = ghcb->save.sw_exit_info_2; ... if ((info & SVM_EVTINJ_VALID) && The mask is 0xffffffff80000000, so the check also passes when any bit of the error code in 63:32 is set while the valid bit itself is clear. svm_vmgexit_inject_exception() builds the value that KVM hands to an SEV-ES guest in GHCB SW_EXITINFO2: u64 data = SVM_EVTINJ_VALID | SVM_EVTINJ_TYPE_EXEPT | vector; For vector == X86_TRAP_GP this yields 0xffffffff8000030d instead of 0x000000008000030d. The field uses the EVENTINJ format, which holds the error code in bits 63:32, so KVM asks the guest to inject #GP with an error code of 0xffffffff. Linux guests only consume the error code when SVM_EVTINJ_VALID_ERR is set, which it is not here, so they are not affected in practice, but the value KVM writes is not the one it intends. Use BIT() instead, as is already done for most single bit definitions in this header. Every other user applies the macro to a u32, where the resulting bits are unchanged. Opportunistically give SVM_EVTINJ_VALID_ERR the same treatment, there's zero reason to open code BIT(). Fixes: 597cfe48212a ("x86/boot/compressed/64: Setup a GHCB-based VC Exception handler") Fixes: c3392d0ab714 ("KVM: SVM: Provide helpers to set the error code") Signed-off-by: Chaithanya Lagisetty Link: https://patch.msgid.link/20260908053722.3917934-1-nagachaithanya9911@gmail.com [sean: use BIT() for SVM_EVTINJ_VALID_ERR as well] Signed-off-by: Sean Christopherson Signed-off-by: Sasha Levin --- arch/x86/include/asm/svm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/svm.h b/arch/x86/include/asm/svm.h index 2b59b9951c90e..aeec3f0f25589 100644 --- a/arch/x86/include/asm/svm.h +++ b/arch/x86/include/asm/svm.h @@ -616,8 +616,8 @@ static inline void __unused_size_checks(void) #define SVM_EVTINJ_TYPE_EXEPT (3 << SVM_EVTINJ_TYPE_SHIFT) #define SVM_EVTINJ_TYPE_SOFT (4 << SVM_EVTINJ_TYPE_SHIFT) -#define SVM_EVTINJ_VALID (1 << 31) -#define SVM_EVTINJ_VALID_ERR (1 << 11) +#define SVM_EVTINJ_VALID BIT(31) +#define SVM_EVTINJ_VALID_ERR BIT(11) #define SVM_EXITINTINFO_VEC_MASK SVM_EVTINJ_VEC_MASK #define SVM_EXITINTINFO_TYPE_MASK SVM_EVTINJ_TYPE_MASK -- 2.53.0