From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795029669; b=WDi9Ha7gC8+mYnFtmRF7ZXaUCrTl4r9dWLdjb2sogFlwpwRxvy6MpdL5V263gDCN9ZpM EDhNETGdJp8DNZNTT7hl8m83JIrQ+d1ymeGTUhtqdDPAiHBxaTmOfw8sLiMXCefqZtF4i g0Je6V4hGY8zZMbPfzcIYjX4VuBIP5eOHxmUvMAceJ2nAiWPJKrcv02GECCYRS7QfhEMs FE0tvTwTebjZpZJpbrOTI7W7prTPXJZsbBEJY3zQhIDlPNGjQmEl/JGCvrk1JTffdtTXk WF1htWWaQJsAufn9qIgd80QuSi0EpDD6MXQxzgX6mqYP9SoeYYg+ugq8pl/0cy7uVeg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795029669; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=GM+rZ7ThwLppK3N69G1UN1H3AzFHT3F1uMYLyXjpfVo=; b=yfiq/4SHvYK8SDP4GwDX+ncB/zHBtB1G1nrvMnS8YOxpXhnRFdI8bvkMHT7E+TpLAl9T GKynNFlfHGllflbp9Qryk+2mc+EU0AO0afX9554cb+sfKMrNdcykwr+/+wTYfYM9T3I4C Vmn+HqIPX+xPqhFhZIWX220PDsQyMWzc+vDW9T2hdUzw+4moYEHazYwFTSsVQRLI/idW+ 2dd/EoMSF46mwV54mAdXnUBEaclXMQFgBiXYgcOuHjzjK6LpCH4z3abp9IX4lJk5KNGQD RxWPun8KNCD7VXQWvHFf2V7/7VSK0BOpi9RtfGFuuabfMyoO8DI/GUHq+h0aY+73veQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=L0uvfOv0; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 105E6606A32C; Wed, 18 Nov 2026 19:21:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=L0uvfOv0 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65F751F000C4; Wed, 18 Nov 2026 19:21:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795029668; bh=GM+rZ7ThwLppK3N69G1UN1H3AzFHT3F1uMYLyXjpfVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=L0uvfOv0yG0P64OfiaMOYKLM8JQChWqRtiw4+SugXKXTmmDDGda2xZ5zl5kdRdqNt 0GxqENARcfJ+hdtAgoHbJ2tfZqGOvYmiovN1g6EStL9WAwRnHgguH+RzfuVIJCQ09J o7FSYCIq46MzPpn4xVg0+DtkfKR9bRcrIVLqOnl4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Abdelnasser Hussein , Joshua Crofts , Jonathan Cameron , Sasha Levin Subject: [PATCH 6.12 0433/1756] staging: iio: adc: ad7816: Fix DMA safety issues in SPI transfers Date: Wed, 18 Nov 2026 15:42:40 +0100 Message-ID: <20261118150025.991260346@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150007.957976754@linuxfoundation.org> References: <20261118150007.957976754@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Abdelnasser Hussein [ Upstream commit 69fa76f0af3414cc189c3b0b807cb59e327ecc00 ] The SPI operations in this driver are not DMA safe: 1. spi_read() uses a stack-allocated buffer. 2. spi_write() in ad7816_spi_read() uses a struct member that shares a cacheline with other variables. 3. spi_write() in ad7816_spi_write() passes a stack parameter by reference. Fix these violations by replacing all spi_read() and spi_write() calls with spi_write_then_read(). This safely handles DMA by internally allocating a bounce buffer for the transfers, avoiding cacheline sharing issues without needing dedicated aligned buffers. This implicitly corrects the size argument in read to sizeof(buf). Fixes: 7924425db04a ("staging: iio: adc: new driver for AD7816 devices") Signed-off-by: Abdelnasser Hussein Reviewed-by: Joshua Crofts Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/staging/iio/adc/ad7816.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7816.c index 081b17f498638..a46ca0559b6a2 100644 --- a/drivers/staging/iio/adc/ad7816.c +++ b/drivers/staging/iio/adc/ad7816.c @@ -69,7 +69,7 @@ static int ad7816_spi_read(struct ad7816_chip_info *chip, u16 *data) gpiod_set_value(chip->rdwr_pin, 1); gpiod_set_value(chip->rdwr_pin, 0); - ret = spi_write(spi_dev, &chip->channel_id, sizeof(chip->channel_id)); + ret = spi_write_then_read(spi_dev, &chip->channel_id, sizeof(chip->channel_id), NULL, 0); if (ret < 0) { dev_err(&spi_dev->dev, "SPI channel setting error\n"); return ret; @@ -91,7 +91,7 @@ static int ad7816_spi_read(struct ad7816_chip_info *chip, u16 *data) gpiod_set_value(chip->rdwr_pin, 0); gpiod_set_value(chip->rdwr_pin, 1); - ret = spi_read(spi_dev, &buf, sizeof(*data)); + ret = spi_write_then_read(spi_dev, NULL, 0, &buf, sizeof(buf)); if (ret < 0) { dev_err(&spi_dev->dev, "SPI data read error\n"); return ret; @@ -109,7 +109,7 @@ static int ad7816_spi_write(struct ad7816_chip_info *chip, u8 data) gpiod_set_value(chip->rdwr_pin, 1); gpiod_set_value(chip->rdwr_pin, 0); - ret = spi_write(spi_dev, &data, sizeof(data)); + ret = spi_write_then_read(spi_dev, &data, sizeof(data), NULL, 0); if (ret < 0) dev_err(&spi_dev->dev, "SPI oti data write error\n"); -- 2.53.0