From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795052121; b=qtr36YfxA/hK3k5+hq41rAQT7SfDy6em9kd1VpDVXhwe63i6tTGrlRy6F7n1qSS8i1QZ 8wOReUCfjJCOGiYac3uZSb7nzwIscu6CAAiLXUIC5mIQe/1dWm3c1+vZMHC/Jg0RXBjsI GXyOxhlmZPhGLHU+AM/WGTcdvz4HGLxoFDjSzAwHmmdYksoWFnshU5oOaN41+TOz7V6p+ WxhIPjQ7FpKn2yJzBYlOuY0AitNvuap5FCzGqVMPavkZzg4X94sqtOaO5HUkzQRKu9qbH l/nuONUUs8pUxHfFbk6TdvtTSQJzl9/f6nZNSY9oxlSRWAS1qe6OX/r7gkbP3r6cfYQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795052121; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=gl4gcGfqwcz0RLPdeYcRuag+yQ07Aqs2ZWzSjkGr6qU=; b=cXg5kuxrpXLRK6TNRPSziLyjwxELimivuzn76TwENTGS2u9hSu+3QINcq4vdHqbWQJje 1SC6dDnlotei6gP7D3EAJOUBszCeHwP8JR2PPxitwQVy3Wx+gncYjnRSTsMomfwdTkjjN z60a8p6nK/jt54ohHnH95RyOJUDwNmzr2veLZ+zsmDsbj6Qhp7rBMvuZGOj6ConpsyZKC CcQfipzW0/OORXiSgn8FpJPcO1X9e39HAMjBxQKKO2JiGUVfiRpfNLKozNszv6rD+LiCh BoG2CEEcc7fNmtVcEVaHg4pBuc7cxtXOSHhFAnbrUTgoi5J5MVmEoZzBvzrx0SsXOfg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=2Qa8aPqv; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1949A606A320; Thu, 19 Nov 2026 01:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=2Qa8aPqv Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7042E1F000C5; Thu, 19 Nov 2026 01:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795052121; bh=gl4gcGfqwcz0RLPdeYcRuag+yQ07Aqs2ZWzSjkGr6qU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=2Qa8aPqvTPSkyiGb1fdaGVVSo7juWQZLXFAhPEkWIT63kqHv2pvxNveaqSggGTYbR TGBeQjaKgRnHcRHl6wmIoJHCAzW01n+GOGDD2Qe51JTGehDX6Qb4tq1M1Th+nILv/L Hl7TOQpNwa0hCTNgiNGhs4v7YRuGl12c6r6mjvpU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?=E3=82=A4=E3=83=A0=E3=83=86=E3=82=A3=E3=83=A4=E3=82=BA?= , Ping-Ke Shih , Sasha Levin Subject: [PATCH 5.15 0450/2214] wifi: rtw88: fix out-of-bounds CAM write when key table is full Date: Wed, 18 Nov 2026 15:35:26 +0100 Message-ID: <20261118150029.066905710@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: イムティヤズ [ Upstream commit 10d58823cb44681466c022054030b8e68d94ce2f ] In rtw_ops_set_key(), when the CAM table is full, rtw_sec_get_free_cam() returns RTW_MAX_SEC_CAM_NUM (32) because find_next_zero_bit()/find_first_zero_bit() return the bitmap size when no free slot exists. The bounds check compares the returned index with ">" against total_cam_num (32), so the invalid index 32 passes the check. rtw_sec_write_cam() then indexes cam_table[32], an array declared with RTW_MAX_SEC_CAM_NUM (32) entries, causing an out-of-bounds write that corrupts the cam_map allocation bitmap. The write also sets bit 32 of cam_map, which overruns the bitmap as well. Fix the off-by-one by rejecting indices >= total_cam_num. Tested on: RTL8821CE (PCIe) on kernel 7.2.0-rc6-rtw88test-00059-g0d8395707651. The patched module loaded and associated to a WPA2 network; ping traffic passed with 0% packet loss. Reassociation and disconnect/reconnect cycles completed without errors, and the CAM table (debugfs dump_cam) showed valid key entries. The CAM-full boundary (28+ pairwise keys) requires an access point with 28+ clients and is not reachable in a single-client setup, so that path was verified by code inspection. Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver") Cc: stable@vger.kernel.org Tested-by: イムティヤズ Signed-off-by: イムティヤズ Acked-by: Ping-Ke Shih Signed-off-by: Ping-Ke Shih Link: https://patch.msgid.link/20260805210941.75136-1-reza1234khan1234@gmail.com Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtw88/mac80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c index 942bb2ab8b50f..29244e58161a8 100644 --- a/drivers/net/wireless/realtek/rtw88/mac80211.c +++ b/drivers/net/wireless/realtek/rtw88/mac80211.c @@ -512,7 +512,7 @@ static int rtw_ops_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, hw_key_idx = key->keyidx; } - if (hw_key_idx > sec->total_cam_num) { + if (hw_key_idx >= sec->total_cam_num) { ret = -ENOSPC; goto out; } -- 2.53.0