From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795029878; b=xxK9OR4ArWLevoneyquPGqAAQICsrxu4sBmvFcresxblPPzo8IOHryovXr/GD4tjD9OM wNCLw4geHCf5ZUkOJdV6q2Kk6xtu3Epo8EYVmnJSd4ZLM0zARZgxHOeZTzvNO4yPjrZjq feEsbMPtxmduisxhBDLKhbdPRcfAS9T1rfWO9hIbRf+2jOxI6gMzZ5wWVyks3drQ+Z2cO CcpC60pA/S7EQeEf8GbQdF5EhE+x/X/nEio5VxPpxhwsi92HwdorDZqqIncM7UFM6obZl va4xSRHj6CQ9+H0FkkuAGlEhmQlz8QZTI6CTNY+AeqhiWgWF1ccc+8LnrqejH0frpvA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795029878; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=KsCKxMIO14DHml5cIk5Dk5jcUqgTVrYCgVBjstXurqc=; b=zS9PWOBzbJql2zw5kiIOzS+YyrENKZhC26CJmjuRgn7esvAytMP8b4rHO4CAx/9RKCh5 xvsAX8p8FkYQ8+5Z3nkM6KVNFbgzUMLLJYQIJ6+h7WyXMoshuNZyp6EMWndZymyHkWiS+ nUxFhTT3UKCCSoNxK5KnjZkjamZD/irHY6w9qiKGm/Nl8bAoUC6Akonrx7JLE4p9zh2hz NVvpvUyEcQ512GlodsDaL0WdnPJjHfEsT+1Gacq6bLcJ5f0IcFw+cuiJG9lCSceXfwOLj gEXvFzQDUSUG4yFRdRMRfPDQZQX+o+SOvfMA/3YFO/poaOwT+DdfVcesYBHd8IKC25Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=a5GqMhtm; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06028606A31C; Wed, 18 Nov 2026 19:24:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=a5GqMhtm Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B6E91F000C4; Wed, 18 Nov 2026 19:24:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795029877; bh=KsCKxMIO14DHml5cIk5Dk5jcUqgTVrYCgVBjstXurqc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=a5GqMhtmRP7i1KBZiNf/Y8TKvezk1AXm+9VMQVGeC2G7KjL1rCJ7NsRNgO/Os1oi5 xYZQOybJgB8Jk5LVx25Cx73+ib4vbNJM/v32GHOMwEf6p2xJIp55JacQQdcXEJOroz mb1/jWdJYzjQ79AcX1RZxeZzFzrafSJMxUDrYog8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ping-Ke Shih , Kim Wooseok <5mghybrid@khu.ac.kr>, Sasha Levin Subject: [PATCH 6.12 0505/1756] wifi: rtl8xxxu: free RX skb when URB submission fails Date: Wed, 18 Nov 2026 15:43:52 +0100 Message-ID: <20261118150029.188472867@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150007.957976754@linuxfoundation.org> References: <20261118150007.957976754@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kim Wooseok <5mghybrid@khu.ac.kr> [ Upstream commit 9f7edf4e8584c87e3c478c6dd87c08d51b5157c2 ] When usb_submit_urb() fails, rtl8xxxu_submit_rx_urb() unanchors the URB but leaves the newly allocated skb in urb.context. For ENOMEM/EAGAIN, the RX worker puts the request back on the pending list. The next submission allocates another skb and overwrites that pointer, leaking the previous buffer. Stopping before the retry also leaks it, because pending-list cleanup frees only the URB. Free the skb and clear urb.context in rtl8xxxu_submit_rx_urb() when submission fails. This keeps buffer allocation and failure cleanup in the same function, so a request returned for retry or teardown no longer owns an skb. Remove the corresponding cleanup from start and the RX worker; they only need to decide whether to retry or free the URB. Fixes: 26f1fad29ad9 ("New driver: rtl8xxxu (mac80211)") Reviewed-by: Ping-Ke Shih Assisted-by: GPT-6 Astra Signed-off-by: Kim Wooseok <5mghybrid@khu.ac.kr> Signed-off-by: Ping-Ke Shih Link: https://patch.msgid.link/20260921-codex-rtl-rx-v3-submit-v4-1-eeb09fe8f791@khu.ac.kr Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtl8xxxu/core.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/core.c b/drivers/net/wireless/realtek/rtl8xxxu/core.c index 97c5443496163..cce0aae3d103d 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/core.c @@ -5890,7 +5890,6 @@ static void rtl8xxxu_rx_urb_work(struct work_struct *work) struct rtl8xxxu_priv *priv; struct rtl8xxxu_rx_urb *rx_urb, *tmp; struct list_head local; - struct sk_buff *skb; unsigned long flags; int ret; @@ -5922,8 +5921,6 @@ static void rtl8xxxu_rx_urb_work(struct work_struct *work) default: dev_warn(&priv->udev->dev, "failed to requeue urb with error %i\n", ret); - skb = (struct sk_buff *)rx_urb->urb.context; - dev_kfree_skb(skb); usb_free_urb(&rx_urb->urb); } } @@ -6618,8 +6615,11 @@ static int rtl8xxxu_submit_rx_urb(struct rtl8xxxu_priv *priv, skb_size, rtl8xxxu_rx_complete, skb); usb_anchor_urb(&rx_urb->urb, &priv->rx_anchor); ret = usb_submit_urb(&rx_urb->urb, GFP_ATOMIC); - if (ret) + if (ret) { usb_unanchor_urb(&rx_urb->urb); + dev_kfree_skb(skb); + rx_urb->urb.context = NULL; + } return ret; } @@ -7431,7 +7431,6 @@ static int rtl8xxxu_start(struct ieee80211_hw *hw) struct rtl8xxxu_priv *priv = hw->priv; struct rtl8xxxu_rx_urb *rx_urb; struct rtl8xxxu_tx_urb *tx_urb; - struct sk_buff *skb; unsigned long flags; int ret, i; @@ -7482,13 +7481,8 @@ static int rtl8xxxu_start(struct ieee80211_hw *hw) rx_urb->hw = hw; ret = rtl8xxxu_submit_rx_urb(priv, rx_urb); - if (ret) { - if (ret != -ENOMEM) { - skb = (struct sk_buff *)rx_urb->urb.context; - dev_kfree_skb(skb); - } + if (ret) rtl8xxxu_queue_rx_urb(priv, rx_urb); - } } schedule_delayed_work(&priv->ra_watchdog, 2 * HZ); -- 2.53.0