From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795030124; b=PCJHP39SK4Ludzh0wPqhBO4yoYWhFMx9olIXKVRonw0LFSOlR9oFKuP+TJ/Ng7ty/UID HhJG9YglnA6MCVyASkiEQtDXSdY95uJt73e7sWZS+8eIbCKs3CYFZhZowucCiHHA+MxaF K9eugwa8FsPRguObpc8c/stCv/L2O9Npxe+l3vm/CX4eip0K7FIDh69ZTSCYtStF11Prf PHtDwuR6BMT4zUIdmIWrKGxVEgKVk3F9UNQ330CayeQhmoTP8W6OWaw4gNuIpIiuwlxl3 YQAkLNr0Supg/KpNbmdIqRaoRzCLBaLcPD8KhayL7q3QaJtHbKiS6GZe+KEUfSqFjYA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795030124; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=c19qTNW0HxxkrjNxgj0JcEIO9bYnSUlgi7cr85i1+XQ=; b=mvrJaKqoK1ci+dsW5QuL1vx46SGYtqxGFJxSnAg/JNGb9k03syajP1RC6YDOpLyR2/Kg 8AwE2c7ZL/4dY9DXkJxeHkJiqZPPXGceyN/LcTFnq/9U0WvVsnAl4sjVznH8WQ/5q55S4 upQ0daeZvlYnHyMrtfw5mWN1qXIlqIOO7QGyMTm2xIu+Tbx59/z3khZ3JhgVS8pDCKUyG +Boponk6th7Rczpfa/kO1GfNlSkigQSMCzi9ic8CoYp0fQ8kIFTlQKIvHvVcbsZRUfo/r WTm9PpfVMo5SDof8oFTJ/hIBux1rPvWMU2anZrLp3225H+f9aUDC56l0akkbRSkia3g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Enb2Cp0c; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17964606B100; Wed, 18 Nov 2026 19:28:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Enb2Cp0c Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30F211F000CE; Wed, 18 Nov 2026 19:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795030123; bh=c19qTNW0HxxkrjNxgj0JcEIO9bYnSUlgi7cr85i1+XQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Enb2Cp0ccODBW2nx+xXtKtuJBjlzbRobaomUPA9eEgkyzx8xclt7UqCS5H0VcKofI WydJ+K9+7Oe6XPQtL/RWm3gcenifucpnYIh9uOmgNEsdEeHJWh0/T2h7GH4DjsVn60 qle1MNYfNnELlWxfJRUXRnn8X2+bRW3a9PUxivew= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sudeep Holla , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 6.12 0592/1756] ACPICA: Fix PCC OperationRegion command offsets Date: Wed, 18 Nov 2026 15:45:19 +0100 Message-ID: <20261118150032.565537226@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150007.957976754@linuxfoundation.org> References: <20261118150007.957976754@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sudeep Holla [ Upstream commit 888dab4b04ea8725168c6d50d0bfb8057fccca18 ] ACPI 6.3, section 5.5.2.4.7.3, states that the PCC Operation Region is associated with the region of shared memory that follows the PCC signature. The generic and extended PCC shared memory layouts include the 4-byte signature at offset 0, so their raw shared memory COMMAND fields are at offsets 4 and 12 respectively. Since AML field offsets for the PCC OperationRegion are relative to the region after that signature, ACPICA must look for those COMMAND fields at OperationRegion offsets 0 and 8. Adjust the generic and master subspace command checks to use those OperationRegion-relative offsets. Otherwise writes to the COMMAND field can fail to invoke the PCC address space handler at the offset described by the PCC OperationRegion definition. Link: https://github.com/open-acpica/acpica/pull/1205 Fixes: aa6ec56b574d ("ACPICA: ACPI 6.3: add PCC operation region support for AML interpreter") Signed-off-by: Sudeep Holla [ rjw: Fixed the Fixes: tag ] Link: https://patch.msgid.link/20260922144302.3847593-2-sudeep.holla@kernel.org Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/acpica/exfield.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/acpi/acpica/exfield.c b/drivers/acpi/acpica/exfield.c index 61ff36189acea..eb44d06134b6e 100644 --- a/drivers/acpi/acpica/exfield.c +++ b/drivers/acpi/acpica/exfield.c @@ -45,12 +45,13 @@ static const u8 acpi_protocol_lengths[] = { /* * The following macros determine a given offset is a COMD field. - * According to the specification, generic subspaces (types 0-2) contains a - * 2-byte COMD field at offset 4 and master subspaces (type 3) contains a 4-byte - * COMD field starting at offset 12. + * According to the specification, the PCC OperationRegion begins after + * the PCC signature. The raw shared memory COMD offsets of 4 for generic + * subspaces (types 0-2) and 12 for master subspaces (type 3) therefore + * appear at OperationRegion offsets 0 and 8. */ -#define GENERIC_SUBSPACE_COMMAND(a) (4 == a || a == 5) -#define MASTER_SUBSPACE_COMMAND(a) (12 <= a && a <= 15) +#define GENERIC_SUBSPACE_COMMAND(a) (0 == a || a == 1) +#define MASTER_SUBSPACE_COMMAND(a) (8 <= a && a <= 11) /******************************************************************************* * -- 2.53.0