From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795030180; b=ZoCDefdjLES76lc5ypPzCXv4dWNWZWnSo/NCYTCkFVd2MQ2isoyiqc+vApbU8ng8Khda hlVhpxrHwa2VMp6y0FEv9jWTxB5W2WP5hj/L3b/4xNaAD3fX4JN97/SO4w5O172fjxUUp A6TkfsgxvKYBUfpJ2mKAYSiEfPEQSdEqG6rGE9xPNr29uIIWAhiUACKjrVeqfgUymsLA1 Gz++haGCfGmUaqPtcej+Ji9ccwv7sOVOMaMleNBQ77bmdMlrE8oa0Aqu0v6zfaWHdD4w3 BKx+Bt9s+H5W2T1Mnx64SeoQHfWB/cz0uiiDt4V+JHabUWZ4Z/9qRsIWB7rFSXhmMdg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795030180; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=3bjZqZ1tfgFzJJ+dcuvEUg5XMlXji6swSh3RWSV6a0w=; b=0bpeTxeijA/6AWTdd6GL+iOqKy5MqjdfAKOlmXcJgNE7H18TJeqYu5knqeHaZiEl+IEa gQ9Yi5ui46+04PatdQbXGovX2ulv6Ht+KPlm2xB0jf6YXgtyfmuxSyIcqfSvUC/f7Gmg4 XOdfRJR58KX/5cr2Edg5sQSSgEmZMLMxImBW8kpQsFEiAiGvM1l6uVhAsJglr0hsmx7n/ pDWZaLU9WcXmhCCNjl93mNEdKLtQTeKsATUNkcr6BrIu/GKx8dsjdIzWOnngX6qcSBnHB XPlqpTCiZqLJCEhe81b07bmu0c8muEJzHWzi3Q5HOaQgYTwb6iOUbIAbFfVFVriPyBQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=JYEJtz9t; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F313E606D341; Wed, 18 Nov 2026 19:29:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=JYEJtz9t Received: by smtp.kernel.org (Postfix) with ESMTPSA id 329CC1F000C7; Wed, 18 Nov 2026 19:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795030179; bh=3bjZqZ1tfgFzJJ+dcuvEUg5XMlXji6swSh3RWSV6a0w=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=JYEJtz9ttXg3JFfbCH2yIwfn69u5apyzNFnTs8Io9gsuuSFu83J7KBW+H+1EuI6DK sj9T34GAfF7DTwn5Z27oqgNIoUAIeO0rQkYkL575pvbxGO5FgTVohl0a9hqnuf+R2u jOnkk8u2vk/KsObevM3kA/si77UcQgXUYDOj8qBU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Shashank Mohan Jain , Yury Norov , Sasha Levin Subject: [PATCH 6.12 0614/1756] bitmap: bitmap_parselist(): dont wrap around on a huge group size Date: Wed, 18 Nov 2026 15:45:41 +0100 Message-ID: <20261118150033.375414330@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150007.957976754@linuxfoundation.org> References: <20261118150007.957976754@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shashank Mohan Jain [ Upstream commit d075c4dc0b3c8ed91a4f67ebdf3384aa59fd4fbb ] In the "range:used/group" form bitmap_set_region() walks the range with for (start = r->start; start <= r->end; start += r->group_len) where all values are unsigned int. bitmap_getnum() accepts any group size up to UINT_MAX, and bitmap_check_region() only requires it to be non-zero and at least the used size. If start + group_len exceeds UINT_MAX, start wraps around to a small value that is still <= end, and bits below the start of the range get set: "1-1:1/4294967295" -> bits 0,1 (expected bit 1) "15-15:1/4294967281" -> bits 0,15 (expected bit 15) The loop still terminates, because start keeps decreasing until it wraps past zero again, but the resulting mask contains bits outside the requested range. This needs a group size within 'start' of UINT_MAX, so it is unlikely to be hit by accident; all bits set stay below the end of the range, so there is no out-of-bounds write. A group larger than the range simply means that the range contains a single group, so stop the walk when the next group would start beyond UINT_MAX. Fixes: 0a5ce0831d04 ("lib/bitmap.c: make bitmap_parselist() thread-safe and much faster") Assisted-by: LLM Signed-off-by: Shashank Mohan Jain Signed-off-by: Yury Norov Signed-off-by: Sasha Levin --- lib/bitmap-str.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/bitmap-str.c b/lib/bitmap-str.c index 65cd6f60d4360..777c89bc772cd 100644 --- a/lib/bitmap-str.c +++ b/lib/bitmap-str.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include "kstrtox.h" @@ -219,10 +220,12 @@ struct region { static void bitmap_set_region(const struct region *r, unsigned long *bitmap) { - unsigned int start; + unsigned int start = r->start; - for (start = r->start; start <= r->end; start += r->group_len) + do { bitmap_set(bitmap, start, min(r->end - start + 1, r->off)); + } while (!check_add_overflow(start, r->group_len, &start) && + start <= r->end); } static int bitmap_check_region(const struct region *r) -- 2.53.0