From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795030546; b=CZM73UhlnczvSmu38pqbkgwvPObwE9B7eUQtajhFEObWFOMU9q9dHXi1E7LQ8CcuVOkq OZHptN3R3+FRdj0E5lMKK1aM6fiEFZfoqM5kjE3pCvRqR2nBlD22O2tIyCdm9kPfVzHOd MCSzUQ/vnjQZ4aqV075UStNOKZsdkvBMOdkU6i9bGmkIpG3VT3M8SfdiCpdI+FoBGrdB/ Tf8RRKM8/5zL0kpAmNZtrUPoZplfxQ1NVhiMx00pBtbqANtpOs2U7SN/btxdk9/1oMcTK F5RPhvPmQR89vjgiA1zesATqG2vBkzPIsTGfcsEH+dL7BLVPg1C2QXfC0masazgrEmQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795030546; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=XgalkNGc1ufIbGC11rG/ncCZEP4PcWCfoahOklFzq7A=; b=CrIzCUwDbJzhuuMweXODv1NqKy2DueheZGS8YDNMG60vCJZKK/drUvvnZ7hfibddI0Il mE9vZXVaPcbWLfF8Uv+9TGKJgeTFem+o1zjO7gmVooY3uFB5bXhe5D5NyiSFZ3J4s2y1I 5f2Ha9cI+WKKbB8nFa3p4dsWvpjw7NfB8eyViqajv2stmaQ4mSXXLk1SFOnyk8j2pKndV CJeqerBF+4BKEvih2172Da8CQhhAUgTl3I/sFWOTsRRx49vKEPueQZpDZbDbfFKYW9YZt sC/ubw0SZ1iOXHFHyZHFBqGkUCTXuXR0QdycOYODmrMokiE7+ShG4KIN4WGZ8shzofg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=p+GP+nng; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53E05606A32C; Wed, 18 Nov 2026 19:35:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=p+GP+nng Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7BBE1F000C4; Wed, 18 Nov 2026 19:35:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795030546; bh=XgalkNGc1ufIbGC11rG/ncCZEP4PcWCfoahOklFzq7A=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=p+GP+nngSzD41hRc31gi665U7w+x8T0iRB4FAHM6KtMUI1w8qJJfwB00A1h4DiDmH RbsF6sY0L49jnpqZc/P03cM0SdsbpWMbxbkZ8j4dCdX/MWNDfZBOeFoURy9Uwu0U5J A4/2jiyjPLs4bLB9WBPX3ldURyegJkabc9rKarbE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Weigang He , Liviu Dudau , Sudeep Holla , Sasha Levin Subject: [PATCH 6.12 0733/1756] ARM: vexpress: fix device_node refcount leak in vexpress_smp_dt_prepare_cpus() Date: Wed, 18 Nov 2026 15:47:40 +0100 Message-ID: <20261118150038.834131586@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150007.957976754@linuxfoundation.org> References: <20261118150007.957976754@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Weigang He [ Upstream commit 27b98d331f1dcebe088ab51a7061a387a7440cb2 ] vexpress_smp_dt_prepare_cpus() obtains a reference to the SCU device node via of_find_matching_node() and passes it to of_iomap(), but never calls of_node_put() on it. of_iomap() does not take ownership of the node, so the reference is leaked. The function is the .smp_prepare_cpus hook invoked once from the __init SMP bring-up path, so this is a one-shot leak of a single refcount during boot, with no functional impact. Annotate scu with the __free(device_node) cleanup attribute so the reference is released when the function returns. Found while reviewing a CodeQL report for vexpress_flags_set() on the same SMP bring-up path. Fixes: d2606f81d563 ("ARM: vexpress: Simplify SMP operations for DT-powered system") Assisted-by: LLM codeql Signed-off-by: Weigang He Reviewed-by: Liviu Dudau Link: https://patch.msgid.link/20260925173252.933705-3-geoffreyhe2@gmail.com Signed-off-by: Sudeep Holla Signed-off-by: Sasha Levin --- arch/arm/mach-versatile/platsmp-vexpress.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-versatile/platsmp-vexpress.c b/arch/arm/mach-versatile/platsmp-vexpress.c index 1ee3c45e71c99..b810ad50b98ce 100644 --- a/arch/arm/mach-versatile/platsmp-vexpress.c +++ b/arch/arm/mach-versatile/platsmp-vexpress.c @@ -61,8 +61,8 @@ static const struct of_device_id vexpress_smp_dt_scu_match[] __initconst = { static void __init vexpress_smp_dt_prepare_cpus(unsigned int max_cpus) { - struct device_node *scu = of_find_matching_node(NULL, - vexpress_smp_dt_scu_match); + struct device_node *scu __free(device_node) = + of_find_matching_node(NULL, vexpress_smp_dt_scu_match); if (scu) scu_enable(of_iomap(scu, 0)); -- 2.53.0