From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795052990; b=K/Hh39IpkCEHhAGf3KX4ebN+iL3iAAyLJ+iWdcizNlouQYHRkwx59oz31YJ5aZoBOIdw C52F7jc3wOpHJM/rvFjXlxxIMW2IaPYHSj5V7mySzJYlCs1afK3VHxCJkhyMxFAcxGnd1 g+Cr9P1iMFtqFbHwJY7PJwNINhmXwMQvu5FUwD1Wz4D5nG6xEmZ4kO8xtvr9niFKth02r rLq9moKYt4X/67kfiYwYbHww1b+GjIwgLVrmBVIbNZ6313sA+c/x/t2bRcHAazJBbDAEZ 4FZ0zTWGQ4K42NXnjZjgXiDXFg952LpUirPOdqZAnERMD3eCIyfBaalAyNM2rg4xPwA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795052990; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=4os59201lS81IzrBHyNdiGs8rZv2c9KJKFBHXNFddsU=; b=WFDqkoSp7Pfl5BqUyZ/NsZY38yBwJv9AhAIogiKZpDzSV5sGvcCF+7/lb3JYQQ3xHLZd ePg7nMpwyZ6HNoMftjxQbGIzdFXsHRLdkv1xnnhjowW+pMhkom2B4q6ZqqwhGZC9X7x4Q fIGwpdoldgkMTIme9+Uw+Vuu4cnDqSdNF4zqUW+JgwlGpD5x6OEb0CJRL73i5QAnQZVls CCYgUgPAxAgq0N1ZRD43pm9+8xNDN7DsBdB9L/aPcROjY9DHjP47wbVb69qURMqkIyc3C 3Px61SAyabaVDwC/0NsMj1axTAsHK49m89Wue+bG0f4uK947M0fChIKBCL7yi4qBruA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Wb9erpbD; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95A64606A320; Thu, 19 Nov 2026 01:49:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Wb9erpbD Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBDF11F000C7; Thu, 19 Nov 2026 01:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795052990; bh=4os59201lS81IzrBHyNdiGs8rZv2c9KJKFBHXNFddsU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Wb9erpbDMK2nhBVvAp3QJb8fC9ZenpMpAeq6T9T3twbwlfI3eCFh12Y58XaIm+kwf 7VGQhJ5MKRj7xVwLLxne4NbQBANjla2pHZwmKP1gwMsLax7c3yrkguKpPP6TCdZ3tz Ql6o8bqsMXML2B7rCKEx5Gb5t+rgNOMPyAV9oUFI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bryam Vargas , Keith Busch , Andrew Stellman , Sasha Levin Subject: [PATCH 5.15 0760/2214] nvmet-rdma: fix out-of-bounds write in nvmet_rdma_map_sgl_inline() Date: Wed, 18 Nov 2026 15:40:36 +0100 Message-ID: <20261118150042.132848588@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrew Stellman [ Upstream commit d1512773a0d539669440bd9f6d050b8e12923b5f ] nvmet_rdma_map_sgl_inline() bounds the host-supplied in-capsule SGL offset with "off + len > inline_data_size", evaluated in 64-bit arithmetic. off is taken straight from the host SGL descriptor (le64_to_cpu(sgl->addr)) and len is promoted to 64-bit, so the sum wraps: an off within len of 2^64 makes it small and the check passes. off is then used as page_idx = off / PAGE_SIZE to index the fixed-size rsp->cmd->inline_sg[] array (NVMET_RDMA_MAX_INLINE_SGE entries), so a crafted offset yields an out-of-bounds scatterlist index that is written through in nvmet_rdma_use_inline_sg(). The mapping runs while handling a received capsule, before the command executes, so a remote RDMA peer can reach it (the Connect capsule is a write and takes this path on a queue that has no controller yet). The host controls only the low bits of the resulting displacement, so the expected impact is an out-of-bounds write that faults the target (remote denial of service). This wrap was reported, with a KASAN reproduction, on linux-nvme in May, and the check below was suggested in that thread. The fix that was applied, 48c0162f647b, reworked how the offset is mapped but kept the original check, and its page index turns a wrapped offset into an out-of-bounds index into inline_sg[]. Reject the offset before it can wrap. Found independently by static analysis with AI assistance, not reproduced at runtime. Fixes: 0d5ee2b2ab4f ("nvmet-rdma: support max(16KB, PAGE_SIZE) inline data") Fixes: 48c0162f647b ("nvmet-rdma: handle inline data with a nonzero offset") Reported-by: Bryam Vargas Closes: https://lore.kernel.org/all/LM21QIR-1-qJb7PViyJKCnGBnUzizeiNJVWQ3wb7ZwGezodjgKg3f-iobqOyequ-sT1jFCKJImfqNO_BKU3KO80xFITnaI5GTV_GxLUNDDc=@proton.me/ Suggested-by: Keith Busch Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-5 Signed-off-by: Andrew Stellman Signed-off-by: Keith Busch Signed-off-by: Sasha Levin --- drivers/nvme/target/rdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c index b57d79f05acab..4be96ca0ef5de 100644 --- a/drivers/nvme/target/rdma.c +++ b/drivers/nvme/target/rdma.c @@ -864,7 +864,8 @@ static u16 nvmet_rdma_map_sgl_inline(struct nvmet_rdma_rsp *rsp) return NVME_SC_INVALID_FIELD | NVME_STATUS_DNR; } - if (off + len > rsp->queue->dev->inline_data_size) { + if (off > (u64)rsp->queue->dev->inline_data_size || + len > (u64)rsp->queue->dev->inline_data_size - off) { pr_err("invalid inline data offset!\n"); return NVME_SC_SGL_INVALID_OFFSET | NVME_STATUS_DNR; } -- 2.53.0