From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795031039; b=SaQdZ43ilBep4GXX+MGDrOQseZoSPtFV4nprKZ0cmk40smPCn0cuSNjBMsGKiwoYwNoF SLZ/jfmXD3aLoZeKODTRccSdfnE8vajV4DlI9snrYSuhYDnQQ7wA/wFmiVptzF/fircCw f174fn1d499NwUXNBnI1vfvV/d1zDx5zOBWOBRPR4zrkCdZZ+ocipSEqlTmN7t8kM200b Mqq2n42z8GCM8r3N7zi14U4utNAVqOBfk9I7oCCoyit1FxzJg2fXRf3SAZ5rDq6uYIPS5 37qe8IhoQ5eDyThcmwyQ/gm42HOMjwBA0uOKB2kdgZw41nTzxKqZzV7uMczQXZ1w87g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795031039; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=0fq6LYSX2zuPoRtPVsCZq003qSO3WG/AsycW7TRFubc=; b=JRFkilvuaTSiduBhg52IXU09CaCx3ZZAxPyqBEQMt/aMpiJ2wHmQVAtJN22X6ycSeIlx iBPNOCVqAp5s1g6jxb1M4IwltLaGzQGR9pemDGBt9ov4d/CSJRXk8fccy2C7038/vRAsz fENNY7t76RaqQf8YzKKWlC1ZjYZgM/4wZ7bVV388x1/HZ3Vk6afq+IYFhefEn936afhE9 rW/NNYqj58FdHMF/m8gAw5BxcLgrssnBWFLpS9rf09rRoCxXEXkkW33hScyOoazbPp/g+ JHuha763OgvI5TiBXQHov4ez9mtRExXkVFVc9zjPDspzQB2zNuxUmSN7uZ4eayM5o0A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=O4fmCd13; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6C84606A320; Wed, 18 Nov 2026 19:43:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=O4fmCd13 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BFFB1F000C4; Wed, 18 Nov 2026 19:43:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795031039; bh=0fq6LYSX2zuPoRtPVsCZq003qSO3WG/AsycW7TRFubc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=O4fmCd13C6mvu4TrzKwnOKw4mZFv2YXq5TsSyqJ/M4ero4WFqoQZwvulqxKUdmgFJ NqoU0+v/7JGa5zYXDdQ//gPiL7Y6BDjyizY5G8uXeA+Ue/GGqqDTHGgk7SrwgHOb9L 3I6DmiWIKa1MSQfmaKB34pLazl0HSdPlguJC5m3g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, sashiko-bot@kernel.org, Frank Li , Linus Walleij , Vinod Koul , Sasha Levin Subject: [PATCH 6.12 0880/1756] dmaengine: ste_dma40: Fix probe runtime PM disable Date: Wed, 18 Nov 2026 15:50:07 +0100 Message-ID: <20261118150044.542695205@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150007.957976754@linuxfoundation.org> References: <20261118150007.957976754@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Linus Walleij [ Upstream commit c6809b381e34f8966cc3d9e5d7d658775a408f83 ] Some d40_probe() error paths jump to destroy_cache before runtime PM has been enabled for the DMA controller device. The label unconditionally calls pm_runtime_disable(), which increments disable_depth even though this probe attempt never enabled runtime PM. Use devm_pm_runtime_set_active_enabled() to mark the controller active, enable runtime PM and register balanced cleanup for probe failure. This avoids both the disable-depth imbalance and ad-hoc probe state tracking. The interrupt handler uses pm_runtime_get_if_active() and cannot acknowledge a pending interrupt while runtime PM is disabled. Request the IRQ only after enabling runtime PM so the handler cannot enter an unacknowledged interrupt loop during probe. Fixes: 0618c077a8c2 ("dmaengine: ste_dma40: Fix PM disable depth imbalance in d40_probe") Reported-by: sashiko-bot@kernel.org Closes: https://lore.kernel.org/dmaengine/20260618051539.15E201F000E9@smtp.kernel.org/ Assisted-by: LLM Reviewed-by: Frank Li Signed-off-by: Linus Walleij Link: https://patch.msgid.link/20260927-dma40-fixes-v7-5-89f595e8851d@kernel.org Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/ste_dma40.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index 2f636c7333d24..08d1c2197ded5 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -3602,12 +3602,6 @@ static int __init d40_probe(struct platform_device *pdev) goto destroy_cache; } - ret = request_irq(base->irq, d40_handle_interrupt, 0, D40_NAME, base); - if (ret) { - d40_err(dev, "No IRQ defined\n"); - goto destroy_cache; - } - if (base->plat_data->use_esram_lcla) { base->lcpa_regulator = regulator_get(base->dev, "lcla_esram"); @@ -3632,10 +3626,20 @@ static int __init d40_probe(struct platform_device *pdev) pm_runtime_irq_safe(base->dev); pm_runtime_set_autosuspend_delay(base->dev, DMA40_AUTOSUSPEND_DELAY); - pm_runtime_use_autosuspend(base->dev); pm_runtime_mark_last_busy(base->dev); - pm_runtime_set_active(base->dev); - pm_runtime_enable(base->dev); + + ret = devm_pm_runtime_set_active_enabled(base->dev); + if (ret) { + d40_err(dev, "Failed to enable runtime PM: %d\n", ret); + goto destroy_cache; + } + pm_runtime_use_autosuspend(base->dev); + + ret = request_irq(base->irq, d40_handle_interrupt, 0, D40_NAME, base); + if (ret) { + d40_err(dev, "No IRQ defined\n"); + goto destroy_cache; + } ret = d40_dmaengine_init(base, num_reserved_chans); if (ret) @@ -3671,7 +3675,6 @@ static int __init d40_probe(struct platform_device *pdev) regulator_disable(base->lcpa_regulator); regulator_put(base->lcpa_regulator); } - pm_runtime_disable(base->dev); report_failure: d40_err(dev, "probe failed\n"); -- 2.53.0