From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795053232; b=XiC+miKOiSCdp08kPAS9yY72V2o5KloP6nj6p4sFFwk5unc15xATagz5pKZvR04xbvft lrX8CK2eM0DVheLkDOuvqYv9lAH0aRtjy0V1Hg2cuswjXr//7UUfh4pGfmqNcK0iLOWNk Uo4gPlNc+S1Z/4cuB2wUambEH9ko6kM6TdV0QPZZ9u2wsgRJMiFK4zOkhYMpYC+7XUMp4 D4waMGZgxUBkE8/um0ljDRepiNTRBsyaCNdzKgW6gkKhS/0dPIpb7n1yz4c9TcJzNtuQa aArxfXrbQnt6dnadNKfVhXsmjdIyVnyroTjCqQAkB9gLvtSGQy+is57VFFYJvIUlWRA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795053232; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=TwhdiWvIAGx9qSfIP9PCNVsMvErYNx0WWW/bzyxx828=; b=4+enHXUU0noi1K8bDbRsBm35Fn8FDXu76gIpcHXrlUC+kSUXxEEmWB8lcsSBGCtvPxjB izctsUIcza/M/mOgRjFRaUfcFfcsrCy5nz2fIIlzph1oQR2D55MiQ03MqqLVearoJ2pDS 7Iaq+y3L7U3puaMtfhDlMhyyhFIc16BvV7zLTxSuG6e2yQs/tsBEjuQLHfriNCPliWAjK y5/tXl0Tw0uZ8H0QUEFFuNBVItFqTOd/ytP7aTbuDJXbcQS07wha9K6rolNhj9xer0MF5 gYQVbu12HeUSiUwQdWy/+xuZV+ndFaiwDNjvGQTeBmQZa2CCbpAdIbUuO23kNgv7Lew== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=wZtR2t8E; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A219D606A337; Thu, 19 Nov 2026 01:53:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=wZtR2t8E Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFD3F1F000C5; Thu, 19 Nov 2026 01:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795053232; bh=TwhdiWvIAGx9qSfIP9PCNVsMvErYNx0WWW/bzyxx828=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=wZtR2t8ENSUjlAak7TYtj2eTkWTFAKKb0deYy+vLUoEgf5mlTihIfjg64ozjjcGoe gGOasgMc1izq6QSgEMmHVhqktmcNbB9TISQnoBliRRZ8aBlvXpGoXsuOwc/3A0D9gb 4+Plq/W+rao2O3GYVaQDzJ1kSubiHC8JBC/5ptBU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sven Eckelmann , Sasha Levin Subject: [PATCH 5.15 0847/2214] batman-adv: fix skb leak when hard_iface is being released Date: Wed, 18 Nov 2026 15:42:03 +0100 Message-ID: <20261118150046.061482374@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sven Eckelmann [ Upstream commit 522e4aece2e96cacbb8a6ae1eec0d4c0dd6f4fed ] batadv_batman_skb_recv() owns the skb it is given. When the hard_iface refcount already dropped to zero, the function jumped to err_out, which only returned NET_RX_DROP and skipped the kfree_skb() under err_free. To avoid a leak, free the skb before returning in this case. Cc: stable@vger.kernel.org Fixes: 4fe56e60ac1b ("batman-adv: Check hard_iface refcnt when receiving skb") Signed-off-by: Sven Eckelmann Signed-off-by: Sasha Levin --- net/batman-adv/main.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c index 78c63e61f41e8..6d3d15332ff9e 100644 --- a/net/batman-adv/main.c +++ b/net/batman-adv/main.c @@ -448,8 +448,10 @@ int batadv_batman_skb_recv(struct sk_buff *skb, struct net_device *dev, * shut down otherwise the packet may trigger de-reference errors * further down in the receive path. */ - if (!kref_get_unless_zero(&hard_iface->refcount)) - goto err_out; + if (!kref_get_unless_zero(&hard_iface->refcount)) { + kfree_skb(skb); + return NET_RX_DROP; + } skb = skb_share_check(skb, GFP_ATOMIC); @@ -508,7 +510,6 @@ int batadv_batman_skb_recv(struct sk_buff *skb, struct net_device *dev, kfree_skb(skb); err_put: batadv_hardif_put(hard_iface); -err_out: return NET_RX_DROP; } -- 2.53.0