From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795053385; b=Bmbhnkqmyc0fjnSG/I0X+wXEEAJDndWtm1Dot0F9+fCAzlA9GMhSjVlEQyXMir3nKNIm 5nzV8+JoI56+IEUP/z+4jL7RjW26q2m6bzHxa8Lw9VIw/u2kwKfvAP7wPjM8og5XASC2z sQhly8ApKV2G3FCsOVSr50xoFimpaWhW8K7nxRFt62o8lRI5fP9eGscbX+vlHDHbc7ekf Sfi1QRBKZ87cZZuc47hIbZTl5ZQaaLlIVVTZO7tt20LnikQN8mXxUQ7IRHOXFegUbG8ZP m88IWoZzGUxwlKdP0la3qBugynNJqC7OzYTzWh+MnsRlbdMu/LnD1arKxSP+/XVFIqw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795053385; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=3eIG/6Vxo9gSzvcTzjxxBskPYORQeWL6THN1SCZ/1io=; b=Zy1eqF+gsOgoEdclWT7vritpW1j1zyfycsacAVIBagYQTKLHMWvUP2EJc6CF6Sgtirg7 7Tg7XaYkH69tI7tHreyatCy/Jd3WWlpP/sYECLjjgl8VqZ6r7TItYk7TgZuAQM13emweV PJMChZuQUM+XnUwlqWv7t/p0TEAfht5spUIXZtSp3kafOon1ra7jqcnnmt+ljVHIC/4YU Q163a8IB+d9icFbFuuy6QU70grxMNxLxeTyfnCTNfPh8LmkjBZYEa4nXrXrlayknQaEHW m/2EvyPfRnW6yi6yFazV07NIHDryneEafpaP0YgGtaxa02rm5AJmGWzwGkfy5gwIo/g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=0vcLvy1v; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74442606A320; Thu, 19 Nov 2026 01:56:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=0vcLvy1v Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9D181F000C4; Thu, 19 Nov 2026 01:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795053385; bh=3eIG/6Vxo9gSzvcTzjxxBskPYORQeWL6THN1SCZ/1io=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=0vcLvy1vOs9rKunNT9/Ck+7RshYE7nnRr0EO4RY26jcJ4NqG1xEFUge4+Z5vtbhL+ gofayviXB9mHxJPN4+CjGzOWOw7e5XC6SY5Jv1MrV0iFtXGLdpzM11kDaxarjB7hGk VFL2ucpl3guS9Ovxl7VgBLWiImwReGOSBs7IzVwQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chris Mason , "Lorenzo Stoakes (ARM)" , Muchun Song , Muhammad Usama Anjum , "David Hildenbrand (Arm)" , Sasha Levin Subject: [PATCH 5.15 0902/2214] mm/gup: fix out-of-bounds write for nr_pages == 0 in GUP-fast Date: Wed, 18 Nov 2026 15:42:58 +0100 Message-ID: <20261118150048.361361076@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150009.797899913@linuxfoundation.org> References: <20261118150009.797899913@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chris Mason [ Upstream commit 1dfe4b276c23189394afb42d114ee8a54cc3aff2 ] With nr_pages == 0, GUP-fast still enters its page table walk and can write past the caller's page array. The old end <= start check caught empty ranges, but was replaced with an overflow check. Users such as OrangeFS can pass a zero page count derived from a userspace-supplied length. So let's return zero for nr_pages == 0 before starting the walk, just like GUP-slow. Fix generated by an LLM and sent by Chris Mason in private. Fixes: c28b1fc70390 ("mm/gup: reorganize internal_get_user_pages_fast()") Cc: stable@vger.kernel.org Signed-off-by: Chris Mason [ david: simplify description ] Reviewed-by: Lorenzo Stoakes (ARM) Acked-by: Muchun Song Tested-by: Muhammad Usama Anjum Link: https://patch.msgid.link/20261031-fixes_core-v3-21-d6437171ecc3@kernel.org Signed-off-by: David Hildenbrand (Arm) Signed-off-by: Sasha Levin --- mm/gup.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/gup.c b/mm/gup.c index 118c474471850..c1508281c2f93 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -2888,6 +2888,9 @@ static int internal_get_user_pages_fast(unsigned long start, FOLL_FAST_ONLY | FOLL_NOFAULT))) return -EINVAL; + if (unlikely(!nr_pages)) + return 0; + if (gup_flags & FOLL_PIN) mm_set_has_pinned_flag(¤t->mm->flags); -- 2.53.0