From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795022561; b=3jT1gF4wozCSgS707qOppCOI/Oyw8qGmibg2dWzBflzbWzfzPRmG7zDjGU/icpow9/qj cTuXbURLribof6kZPqHroaDeS2Azc4ayQDFtoOqUq497sUJ1mw7FoVY2ITTsMsFOXl64H sWSFOqVMgrMYBUR0Fl6wNXVVB7hJTS8+q945ut6iUFktZfG1uEfSLkwPBZLAJIK6HwCO8 f6saflHixRGQfZhS7DWzpoAEzNkb9kfckp24YKEIIdZl/E8g55+/tFy67MBNpz2LuuaOj LwvXQD5CUEyu5vD3Ul+XcPGAAJyL555lDRxQRnVTbLMFEXUuIU5HxJ/NXbGeJlowo+Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795022561; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=fUMN+z9+7ZmceG+OzwyrlCF/E06sW+PRW9wTXWlFiZE=; b=gETalEwGBQDo4VvRTJH+j2xwDvnoeilADVop8YLaxYs+bapZe1X1KWGMLHUxOrFO7s6t xlBkr6rcfe4z17kLUfUIPhp6QSnRcw1KOD7DK0KuEBqTK4kuHVGqaBfQmMo6uHIb5t3/y EGV63V28rqZUF7aeRNlen/vJ51FhCya0PLCvE0X0ZWFUJA8jBvcUWRxBW5ohL3Pttbq0u dnA8JOP2Czfw8TBYMJewCEkF9KlVvF0bwOngdhDICor008gZ4sN/+F8W2BdR5H+SLgECo mUfOBiRBkA4c+5OYyskMkWzLtFHm/p6N5r3n7g6Ljna2GpgZcE3KJqvbLmeKfjVu9Rg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="slpenHH/"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D832760A2610; Wed, 18 Nov 2026 17:22:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=slpenHH/ Received: by smtp.kernel.org (Postfix) with ESMTPSA id 377871F000C4; Wed, 18 Nov 2026 17:22:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795022561; bh=fUMN+z9+7ZmceG+OzwyrlCF/E06sW+PRW9wTXWlFiZE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=slpenHH/t5+Ktg2kZNBgyhLHWdUqadQnxnZiSVt0V1ErWyyGAN/XioB7mVKjC9VKg UbVw6K0A37dVSLy3b5l/KYYj9/oYekW1C2t0chdNG3OuCuk1o2v0UUcqZjDOqlRSVU 3sH6jJUAmKVDxBUxwBwnGJRCBukKFgZn37t0uMmU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ijae Kim , Myeonghun Pak , Guenter Roeck , Sasha Levin Subject: [PATCH 6.18 0058/2151] hwmon: (sht15) Stop deferred work before releasing its resources Date: Wed, 18 Nov 2026 15:29:53 +0100 Message-ID: <20261118150123.860108663@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150121.603863898@linuxfoundation.org> References: <20261118150121.603863898@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Myeonghun Pak [ Upstream commit 5eab1e7f7ed12893f3864fe46ffcd5a41a752d6a ] The IRQ handler and regulator notifier can leave work pending after a measurement or notification completes. Neither work item is drained before its resources are released on removal or probe failure. Disable read_work before freeing the IRQ, since the worker can re-enable it. Use request_irq()/free_irq() for explicit teardown. Unregister the regulator notifier before cancelling update_supply_work and disabling the regulator. Apply the same ordering to probe failures. Fixes: 251eb40f5ccd ("hwmon: sht15 humidity sensor driver") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Link: https://patch.msgid.link/20261024014044.27853-1-mhun512@gmail.com [groeck: Dropped obsolete 'Assisted-by: tag] Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/sht15.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/drivers/hwmon/sht15.c b/drivers/hwmon/sht15.c index 48bcd362c4808..8af2336052b0e 100644 --- a/drivers/hwmon/sht15.c +++ b/drivers/hwmon/sht15.c @@ -31,6 +31,7 @@ #include #include #include +#include /* Commands */ #define SHT15_MEASURE_TEMP 0x03 @@ -976,25 +977,22 @@ static int sht15_probe(struct platform_device *pdev) goto err_release_reg; } - ret = devm_request_irq(&pdev->dev, gpiod_to_irq(data->data), - sht15_interrupt_fired, - IRQF_TRIGGER_FALLING, - "sht15 data", - data); + ret = request_irq(gpiod_to_irq(data->data), sht15_interrupt_fired, + IRQF_TRIGGER_FALLING, "sht15 data", data); if (ret) goto err_release_reg; disable_irq_nosync(gpiod_to_irq(data->data)); ret = sht15_connection_reset(data); if (ret) - goto err_release_reg; + goto err_free_irq; ret = sht15_soft_reset(data); if (ret) - goto err_release_reg; + goto err_free_irq; ret = sysfs_create_group(&pdev->dev.kobj, &sht15_attr_group); if (ret) { dev_err(&pdev->dev, "sysfs create failed\n"); - goto err_release_reg; + goto err_free_irq; } data->hwmon_dev = hwmon_device_register(data->dev); @@ -1007,9 +1005,13 @@ static int sht15_probe(struct platform_device *pdev) err_release_sysfs_group: sysfs_remove_group(&pdev->dev.kobj, &sht15_attr_group); +err_free_irq: + disable_work_sync(&data->read_work); + free_irq(gpiod_to_irq(data->data), data); err_release_reg: if (!IS_ERR(data->reg)) { regulator_unregister_notifier(data->reg, &data->nb); + cancel_work_sync(&data->update_supply_work); regulator_disable(data->reg); } return ret; @@ -1023,12 +1025,16 @@ static void sht15_remove(struct platform_device *pdev) hwmon_device_unregister(data->hwmon_dev); sysfs_remove_group(&pdev->dev.kobj, &sht15_attr_group); + disable_work_sync(&data->read_work); + free_irq(gpiod_to_irq(data->data), data); + ret = sht15_soft_reset(data); if (ret) dev_err(&pdev->dev, "Failed to reset device (%pe)\n", ERR_PTR(ret)); if (!IS_ERR(data->reg)) { regulator_unregister_notifier(data->reg, &data->nb); + cancel_work_sync(&data->update_supply_work); regulator_disable(data->reg); } } -- 2.53.0