From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795022638; b=GDfvB2CJyJ5hP0+WQRhSA/dOIoLBB/XKXRHc4I5jffzehYi2G2vPkDBI/rFzS/4+5p7q bnPnxcty4gQjyCzAb4jn3TEoUvJ0JLwxyOc7OuVFaBcu60iNGz3RSSDCPcatrDsAFzoHD wgZ29ESThe5mSkN1NrV3o3E+MGqrKOeDZ9ViMS+nND9+803IfAIPM29rgsx0srDJjRyTl mhllclEuGJKdaMszkljIla8ziCyqWuShNEjIRl6zwsr/JHliNvB9arNWTCoOcGYPOk0UH EqTtNDgm95fUyYJ37kDhggSAWju1/oIbeBHOUiGbVLWd4MCFUu2diTNatUDKC/jm+Bg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795022638; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=YW9EWm/JHNOsvJDGzAhZIJmD7DD0C/Y/XcLXnEKBHxY=; b=5tvkBj5elr7Go5wKH8nC/+Hlp2SH1ISeMNr8qAo912y5eSxbr+YOmj2HVgtV5c2QfJ+p VixHPZiBia5NyauweYigb1ZG5jc88fS/+h5bZgA6xbqC4Tftlx28r+xpbUFpR/NUvXsoB d2GW50+HkyRLYGTtnxXac4cTj2ErO0bLxgzxFSRGwIZYdy6iEdOz3rwn9q/wNjVNmtcze 6STsrkxZCz2odBh6Fguk8Ivr9yNgIyGwkpzv+yJjw9Z0FNmLebFeuMq5sZVPQeivzXJIS jow24RQpVunuDll3twBVjA93VPcORNTg8WUKcCTGpdAL3rj0vFRdbTlo+VC562Jpfgw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=LwBfFr4m; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1649C606A32C; Wed, 18 Nov 2026 17:23:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=LwBfFr4m Received: by smtp.kernel.org (Postfix) with ESMTPSA id 710841F000C9; Wed, 18 Nov 2026 17:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795022637; bh=YW9EWm/JHNOsvJDGzAhZIJmD7DD0C/Y/XcLXnEKBHxY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=LwBfFr4mBpc+MWRsMTKJnZht65taNRgfg1zdhogPh718OrwFk7T2YGpOynvq46+nK PKXX9/fqctuJp/CqNehLtqg6XAVkkqZWYpS8KJnE91XY+eyht5+RB6d033m6MDB8of i41sWBehGHHZgIoJ3cEgLWaHmg0axqBhC+QmS/Nw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sashiko , =?UTF-8?q?Asaf=20Nuri=20Bertizlio=C4=9Flu?= , Guenter Roeck , Sasha Levin Subject: [PATCH 6.18 0083/2151] hwmon: (coretemp) Fix 32-bit jiffies wraparound in show_temp() Date: Wed, 18 Nov 2026 15:30:18 +0100 Message-ID: <20261118150124.808640745@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150121.603863898@linuxfoundation.org> References: <20261118150121.603863898@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guenter Roeck [ Upstream commit 9a6aa085c94c7f2817c4d50a7264e6fb51286f40 ] show_temp() rate-limits MSR reads by storing tdata->last_updated as an unsigned long and comparing it against jiffies using time_after(jiffies, tdata->last_updated + HZ). time_after() relies on signed long subtraction, which only produces the expected result while the two timestamps are within LONG_MAX jiffies of each other. On 32-bit kernels, if tempX_input is not read for more than LONG_MAX jiffies (~24.85 days at HZ=1000), the signed difference flips sign and time_after() evaluates to false. Because tdata->last_updated is only refreshed when time_after() succeeds, subsequent reads remain blocked from refreshing for another ~24.85 days until jiffies wraps past tdata->last_updated + HZ again, returning either a stale cached temperature or -ENODATA if the sensor had never been read since initialization. Store tdata->last_updated as a u64 and use get_jiffies_64() with time_after64(), which does not wrap in any practical uptime. Reported-by: Sashiko Fixes: bebe467823c0 ("hwmon: New coretemp driver") Cc: stable@vger.kernel.org Tested-by: Asaf Nuri Bertizlioğlu Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/coretemp.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c index 3cbdf48b15af0..709ffc758d7fa 100644 --- a/drivers/hwmon/coretemp.c +++ b/drivers/hwmon/coretemp.c @@ -77,7 +77,7 @@ struct temp_data { int temp; bool temp_valid; int tjmax; - unsigned long last_updated; + u64 last_updated; unsigned int cpu; int index; u32 cpu_core_id; @@ -400,7 +400,7 @@ static ssize_t show_temp(struct device *dev, mutex_lock(&tdata->update_lock); /* Check whether the time interval has elapsed */ - if (time_after(jiffies, tdata->last_updated + HZ)) { + if (time_after64(get_jiffies_64(), tdata->last_updated + HZ)) { tjmax = get_tjmax(tdata, dev); rdmsrq_on_cpu(tdata->cpu, tdata->status_reg, &val.q); /* @@ -410,7 +410,7 @@ static ssize_t show_temp(struct device *dev, */ tdata->temp_valid = (val.l >> 31) & 1; tdata->temp = tjmax - ((val.l >> 16) & 0xff) * 1000; - tdata->last_updated = jiffies; + tdata->last_updated = get_jiffies_64(); } valid = tdata->temp_valid; @@ -522,11 +522,8 @@ init_temp_data(struct platform_data *pdata, unsigned int cpu, int pkg_flag) tdata->cpu = cpu; tdata->cpu_core_id = topology_core_id(cpu); tdata->attr_size = MAX_CORE_ATTRS; - /* - * A zero timestamp does not look stale on 32-bit, where jiffies - * starts just short of wrapping. Backdate it instead. - */ - tdata->last_updated = jiffies - HZ - 1; + /* Backdate to force a refresh on the first read */ + tdata->last_updated = get_jiffies_64() - HZ - 1; mutex_init(&tdata->update_lock); return tdata; } -- 2.53.0