From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795022760; b=XsHAOGYRKFwpIFmzpgVo4bF4Gxua4crdI40hrPwtlLXr/hQMqOLYiLipIq0uR09ceUB4 GpJXayxNBIpaPlA5dp4MBoSPab3FvfiDaK9JruMpigQYtn4Yw609dhnY2jVw4b6VutOGx eelk3nUccmL6E3nsX+fwl0ME6HPW6wL/UE+vmOcBCz92qyYcXIcmzJVxACFf4qEz1tF2C wQcDslnyVyhB7oxEJ57s3oi90PnoaoQ72vi90rMT0XkiNoSOOH5nfAJJzph/zCZPudY+m xIku3GKUuv7NuVL66DwNdrKjVvXyrAHdDR3duJOzIx47a7PZmSkb9+smbZf+HXfs5xw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795022760; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=1feMw7qXhTSCZutIBv63syk9l5bRXH+d6RPvJxZKdDA=; b=mR9JdLA4j01G5BIM85rUVHxT7n8GQ4ll+bTYHhxWpzwC22AXxhLs3uXFWkS7gjUptPOC gMIxVV1v5NiATV30m7emERhvtRShz4G9T6vglVXMo0MRqz6NyWzLfS22Y7BZV2wLPBk8B /DotP1KNu00sIsjVPP+hs6WtqQ65/YgJPqhl14O5gWUw2cAkgxDxl7gEZRHGA8twada6i qpFbpw633yEOi0IIehA8tUPPL5PW5ghCRm068Wza3PQqOHV3OdambnaSotlVYu8wWz9qA 6KoIJ5oX1iscJf1WWoZLmi1y99ZBlpM7zuCWgvzHM2ogGvZh7BEwJ4tU5HpgYI5MsVA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=sqbhS4u6; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7FF260A2614; Wed, 18 Nov 2026 17:26:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=sqbhS4u6 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CA3A1F0281B; Wed, 18 Nov 2026 17:26:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795022760; bh=1feMw7qXhTSCZutIBv63syk9l5bRXH+d6RPvJxZKdDA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=sqbhS4u6O+I56SadJ4hXMjOba7tPxrn5Y3zyNakwBoGT55fKVYZvtc1Qj/sgabraB Tlbak4UprzdN66KVMnymtioOEcWQD2jNvTziW+u76UASHfwyy0PQMAC24/JPVMxOlu t68+ylFi3pz2ur8TwSfgbKixh6oIxmCKuaWgM2+Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Raveendra Talabattula , Liviu Dudau , Sasha Levin Subject: [PATCH 6.18 0127/2151] drm/komeda: Fix bits parsing of GLB_CORE_ID Date: Wed, 18 Nov 2026 15:31:02 +0100 Message-ID: <20261118150126.418100426@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150121.603863898@linuxfoundation.org> References: <20261118150121.603863898@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Raveendra Talabattula [ Upstream commit ec902de0221747094f9ccbb61454e9633fbf282f ] GLB_CORE_ID contains the product and version information returned by the hardware. The current macros parses VERSION_MINOR as a 4-bit field and VERSION_STATUS as an 8-bit field, which does not match the register layout. As a result, the driver reports an incorrect version number. Fix the parsing macros to match the hardware specification: - VERSION_MINOR is 8 bits at [11:4] - VERSION_STATUS is 4 bits at [3:0] Fixes: bd628c1bed79 ("drm/komeda: komeda_dev/pipeline/component definition and initialzation") Signed-off-by: Raveendra Talabattula Reviewed-by: Liviu Dudau Signed-off-by: Liviu Dudau Link: https://patch.msgid.link/20260803142122.4127851-2-raveendra.talabattula@arm.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/arm/display/include/malidp_product.h | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/arm/display/include/malidp_product.h b/drivers/gpu/drm/arm/display/include/malidp_product.h index 16a8a2c22c423..f0c34eff523f1 100644 --- a/drivers/gpu/drm/arm/display/include/malidp_product.h +++ b/drivers/gpu/drm/arm/display/include/malidp_product.h @@ -8,14 +8,18 @@ #define _MALIDP_PRODUCT_H_ /* Product identification */ +/* GLB_CORE_ID fields as per HW specification: + * MINOR is 8 bits ([11:4]) and STATUS is 4 bits ([3:0]). + * Update masks/shifts accordingly. + */ #define MALIDP_CORE_ID(__product, __major, __minor, __status) \ ((((__product) & 0xFFFF) << 16) | (((__major) & 0xF) << 12) | \ - (((__minor) & 0xF) << 8) | ((__status) & 0xFF)) + (((__minor) & 0xFF) << 4) | ((__status) & 0xF)) #define MALIDP_CORE_ID_PRODUCT_ID(__core_id) ((__u32)(__core_id) >> 16) #define MALIDP_CORE_ID_MAJOR(__core_id) (((__u32)(__core_id) >> 12) & 0xF) -#define MALIDP_CORE_ID_MINOR(__core_id) (((__u32)(__core_id) >> 8) & 0xF) -#define MALIDP_CORE_ID_STATUS(__core_id) (((__u32)(__core_id)) & 0xFF) +#define MALIDP_CORE_ID_MINOR(__core_id) (((__u32)(__core_id) >> 4) & 0xFF) +#define MALIDP_CORE_ID_STATUS(__core_id) ((__u32)(__core_id) & 0xF) /* Mali-display product IDs */ #define MALIDP_D71_PRODUCT_ID 0x0071 -- 2.53.0