From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795024213; b=WkRKXLZsSk0TuZZAbrsKJgeJoMf6q/GIgsEtgo8VdBofgSW5ja9p8MAQ0t2A6S14Arlj LwkgPRp3yNJItKYHYJEyuPCW2ih1/tjgpiqCCe3hKIDkNf4sG6+HWaP+UGqn5cDlMOzAL JjGwGQUR0ArmI8rRV30YgYekmL6quTn6xB2KKDn+PQSvF5R2EIoE7WKXUQeCC81xFlXms dII8j3PiPKGbVrmWbcOVnvoTxlw+hRtOgSPiIJtEMAuFWY37yRxTc00Fy3/sY6Wai0aSY K3wrU+aq+8ADMi7LkzGEEUIbWLBQ1PDduLyW1O5Gzn7Fpafl6uMrN5Q8A5uHE8zLzjw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795024213; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=Fc8qjTCReO804kozyyZpxpFYpzttzfjOuzaxA5At47M=; b=VWRfKfDKP79qMnuGnvWk6kg3j7NT4SsERyjjzSSFLF+QfV8msBvodjtR6zR0oQgVhQhu x8fsofRlhfEsJL6AMV5YT2UXqA7uiMkM4arbYBGOP7M7tBhmnhjIhzyRcUPdnHwIP7X24 YL2z6esp8FvvoPDwlPLNywatVbG5h3sGeWj+VlXkF9SIVtLjQzQZ4EArYEjggLqnVrRN5 TD6NMW+E3TXPdmnO1Rd+31KxIF9ILwhO+steKoKNZZBg+p8alPXhGeDh/W4fhOtOt4VFv vhMohnPYsZmlwDrTLZDkRG7FaJOOsdgUPZyUODd46iDDDYiI2KMYHm1Q0mDmeevguoA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=qxxx6rQ1; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4519F606A31C; Wed, 18 Nov 2026 17:50:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=qxxx6rQ1 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EAC31F000C5; Wed, 18 Nov 2026 17:50:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795024213; bh=Fc8qjTCReO804kozyyZpxpFYpzttzfjOuzaxA5At47M=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=qxxx6rQ1PKafGC8QJgJ9r/xqsWvX1ngXNxhABN2ejRXwqLk6je14CbdmB4ciruqFW mZrdcCPa9NkdnJg62kXmdW3ZCJOkS8yeSJ6LPhh+AahojWoqIAqmONzegTmNePUrap B3Zva5itKDderpbgoZOp8Yk5T3UPUXnheNvrNkLI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Laurent Vivier , Finn Thain , Stan Johnson , Jens Axboe , Sasha Levin Subject: [PATCH 6.18 0643/2151] swim: Check error register during sector read Date: Wed, 18 Nov 2026 15:39:38 +0100 Message-ID: <20261118150145.280400899@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150121.603863898@linuxfoundation.org> References: <20261118150121.603863898@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Finn Thain [ Upstream commit d66bdef0a3083fed1a0fc4f0ee1c85b26476b21c ] Clear the error register only once before a sector read operation. Don't clear it afterwards -- the caller needs it. Check the error register in swim_read_sector() and return the appropriate error when necessary. Fully validate the sector header. Don't terminate the search loop early just because an erroneous sector header showed up. Fixes: 8852ecd97488 ("m68k: mac - Add SWIM floppy support") Reviewed-by: Laurent Vivier Signed-off-by: Finn Thain Tested-by: Stan Johnson Link: https://patch.msgid.link/efabd807f4ecf5cbc05b60e91ed69aa4c10691a8.1788513997.git.fthain@linux-m68k.org Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/block/swim.c | 13 +++++++------ drivers/block/swim_asm.S | 8 -------- 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/block/swim.c b/drivers/block/swim.c index 178f270ef24e7..ebba9506e78d0 100644 --- a/drivers/block/swim.c +++ b/drivers/block/swim.c @@ -483,20 +483,21 @@ static inline int swim_read_sector(struct floppy_state *fs, local_irq_save(flags); for (i = 0; i < 36; i++) { - ret = swim_read_sector_header(base, &header); - if (!ret && (header.sector == sector)) { + if (swim_read_sector_header(base, &header) || + swim_read(base, error) || header.track != track || + header.side != side || header.size != 2) + continue; + if (header.sector == sector) { /* found */ ret = swim_read_sector_data(base, buffer); + if (swim_read(base, error)) + ret = -EIO; break; } } local_irq_restore(flags); - if ((header.side != side) || (header.track != track) || - (header.sector != sector)) - return 0; - return ret; } diff --git a/drivers/block/swim_asm.S b/drivers/block/swim_asm.S index 81c824923336c..fcf574ced85ec 100644 --- a/drivers/block/swim_asm.S +++ b/drivers/block/swim_asm.S @@ -67,7 +67,6 @@ mfm_read_addrmark: movew #seek_time, %d2 wait_header_init: - tstb %a3@(read_error - read_mark) moveb #0x18, %a3@(write_mode0 - read_mark) moveb #0x01, %a3@(write_mode1 - read_mark) moveb #0x01, %a3@(write_mode0 - read_mark) @@ -140,8 +139,6 @@ crc1: tstb %a2@ andb #.Lhr_crc_error, %d5 bne signal_nonyb - tstb %a3@(read_error - read_mark) - moveq #0, %d0 signal_nonyb: moveb #0x18, %a3@(write_mode0 - read_mark) @@ -166,7 +163,6 @@ mfm_read_data: movew #seek_time, %d2 wait_data_init: - tstb %a3@(read_error - read_mark) moveb #0x18, %a3@(write_mode0 - read_mark) moveb #0x01, %a3@(write_mode1 - read_mark) moveb #0x01, %a3@(write_mode0 - read_mark) @@ -191,8 +187,6 @@ wait_data_mark_byte: /* read data */ - tstb %a3@(read_error - read_mark) - movel #sector_size-1, %d4 /* sector size */ read_new_data: movew #max_retry, %d2 @@ -234,8 +228,6 @@ data_crc1: andb #.Lhr_crc_error, %d5 bne data_exit - tstb %a3@(read_error - read_mark) - /* return number of bytes read */ movel #sector_size, %d0 -- 2.53.0