From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795024486; b=yn/s1zJ+Zr19wSOm9R5DYpkvGs/hx1n2LLrN8zcOcEA1tOpEvjFLItYSiPDLN5/83kh1 CZezpBrlWNw9Bk2deJd+AX4CLnWxeO7SwsixgHYZdrJ3aZuLXlB2qJhxlGVXu9Rq2cdgt W9LPFMmj9DemmXjqOvuCeAA11YYBR3+WYfLCqnet1EEbii809AeEZ1qW6vlU0ZCqQzpQt kmgL8kvyNYYx8KiYD0hWjrHQD29ZjxoKufn6+URs/JO0ejecxEeRIBU4/1wLsVygyGj4O SGGUwhMRACqtcghhtewjPTtpdvuk8Q76ROvrItup78WCeFRYIhsXQBAialq4WaZnRvw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795024486; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=T2ZQJFXiFJj7Lu29W2TMP2O/RAIw64abJdMxMwslREI=; b=LiDeV+fcdiQzYV8Ml5X+uFlSuZ5SWzkl1UAHkLQPXl6DeY2h2zhTtE18aYnU84x8NuPI bBAXyqMIwo4gIJjUDabHNHdYm8WVTiIDcK272ut55GSfNvZH8WdscjZS7fyXr/2gBUIUn HRBFDewuZc4epAokCAompPxSFfpVYhWcKN84dzp3eejSJP6T4HoYi7kkYgflPxWZKAxnv 0QoAcHVBm6JAC8E8xyK44CTMiPpUpuhDdV4dnw9U4uJKiSARxGXwvSVxlzY2OsU2PcAks f2LLSQAMP2MMryxljrF17+NIOF9/kIz6jG4hEc/imTqKKDV3O/WXPqT+pKXhUFNqXLA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=IAYTFvf2; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66176606A325; Wed, 18 Nov 2026 17:54:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=IAYTFvf2 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BD421F000CC; Wed, 18 Nov 2026 17:54:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795024486; bh=T2ZQJFXiFJj7Lu29W2TMP2O/RAIw64abJdMxMwslREI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=IAYTFvf2J4cEt7USIoB+hTstQfjPSvxnROZnw6higgpqqs/vyjlS9fQwPSHYBZdAI HcSWgoWnD1zVWz1jZ6hUehPoCYIQasP+JobafQ86eustsfHNa0RyEa6lm0uT/qqgxd 0q5fZGZvp4809RXGBu7jUakQpGS1XECHR6Nkl/TQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Breno Leitao , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 6.18 0743/2151] ACPICA: Fix memory leak in acpi_ds_create_field() Date: Wed, 18 Nov 2026 15:41:18 +0100 Message-ID: <20261118150149.106086285@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150121.603863898@linuxfoundation.org> References: <20261118150121.603863898@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Breno Leitao [ Upstream commit dbb3d99ee95c32711950850ddd33eb22a6042eb2 ] acpi_ds_create_field() allocates internal_pcc_buffer for operation regions in the PCC address space. The function runs once per field, so a second field on the same region overwrites the pointer and orphans the previous buffer. The matching ACPI_FREE() in acpi_ut_delete_internal_obj() only ever sees the last one. An arm64 platform whose SSDT declares regions with multiple fields each leaks two buffers at boot, as detected by kmemleak: unreferenced object 0xffff000051e65400 (size 192): comm "swapper/0", pid 1, jiffies 4294668436 backtrace (crc 0): __kmalloc_noprof acpi_ds_create_field acpi_ds_load2_end_op acpi_ds_exec_end_op acpi_ps_parse_loop acpi_ps_parse_aml acpi_ns_load_table acpi_load_tables acpi_init Do not allocate a region if it was previously allocated before, preserving the current design, but, not leaking memory. Fixes: aa6ec56b574d ("ACPICA: ACPI 6.3: add PCC operation region support for AML interpreter") Link: https://github.com/open-acpica/acpica/commit/c71849d476bb5f97ca1867849e893368e12a69e6 Signed-off-by: Breno Leitao [ rjw: Subject tweak, fixed the Fixes: tag ] Link: https://patch.msgid.link/20260925-acpica-pcc-field-leak-v2-1-e37008e715af@debian.org Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/acpica/dsfield.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/acpica/dsfield.c b/drivers/acpi/acpica/dsfield.c index df132c9089c76..a522392ae2ddb 100644 --- a/drivers/acpi/acpica/dsfield.c +++ b/drivers/acpi/acpica/dsfield.c @@ -522,7 +522,8 @@ acpi_ds_create_field(union acpi_parse_object *op, } if (info.region_node->object->region.space_id == - ACPI_ADR_SPACE_PLATFORM_COMM) { + ACPI_ADR_SPACE_PLATFORM_COMM && + !region_node->object->field.internal_pcc_buffer) { region_node->object->field.internal_pcc_buffer = ACPI_ALLOCATE_ZEROED(info.region_node->object->region. length); -- 2.53.0