From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795044993; b=FWlghxfvQmrn8xIrQq2qw8/j9PIulkVFz2l8YxHNABScKWS3cEfjzP207uOeEznpSpmM N+ycJarKTkzNxfhkhAhK6TbRIMhTqJY4h/AOsjEMEu+xYJ6xhRiXAcH8h63x4g7PDBRWp prXMOs9Ew95wtwnQC95SJX+MpGtqqLm0jmMhnjc+9H3cyesqjJERB/EdKCYvymb3kETSK oEkxtwKVzjwNuSBUZFo1SQIpIZaDM46zZqfATTe85r/ZAu0dn1aA5NI/S2iEW2bsvQV5r 5Rydv8aeg/W4dQYQ8FNvoBxtsPT7K44n51d5sJSs7Af4IPO3CQiYDF6dX/yIxpVywlw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795044993; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=AwXdeCzrCzae7MMk2IA1wnADKbrOZI0RvQ92SpPrwUs=; b=SDBeh5Q4wzyoILsojrz6aimAeipfPzFj2/HIFOKu1+Qxjh64u9vm77LoaRWXrS2ThEOP 4aQu02vbFOLUgj9xNc7sTsYMboiSRU72QiHdnvh252LVK7KlASbUB5z1ItH4OJWxPGrB3 wK92QTRoNZJQEJzAc03ataPpXxzNpqLlHxZ4DzUHuMFkc5yS5h9IzCdGytCZxhfQ0ZuXm XT4tTzAFERBe0f4oN5fhFbhUSiofmG5Ql6wEG8tO+u7iDC0syV5nBt+fz5RrfeKr9Ryqa 1mWd1dfXAwiCIiAWGV7XPvdQqpeY3d7E10EVL0p3HteoKx+kBPFaktDuaarcP8sU0dQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=higxoQOH; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C1E0606A32A; Wed, 18 Nov 2026 23:36:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=higxoQOH Received: by smtp.kernel.org (Postfix) with ESMTPSA id F31CA1F000C6; Wed, 18 Nov 2026 23:36:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795044993; bh=AwXdeCzrCzae7MMk2IA1wnADKbrOZI0RvQ92SpPrwUs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=higxoQOHFpZCJl0m8Yx8EF3hg6oXs1MeToJrmkm7K26xFbSjYcJSa5Q3L0VHDA6Qe A357plPhsqoifXJvxl13fgAZqGNh/Va36qjjCQw1zp1GOE3EZcUKc3nxtxUl3Z094C ZMw1u5GB449WiYtGKsHL4kz4UoZdJAxnYEfhiHTQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Karl Mehltretter , Herbert Xu , Sasha Levin Subject: [PATCH 6.1 0764/2857] lib/842: reject output overflows from index and short data Date: Wed, 18 Nov 2026 15:29:58 +0100 Message-ID: <20261118150229.067620779@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150201.293410965@linuxfoundation.org> References: <20261118150201.293410965@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Karl Mehltretter [ Upstream commit 38ed7182f3491ec1449ff246551e11ad82adba45 ] The output length passed to sw842_decompress() is the caller's buffer capacity. Indexed copies write 2, 4 or 8 bytes and short-data templates write up to 7, but neither checks that capacity before writing and decrementing p->olen. Overwriting an undersized destination then underflows p->olen, which is unsigned, so every later bounds check in the stream passes. Subsequent operations keep writing past the destination, and a matching CRC lets sw842_decompress() return success with an output length larger than the capacity the caller supplied. This is reachable through zram's compressed writeback path. With 842 selected, targeted corruption of the compressed data on its backing device made a KASAN kernel report vmalloc-out-of-bounds writes in __do_index() and sw842_decompress() when zram read the page back. Check the remaining output before both operations and return -ENOSPC, matching the other output-producing templates. Fixes: 2da572c959dd ("lib: add software 842 compression/decompression") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Karl Mehltretter Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- lib/842/842_decompress.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/842/842_decompress.c b/lib/842/842_decompress.c index 582085ef8b49c..87d1e0f8a4926 100644 --- a/lib/842/842_decompress.c +++ b/lib/842/842_decompress.c @@ -165,6 +165,9 @@ static int __do_index(struct sw842_param *p, u8 size, u8 bits, u64 fsize) u64 index, offset, total = round_down(p->out - p->ostart, 8); int ret; + if (size > p->olen) + return -ENOSPC; + ret = next_bits(p, &index, bits); if (ret) return ret; @@ -344,6 +347,8 @@ int sw842_decompress(const u8 *in, unsigned int ilen, if (!bytes || bytes > SHORT_DATA_BITS_MAX) return -EINVAL; + if (bytes > p.olen) + return -ENOSPC; while (bytes-- > 0) { ret = next_bits(&p, &tmp, 8); -- 2.53.0