From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795045205; b=LZO0r+cC5P0ilwGeGb40kNowV3jyYzz7sXJMYbZqqn4lFuEZCK2NEQK0IpETr4V3OSq7 99yrgH21zH/tAUV0ZCtc9rZ1c3c+pcrdZVlTy//GTcUtMalSK/3SknoaJ/CwVaFjlu7y3 jDdLQWkQ3x7w1gLKw//NWm5KB4SldcmSvGbPA9JJZF6tBcMKkrwTRI18TwBjCKNQL7Wa/ XRTdfHFWxaqaBI5pfq5Dq3SuJ1ijEad6OiqkMp42wg3pdX5pbtpYoKHs4PzwGSvbvyJER DiFpRF7ASKh6lgcZve2QvqAp+AzLoKH6S6sgY87oYuUJimouQ97OFYBt2HmcETiZu3A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795045205; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=sIb7UwVmg/9jdrDIq1NK/Yr3lRgynmVJJuNeZfRDHkc=; b=0ss+QHfPfgR+KRRyeelPtnu7GSJve5ya7t6waZalCCWvik5/df/tK0Q5a9/ddhodjOAW oVfIUElvYRCkD2T2bOObNIddgcmSlUx44WejZzTPFdy7TIYThGfLDXCHvvtyUhlCQGUiF iiDusxjFbFX+WeKddil/4Ff1OFoatzMVwNK/ibcb+Jg45tLAc+EmWmWXyRpd0mTSODtpx IZ3BkMm3vl36/dNEfPDi16AOGBAUvcjpfdMkfL1Wm6rW3pq5+mRif6p7x9IecM8L1On18 RwFKcxStmoSGWWyov2VdlSSCF14TSnbZmkqHeuftfX3egLnpsGWtN2yzWzQ5TWfD4mQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=yUplUBGv; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DF98606A320; Wed, 18 Nov 2026 23:40:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=yUplUBGv Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AF801F000C4; Wed, 18 Nov 2026 23:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795045205; bh=sIb7UwVmg/9jdrDIq1NK/Yr3lRgynmVJJuNeZfRDHkc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=yUplUBGv7WCa/IH7Y/1kYR4PMk9B+VkMBl7GLJhzRPYykqJTCc90D0HfgzS3a3Mn6 7Itk7QZw0Mh+koaa8VkQ1LgIPU/9y/P/uEzVB7HiL7MSUKbKILeG1Dr8V0rpm8rs9z USDjBNpe1Ywhas7w+HQw0l1A8SsdCVAXXajlWeRU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hui Peng , Damien Le Moal , Niklas Cassel , Sasha Levin Subject: [PATCH 6.1 0789/2857] ata: libata-scsi: abort multi-sector pass-through commands when multi_count is 0 Date: Wed, 18 Nov 2026 15:30:23 +0100 Message-ID: <20261118150229.976220534@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150201.293410965@linuxfoundation.org> References: <20261118150201.293410965@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hui Peng [ Upstream commit 3bab8c7e0c6ba187a47163a1f71477213a278c48 ] When an ATA_12, ATA_16, or ATA_32 pass-through command with a multi-sector PIO command opcode (ATA_CMD_READ_MULTI, ATA_CMD_WRITE_MULTI, ATA_CMD_READ_MULTI_EXT, ATA_CMD_WRITE_MULTI_EXT, or ATA_CMD_WRITE_MULTI_FUA_EXT) is submitted via SG_IO on a device where multiple-sector mode is not configured (dev->multi_count == 0), ata_scsi_pass_thru() currently logs a warning and still dispatches the taskfile. When the DRQ interrupt fires, ata_pio_sectors() triggers WARN_ON_ONCE(qc->dev->multi_count == 0) and computes nsect = min((qc->nbytes - qc->curbytes) / qc->sect_size, 0) = 0, failing to transfer any sectors: ata1.00: invalid multi_count 1 ignored WARNING: drivers/ata/libata-sff.c:666 at ata_pio_sectors+0x27d/0x300 Call Trace: ata_sff_hsm_move+0x211/0x22e0 __ata_sff_port_intr+0x1c8/0x520 ata_bmdma_port_intr+0xa1/0x5b0 ata_bmdma_interrupt+0x1f5/0x550 Per ACS-3 section 7.12.7.21, if IDENTIFY DEVICE word 59 bit 8 is cleared to zero (multi_count == 0) and a READ MULTIPLE or WRITE MULTIPLE command is received without a preceding successful SET MULTIPLE MODE command, the device returns command aborted (ABRT). Per the SAT specification, an ABRT error translates to the ABORTED COMMAND sense key with NO ADDITIONAL SENSE INFORMATION (0x00, 0x00). Fail multi-sector taskfile commands in ata_scsi_pass_thru() with ata_scsi_set_sense(dev, scmd, ABORTED_COMMAND, 0, 0) when dev->multi_count == 0. Fixes: 1dce589c38c3 ("libata passthru: support PIO multi commands") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Hui Peng Reviewed-by: Damien Le Moal Link: https://lore.kernel.org/r/20260921032556.1160734-1-benquike@gmail.com Signed-off-by: Niklas Cassel Signed-off-by: Sasha Levin --- drivers/ata/libata-scsi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 3a495116ff0c1..ed15d11cf9fcd 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -3178,6 +3178,11 @@ static unsigned int ata_scsi_pass_thru(struct ata_queued_cmd *qc) if (is_multi_taskfile(tf)) { unsigned int multi_count = 1 << (cdb[1] >> 5); + if (!dev->multi_count) { + ata_scsi_set_sense(dev, scmd, ABORTED_COMMAND, 0, 0); + return 1; + } + /* compare the passed through multi_count * with the cached multi_count of libata */ -- 2.53.0