From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795045586; b=UdMo7fOUFuomda/4pZCM6eWcoCEHZ0EZ2PBJYhG2ThiC+PQAW/2yPCgHAokBPXUq/MoJ ev+J/gGLYJ0rzgtf/YLzgAHFhQh8Dr0XRPcGK2DYbIn/R6ooPkEyxmpr7QK7CQvtsKWYH HEVaqjSP5nmV0kfBESZgfL0cRRbYzR5i50SOpvOSH50hxixxCPmSr0kY6oiAC0/AnYg9T 0dbNmM/C9rk1k1rcwSHpJ9lKrhdxWNVimtn6EluEuubtnEWK1YEmgnkh/UOSmgBHIG6TZ 5Tg65ZVeykApPVw4ODKRhS7zqBvYpvq3yczfKm/sAhLj1p8NoY9IwBNHMfINYT0crCQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795045586; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=Rrl4hHqGZ1x7jww71Ipo35xqtJfAPWvfq2JV65Butgk=; b=irwSc8sM0/YsyXzcZbhb3E0XxYr7WDvtFQ1JRfAi8AUTu/nj+2AXFIR6PrCGAsiFMfZT /xFq5+pyS7pzjlYvVHGHAptczDLIn0J9UKDlOpli3c/WDYj5bDCkhkPZwm633ADB6/gC4 uhuAonf4E4LXw6G6Z3XMypruc1CeJ3HmpSs07Viwe9mtWAvEOKlVMEKXWn8/uwavZeVr4 GfS2moBbcDnL8NIUhj7iCEDrb+yk7han4iir2FXF0DucICs+SYInebgdLE0SIvdSjHBW4 ufvKa24rfE2dgj/XZouReDF410qqlTX7L57Wtk51S5j9hBf/3PJR/ZYKuyoplqumOGw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=y0mQR7ov; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 313BF606A32C; Wed, 18 Nov 2026 23:46:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=y0mQR7ov Received: by smtp.kernel.org (Postfix) with ESMTPSA id 900D01F000C4; Wed, 18 Nov 2026 23:46:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795045586; bh=Rrl4hHqGZ1x7jww71Ipo35xqtJfAPWvfq2JV65Butgk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=y0mQR7ovBkCwLNvSQuhwhv9kj1TIcRnctCIhHNF01Ciz9dcOVxXEaBeFU1X549uQJ yuMKG0xx/nHg+eQkaYHzfjygQYrDuJ/NGLVkLlh64vJy7PST5sXKB7aiMUAzYDPBnn 3X6mn84sYOLPATdHWPzpC/c27ifuFjBpH5GyvfoI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, sungbyeongchan , Giovanni Vignone , Robert van Eijk , Paolo Gentry , Shubham Antil , Allison Henderson , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.1 0975/2857] RDS/IB: validate receive fragment completions Date: Wed, 18 Nov 2026 15:33:29 +0100 Message-ID: <20261118150236.711118643@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150201.293410965@linuxfoundation.org> References: <20261118150201.293410965@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shubham Antil [ Upstream commit 65cf6863606b0507a7c3bd1711317e4f5d6b8b7e ] rds_ib_process_recv() accounts every receive fragment as contributing min(i_recv_data_rem, RDS_FRAG_SIZE) bytes, regardless of the completion length. When a completion is shorter than the header-declared amount, receive accounting can advance beyond the payload supplied by the completion. Only an IB_WC_RECV completion has the buffer layout expected by this receive path. Other successful completion opcodes must not be interpreted as ordinary receive completions. Reject successful completions with any other opcode before processing their length. For ordinary receive completions, require enough payload to cover the amount accounted to the fragment before linking its page into the incoming message. This is compatible with the current transmit paths. MSG_ZEROCOPY is restricted to RDS/TCP, while RDS/IB copied and page-vector messages use full-sized non-final scatterlist entries. Found during an LLM-assisted source audit and validated under KMSAN with a malformed short receive completion. Reported-by: sungbyeongchan Closes: https://lore.kernel.org/netdev/20261006205204.1322102-1-tjdqudcks0424@naver.com/ Reported-by: Giovanni Vignone Link: https://lore.kernel.org/netdev/8a6ee1d5336ae65b8ffdc8c40a1135657207e204.camel@kernel.org/ Reported-by: Robert van Eijk Link: https://lore.kernel.org/netdev/8a6ee1d5336ae65b8ffdc8c40a1135657207e204.camel@kernel.org/ Reported-by: Paolo Gentry Link: https://lore.kernel.org/netdev/8a6ee1d5336ae65b8ffdc8c40a1135657207e204.camel@kernel.org/ Fixes: 1e23b3ee0e94 ("RDS/IB: Receive datagrams via IB") Cc: stable@vger.kernel.org Signed-off-by: Shubham Antil Reviewed-by: Allison Henderson Link: https://patch.msgid.link/20261013025729.40815-1-shubham@octane.security Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/rds/ib_recv.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c index 89aef2fffc1ed..6f8c55e49ea21 100644 --- a/net/rds/ib_recv.c +++ b/net/rds/ib_recv.c @@ -948,6 +948,12 @@ static void rds_ib_process_recv(struct rds_connection *conn, } } + if (data_len < min_t(u32, ic->i_recv_data_rem, RDS_FRAG_SIZE)) { + rds_ib_conn_error(conn, + "fragment shorter than header-declared length; forcing reconnect\n"); + goto done; + } + list_add_tail(&recv->r_frag->f_item, &ibinc->ii_frags); recv->r_frag = NULL; @@ -1003,7 +1009,12 @@ void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic, * event is processed. */ if (wc->status == IB_WC_SUCCESS) { - rds_ib_process_recv(conn, recv, wc->byte_len, state); + if (wc->opcode != IB_WC_RECV) + rds_ib_conn_error(conn, + "recv completion had unexpected opcode %u, disconnecting and reconnecting\n", + wc->opcode); + else + rds_ib_process_recv(conn, recv, wc->byte_len, state); } else { /* We expect errors as the qp is drained during shutdown */ if (rds_conn_up(conn) || rds_conn_connecting(conn)) -- 2.53.0