From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795016084; b=NsUwOLIo7wZ3RsTr49ajEjoZ1/xGnRyXiyZHYGNg95S5eM1WDJAfrZ7/gFp5mspqqWOM BnxNIaROl5E+N1Ni8+cPjypvWKUoWwxv10n7MynEI/aJ8ydQP5jaqBO2k0zLlqLfplqUU XPfZlry0K6JQRUELFxvySphu/+Dno41GfHxjPXx6bkMEaPMA9dPSyCqxVxwZwErgHcrxd eSllSYekH20sTob5hu+Cd/07b/WXwt2/D2jb/A+GQpZi8XYpsC62aWI0cM+eNvdHeldNs Sc+AzBjXhwN1J0EWlWedSDzBiTsocl6nmf2tyz/HaE7ur92kMkQT9UvzoozEI1RQy3Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795016084; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=iTQB5IH89/5LKTdg4m/tav1QSpJwZouU+sDhekmnr48=; b=rZyhPLCdKxTV3p2dcVybLINqfRCP8Ra3UPSla6n76fvPwAwasmZIB5kqlJw5on5d4IJb XlrouUFTixJeJS0HbFyicxwQdENu4cDXjDWhKWyPdv2qjrn8cyi5dmK5kPRG2cLnn1PFj 9vOoHVzanJY6SX4m8fcv/po9tULnEk4ZT42gUXuRqeUIVLy8PGcSfKdfMPPz9W9LZrRtj lYXNs+JQMEhkiDE2ek5JQRULRRElQla595ES9VFa4neNbAg+K87KrA632hY1C1C+McDEr Faz4Zli99A3XFV4Cytv4SIhtXUtTO3OqKnjHsiVqvn1nOdIMdFSXXIrkWI0CY2tyb3A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="Rd2H4/MI"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3409B606A333; Wed, 18 Nov 2026 15:34:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Rd2H4/MI Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DCDC1F000C4; Wed, 18 Nov 2026 15:34:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795016084; bh=iTQB5IH89/5LKTdg4m/tav1QSpJwZouU+sDhekmnr48=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Rd2H4/MI8DGmoSz6rSFaYLKNBbijRSnr/2nbGUl7MQji4ngsCyA7B71qDyhxYj8sY 2w03ZPyxvJqLKdPLGSdmSOLJEhbCNpSW6nsm+TTa9DRNM/CxszeA+5tqyU565QCS7B GNXr9D+rF3iLY228HVwmFSisB2WWxIa6bP8s0IKU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 7.3 0403/2651] ACPI: glue: Carry out companion lookup under bus_type_sem Date: Wed, 18 Nov 2026 15:27:23 +0100 Message-ID: <20261118150302.345819568@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150247.972732815@linuxfoundation.org> References: <20261118150247.972732815@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Rafael J. Wysocki [ Upstream commit c94619c8a5b5d3b980433d247ac87a2d1c827cb6 ] When acpi_device_notify() looks up an ACPI companion for the given device, it invokes callbacks from struct acpi_bus_type() without synchronization which may lead to a use-after-free if the driver module containing those callbacks is unloaded at the same time. Address this by holding bus_type_sem throughout the entire ACPI companion lookup and the execution of the .setup() callback in struct acpi_bus_type (if present) instead of dropping the semaphore (prematurely) after finding a matching struct acpi_bus_type. For this purpose, rename acpi_get_bus_type() to acpi_companion_lookup(), make it return a struct acpi_device pointer, and move the relevant code from acpi_device_notify() to it. Also notice that the only case in which the .bind() callback from an ACPI scan handler may need to be invoked is when the given device is a platform one, so adjust acpi_device_notify() accordingly and drop the "done" label that is not used any more from it. Fixes: 2ef5236660b6 ("ACPI: glue: Look for ACPI bus type only if ACPI companion is not known") Signed-off-by: Rafael J. Wysocki Link: https://patch.msgid.link/3089807.e9J7NaK4W3@rafael.j.wysocki Signed-off-by: Sasha Levin --- drivers/acpi/glue.c | 61 +++++++++++++++++++++------------------------ 1 file changed, 29 insertions(+), 32 deletions(-) diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c index a47cccc4efd3f..40e6513a9942b 100644 --- a/drivers/acpi/glue.c +++ b/drivers/acpi/glue.c @@ -59,19 +59,34 @@ int unregister_acpi_bus_type(struct acpi_bus_type *type) } EXPORT_SYMBOL_GPL(unregister_acpi_bus_type); -static struct acpi_bus_type *acpi_get_bus_type(struct device *dev) +static struct acpi_device *acpi_companion_lookup(struct device *dev) { - struct acpi_bus_type *tmp, *ret = NULL; + struct acpi_bus_type *type; - down_read(&bus_type_sem); - list_for_each_entry(tmp, &bus_type_list, list) { - if (tmp->match(dev)) { - ret = tmp; - break; + guard(rwsem_read)(&bus_type_sem); + + list_for_each_entry(type, &bus_type_list, list) { + struct acpi_device *adev; + + if (!type->match(dev)) + continue; + + adev = type->find_companion(dev); + if (!adev) { + dev_dbg(dev, "ACPI companion not found\n"); + return NULL; } + if (acpi_bind_one(dev, adev)) { + dev_dbg(dev, "Binding to ACPI companion failed\n"); + return NULL; + } + if (type->setup) + type->setup(dev); + + return adev; } - up_read(&bus_type_sem); - return ret; + + return NULL; } #define FIND_CHILD_MIN_SCORE 1 @@ -360,40 +375,22 @@ void acpi_device_notify(struct device *dev) ret = acpi_bind_one(dev, NULL); if (ret) { - struct acpi_bus_type *type = acpi_get_bus_type(dev); - - if (!type) + adev = acpi_companion_lookup(dev); + if (!adev) return; - - adev = type->find_companion(dev); - if (!adev) { - dev_dbg(dev, "ACPI companion not found\n"); - return; - } - ret = acpi_bind_one(dev, adev); - if (ret) { - dev_dbg(dev, "Binding to ACPI companion failed\n"); - return; - } - if (type->setup) { - type->setup(dev); - goto done; - } } else { adev = ACPI_COMPANION(dev); if (dev_is_pci(dev)) { pci_acpi_setup(dev, adev); - goto done; } else if (dev_is_platform(dev)) { acpi_configure_pmsi_domain(dev); + + if (adev->handler && adev->handler->bind) + adev->handler->bind(dev); } } - if (adev->handler && adev->handler->bind) - adev->handler->bind(dev); - -done: dev_dbg(dev, "Bound to ACPI device %s\n", acpi_dev_name(adev)); } -- 2.53.0