From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795016217; b=hvSD4oVhNYvNB9cdp3w6K/UgPZFJwt9wE57GcFm/a5E77iJmDjt+LFCVWQ7uA9cKXqO2 +lDscNx88m5InNISY87iYLNn5wXiDOz7dCm7lEHDKi8IdilLtwhvp45qmOlxJTAp3x/cl T49wIXEuHI/dD5ezWX0RWE6GB0cAeMPqDIdlbcOQ3Dt+cnbJWfmU1gi+uDhzdXcBZ+nMs FTxQ5czunxPpinjGGkKrwhjtgm5tDp9JAU8ddb6vtfhJ/DXXc3KFSIFeVI+wsC6LGWFuu Qw0qZFH8M6ZcTdrJNCcmsvwyKkzSMaTijsVtQ5w3LmVPnLvb6KRday+8Ngx6GPFlgbg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795016217; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=7yqBvE9CLhVfPHM9ZaEbtldTykPL+J0hxrmvrPubVNA=; b=Dbkhchi0pq0hGWKByLKe3Il3piNH+/ZEhFh7MSDNFeWCUrMcTo4LrezKLH2aZbK5gIkW OQGOlPN8Y4eup3Uf1a7RO8SEIRd2WPVuEOkihbGl3Mm07Rr6XkISeEMbcE3ZGbhlbd1yr cK2lmLKO+zjw02tky6O9k7vnrhdpKpLzMj6qflvqi6LpBencMWrgaPoTwNSxnylHS/hn6 jsiRodOCcxv3VvrYK9sCz3ecyucG0IL+Ejr4X9XEXqaPNqKJZgOSAMIeB7YKv6XOkQfD5 rlOi/DZeQdoWg4RVp6lL8SrGl/hfZMSF6bVMNk4cH95Jmy6+4sRk2OcC47Bl0tv+zrw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b="bJQC/X7X"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 020C6606A31C; Wed, 18 Nov 2026 15:36:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=bJQC/X7X Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BBFA1F000C4; Wed, 18 Nov 2026 15:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795016216; bh=7yqBvE9CLhVfPHM9ZaEbtldTykPL+J0hxrmvrPubVNA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bJQC/X7XU5uGbV8porh8P82B0AmKqsbXIsmHpOLjIhgHPMirSCQfU9EHKHR8MuedS G4fcmg8SLVAkjPcblgeloDxK2wVpIbDmDF/sait2hndjkNsfOWh82X2/k3nUMkiU7/ zKjQO1M+IXNZKIkZ+5QIxoziy0d9DdnAK84cuAzQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xiang Mei , Weiming Shi , Konstantin Komarov , Sasha Levin Subject: [PATCH 7.3 0450/2651] fs/ntfs3: take run_lock when freeing offs_folio in ni_decompress_file Date: Wed, 18 Nov 2026 15:28:10 +0100 Message-ID: <20261118150304.011786392@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150247.972732815@linuxfoundation.org> References: <20261118150247.972732815@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Weiming Shi [ Upstream commit ad39d8d90fa0fd99b2714d4c84c6f4e1c399f1f4 ] attr_wof_frame_info() allocates, caches and dereferences ni->file.offs_folio under down_write(&ni->file.run_lock). ni_decompress_file() frees the same folio with folio_put() without taking run_lock. When a WOF externally-compressed file is opened for write, ni_decompress_file() can drop the last reference while a concurrent O_RDONLY reader is dereferencing the folio in attr_wof_frame_info(), leading to a use-after-free: BUG: KASAN: use-after-free in attr_wof_frame_info (fs/ntfs3/attrib.c:1619) Read of size 4 at addr ffff8880120c9000 by task exploit Call Trace: attr_wof_frame_info (fs/ntfs3/attrib.c:1619) ni_read_frame (fs/ntfs3/frecord.c:2421) ni_read_folio_cmpr (fs/ntfs3/frecord.c:1916) ntfs_read_folio (fs/ntfs3/inode.c:648) read_pages (mm/readahead.c:181) page_cache_ra_unbounded (mm/readahead.c:292) force_page_cache_ra (mm/readahead.c:364) page_cache_sync_ra (mm/readahead.c:573) filemap_get_pages (mm/filemap.c:2688) filemap_read (mm/filemap.c:2806) generic_file_read_iter (mm/filemap.c:2994) ntfs_file_read_iter (fs/ntfs3/file.c:842) vfs_read (fs/read_write.c:574) __x64_sys_pread64 (fs/read_write.c:773) Take run_lock around the folio_put(), as is done for every other access to ni->file.offs_folio. Fixes: 4342306f0f0d ("fs/ntfs3: Add file operations and implementation") Reported-by: Xiang Mei Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Weiming Shi Signed-off-by: Konstantin Komarov Signed-off-by: Sasha Levin --- fs/ntfs3/frecord.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c index bead01a953f3f..36bdb1983fef2 100644 --- a/fs/ntfs3/frecord.c +++ b/fs/ntfs3/frecord.c @@ -2190,10 +2190,13 @@ int ni_decompress_file(struct ntfs_inode *ni) /* Clear cached flag. */ ni->ni_flags &= ~NI_FLAG_COMPRESSED_MASK; + /* offs_folio is accessed under run_lock in attr_wof_frame_info(). */ + down_write(&ni->file.run_lock); if (ni->file.offs_folio) { folio_put(ni->file.offs_folio); ni->file.offs_folio = NULL; } + up_write(&ni->file.run_lock); mapping->a_ops = &ntfs_aops; out: -- 2.53.0