From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795016292; b=CuiU47wEUWMnFsKBqNs/NQyxbDpb941mVcqF+vtUEbW8aqjin32mijQyTIJxiqziyY72 2AiX+6JrJF83YubTtFSLibzHVPMXWlkbTCPOdNagESehIdkoP8DtsLRxUtQyPipyaNqIa 46EiU5Nk7xAYsJ2XCQjYd/4VrbhBf78cRIjVvxDwqhq2z3TYByFqdhM486qOXCvxPfKkn H9BvG3ksFElarYJ2VkGqHJOkdHCMxXnXL+66p/yraIqCMJpCeZeJcicO+ZF/aN935cRrN IK9K5zBIXDAylILv3L2DEgDJICDZpsEBQ8EfZuyviDzvs5nesFVFBzAL2DXxi8kGw9A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795016292; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=tVXgBTPMs6kBHo1FPxiX+OTnlUI4U2Zr8iW+9pHKzwY=; b=hhbyhZ20W+ZgJwuTwNuouvZxhKTdxefcalbjzZWRjKSycaxsMx8r3OPPMsiAOevlXdZ8 P1XYf5WnC0Vak2w4PnX/XSfz9Ozbf3PKlzeBweHbceQyOJQFQbdRV8PRSmFAH/VHG8SaE L70dIfsvZyKoqWmTcq5EdVzmqeOD7l4U0TjSXcBZpyOXOzwu/cOmA/SoYQZP9yDjsvk98 RE1molaIWuE2eqBKXET6q/bJzNZlbjnnb8xKABxIG66dm6FiAkOcZXzU7hDxTdgE2hOHo OSA6cEOXhgcXJCY6Dwu3vrwcBJ1PlK1Ewx9YjA8PqcVqhzo4G+XJ0PHnVUEfHz7DPNw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=LwK0Hukz; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8277160A261F; Wed, 18 Nov 2026 15:38:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=LwK0Hukz Received: by smtp.kernel.org (Postfix) with ESMTPSA id D24791F000C5; Wed, 18 Nov 2026 15:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795016292; bh=tVXgBTPMs6kBHo1FPxiX+OTnlUI4U2Zr8iW+9pHKzwY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=LwK0Hukz4Jy1GZcGg5dUTkg+CJrhfvtsWsHjjzhSTNRkiP4IARspPgiVFBI64gmpf 9txv7ckoM1G6hESpxZBVKOLx/X+UKdUqQnBvhNSmT28ffEvd4roCR1RMTsMWaq5MfV K/zYsx3DKe6SS3IPLo0cwSKDe4WpnmFO9OxoEX/Y= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gregory CLEMENT , Manivannan Sadhasivam , Neil Armstrong , Vinod Koul , Sasha Levin Subject: [PATCH 7.3 0470/2651] phy: cadence: Sierra: Do not modify register when getting parent clock Date: Wed, 18 Nov 2026 15:28:30 +0100 Message-ID: <20261118150304.713371073@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150247.972732815@linuxfoundation.org> References: <20261118150247.972732815@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gregory CLEMENT [ Upstream commit 955e68eb3067842067b7b5395a3f8c278428802a ] The get_parent() callback for the PLL_CMNLC1 clock was incorrectly writing to the register while determining the parent clock index. This unintended register access forces the PHY back into training mode. If the PHY is already configured, this unexpected change prevents it from exiting training mode. Remove the register write operation to ensure the PHY remains stable during the get_parent() callback. Fixes: da08aab940092 ("phy: cadence: Sierra: Fix to get correct parent for mux clocks") Signed-off-by: Gregory CLEMENT Reviewed-by: Manivannan Sadhasivam Reviewed-by: Neil Armstrong Link: https://patch.msgid.link/20260306-fix_sierra_get_parent-v2-1-cafe89ee5382@bootlin.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/phy/cadence/phy-cadence-sierra.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c index 92ab1a31646ae..dbeda7f01cbb2 100644 --- a/drivers/phy/cadence/phy-cadence-sierra.c +++ b/drivers/phy/cadence/phy-cadence-sierra.c @@ -698,23 +698,16 @@ static const struct phy_ops noop_ops = { static u8 cdns_sierra_pll_mux_get_parent(struct clk_hw *hw) { struct cdns_sierra_pll_mux *mux = to_cdns_sierra_pll_mux(hw); - struct regmap_field *plllc1en_field = mux->plllc1en_field; - struct regmap_field *termen_field = mux->termen_field; struct regmap_field *field = mux->pfdclk_sel_preg; unsigned int val; int index; regmap_field_read(field, &val); - if (strstr(clk_hw_get_name(hw), clk_names[CDNS_SIERRA_PLL_CMNLC1])) { + if (strstr(clk_hw_get_name(hw), clk_names[CDNS_SIERRA_PLL_CMNLC1])) index = clk_mux_val_to_index(hw, cdns_sierra_pll_mux_table[CMN_PLLLC1], 0, val); - if (index == 1) { - regmap_field_write(plllc1en_field, 1); - regmap_field_write(termen_field, 1); - } - } else { + else index = clk_mux_val_to_index(hw, cdns_sierra_pll_mux_table[CMN_PLLLC], 0, val); - } return index; } -- 2.53.0