From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795016359; b=mck6zrGZ07Dej2ea/8WJdT0ILQzrrKPwBEIlE3boEOiyQ69BLjlT9zAttdtlyDm13x7Y 4iLMMf0ucwJf4PnGEoLAzpBhTZUrtaPc0l3Nq3G8/KV8S01BCrG3s3TdaRaWTi+g9CaLi fxNbuxJlyJsCD3U8J1IBpqUTvFC07izn5wPEImUwg1NwgvwsPISKVbJ40KktDoZKcjpPN DQNejkdxOiY/FE8SfJP25l+JRYsS6rFnygh99rq+z0eAAenduAztCRZDYQE7VsquEk1oD eQE3e0qM1qzozysYSQ78tUXkcZmUQI6h0Qa+NdjGjiwOj+tViKY76zNaMDInvxNnz+Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795016359; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=XZ2uC2tYpGpZgOJ5cFfB+M3vEJcl7YWoORaxStC4a94=; b=ih+AN+KDUMn3EOLHkIBLSHH8Vm8M5/G5pWIueJFxWMadgmpKFPNJ3z0w5FAFkaDSqMox ujTE3UplF/rvMMLbwsF8EUng/xCbE/1EDObEFMyyAQ58ejhQPToU4A189kWrRfz9ZYO3i v9epTSAcCkOTw29SUGCLzTvZ3lX4UWwC/rldJnF8S14258CCHUSpWrwWuryslsWwkVgya DVpS47QjAEj18MMiwox3jMNLe3NP3cyNJi1fO0QLBepl3LqSlmW82YvNXXI3Bvc3r31t4 gulsfG2b4W8vhCJy7R0Sy+1YweaXTl2MvB8c9+fzsAN/hthId/idTTqL6Ks9decCOpg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=n1m+yeBD; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A8FB60A260A; Wed, 18 Nov 2026 15:39:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=n1m+yeBD Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDEC71F000C5; Wed, 18 Nov 2026 15:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795016359; bh=XZ2uC2tYpGpZgOJ5cFfB+M3vEJcl7YWoORaxStC4a94=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=n1m+yeBD142RHg/DCXJnwHQmJvACHlXLPg6fRWx+igrO53qOXCS/ReKPJv2wGTpCd f4XZpc4k0H4L3/kNpK6dssiF3cwNbZ6cuDLLqSpfJTsudo6nO76gE+2klLYdehYSpN B58c0GJHLgZBK3pNP1uGqz/uuufpbQaOXD9/M/98= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alison Schofield , Li Ming , Dave Jiang , Sasha Levin Subject: [PATCH 7.3 0500/2651] cxl/hdm: Make switch decoder target parsing endian-safe Date: Wed, 18 Nov 2026 15:29:00 +0100 Message-ID: <20261118150305.767210379@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150247.972732815@linuxfoundation.org> References: <20261118150247.972732815@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alison Schofield [ Upstream commit 3f846646b3d3b5699139e686e1107d231a725860 ] Switch decoder target IDs are stored one per byte, starting with target 0 in the least significant byte. The current code accesses those bytes in memory order, which only matches register order on little-endian hosts. On big-endian hosts, the target IDs are reversed and the decoder is associated with the wrong downstream ports. Place the register values in a byte array in little-endian order and index the target IDs from there, so the target mapping is independent of host endianness. Fixes: d17d0540a0db ("cxl/core/hdm: Add CXL standard decoder enumeration to the core") Signed-off-by: Alison Schofield Reviewed-by: Li Ming Link: https://patch.msgid.link/b0526825b3c3ffdb78837563e178d9aa27b6bbb8.1786143520.git.alison.schofield@intel.com Signed-off-by: Dave Jiang Signed-off-by: Sasha Levin --- drivers/cxl/core/hdm.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c index c394b3d54d362..fc22d515b6389 100644 --- a/drivers/cxl/core/hdm.c +++ b/drivers/cxl/core/hdm.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0-only /* Copyright(c) 2022 Intel Corporation. All rights reserved. */ #include +#include #include #include @@ -975,15 +976,12 @@ static int init_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld, u64 *dpa_base, struct cxl_endpoint_dvsec_info *info) { struct cxl_endpoint_decoder *cxled = NULL; + u8 target_id[CXL_HDM_DECODER0_TL_TARGETS]; u64 size, base, skip, dpa_size, lo, hi; bool committed; u32 remainder; int i, rc; u32 ctrl; - union { - u64 value; - unsigned char target_id[8]; - } target_list; if (should_emulate_decoders(info)) return cxl_setup_hdm_decoder_from_dvsec(port, cxld, dpa_base, @@ -1096,11 +1094,12 @@ static int init_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld, return -ENXIO; } - lo = readl(hdm + CXL_HDM_DECODER0_TL_LOW(which)); - hi = readl(hdm + CXL_HDM_DECODER0_TL_HIGH(which)); - target_list.value = (hi << 32) + lo; + put_unaligned_le32(readl(hdm + CXL_HDM_DECODER0_TL_LOW(which)), + &target_id[0]); + put_unaligned_le32(readl(hdm + CXL_HDM_DECODER0_TL_HIGH(which)), + &target_id[4]); for (i = 0; i < cxld->interleave_ways; i++) - cxld->target_map[i] = target_list.target_id[i]; + cxld->target_map[i] = target_id[i]; return 0; } -- 2.53.0