From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795016603; b=M9Jg4Uiw/pZC0ZJ51PELy6t1H2GW9rf7qBFn65USmAEk5uI8c87k9cJzYyHQ8ndsVcAv 0vuFYdBAohcW9q7WrSHAVat8Iyu54/ojhk3Qbld7LxctIlc8fBMz1PmuUkbsgGPoqiqkS bI5BMU457jVEuqdNFyzswKFcD6aaa4kxIdNncTsMz3fEdsIBweJdrTbMl7CNee7s5/fDU ajAmFFTJq/4cKR9RdLH8HwstRKcrqdg+0VBLF0A3vyBrXLQ5VAvYHqh6VreZtWEQ+Y0gp ybxE6y2WayIXpGzK5N5a43L1jCn0TfgWeNV3hB24RF3vv1kjCR05mWvKulCRoxDvd1A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795016603; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=yX24sAKCYSpMvcekcFisGApBwm7i8/1z0r6S7Ef0fvo=; b=2511Q/EomChs73XuEqGC8Ma011fe/HHJp+l4tnRgEHkMxWd+kq0nO03RoHRrEasf2Hmk 5bZF9O1/vi3gs7ahlrzkicCnqTC4qbItesILcwjKcWYLVUmUbi7CIY+3eVDBjGtyxwiYy +Hv4ZW/KKAuYNmK73MA3521P+EZypZ3jVOLyQLVRtoQ2trIqdfk0SHtAolK+yrzeBAyFH h8K/8uaTKb6ItaYKu7WitrY2nBP4y2+Qto64H0wqiQyH5EWA3u4r+MM6fJCHPPwoTV/B8 Df29ynI4SvAy0LrY5XFlGoLK/GQZynG3sT+xbEFiZovLnGbLL3nPqgoQiMX3mtsBnqw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ZXUyf4rx; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B71C0606A320; Wed, 18 Nov 2026 15:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=ZXUyf4rx Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10C0E1F000C6; Wed, 18 Nov 2026 15:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795016603; bh=yX24sAKCYSpMvcekcFisGApBwm7i8/1z0r6S7Ef0fvo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ZXUyf4rxONYqn8DK8AXGLdeRK21U+UFQ3vfg39rE0hh0J8g0Ptm/L1beDB3qp10Ai T0+wce+2ydagt80pYCRSmb6XL2FomfyykjOa12b8o6+HjJ2vAkgOHypEtTPJqgsBXN Urxl8jKThxqyo4jDXWZx/vGl3nhf06dXqSYQMACw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sashiko , Christian Loehle , Sumit Gupta , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 7.3 0587/2651] ACPI: CPPC: Validate the _CPC package header Date: Wed, 18 Nov 2026 15:30:27 +0100 Message-ID: <20261118150308.854926453@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150247.972732815@linuxfoundation.org> References: <20261118150247.972732815@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Christian Loehle [ Upstream commit fb345025f161d17fe7c8a6048c7e80e467fa8ddf ] The _CPC NumEntries field includes every package element, including NumEntries and Revision. acpi_cppc_processor_probe() nevertheless reads those first two elements before checking that they exist and trusts NumEntries when walking the remaining elements. Reject packages with fewer than two elements and NumEntries values which exceed the package count before accessing Revision or iterating over register descriptors. Although the specification defines NumEntries as the number of package elements, tolerate additional trailing elements because ignoring them is safe and avoids rejecting padded firmware. Revision is specified as a BYTE, but the parser assigns its 64-bit AML Integer to an unsigned int before validating it. Reject values above U8_MAX before conversion so, for example, 0x100000004 cannot truncate to revision 4. Fixes: 337aadff8e45 ("ACPI: Introduce CPU performance controls using CPPC") Reported-by: Sashiko Link: https://sashiko.dev/#/patchset/20260724134251.1632824-1-christian.loehle%40arm.com Link: https://sashiko.dev/#/patchset/20260808082644.1251332-1-christian.loehle%40arm.com Signed-off-by: Christian Loehle Tested-by: Sumit Gupta Link: https://patch.msgid.link/20260916162805.1039247-2-christian.loehle@arm.com Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/cppc_acpi.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c index 8aa0ce556863a..67dae96a3cd8c 100644 --- a/drivers/acpi/cppc_acpi.c +++ b/drivers/acpi/cppc_acpi.c @@ -804,6 +804,11 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr) } out_obj = (union acpi_object *) output.pointer; + if (out_obj->package.count < 2) { + pr_debug("Unexpected _CPC package count (%u) for CPU:%d\n", + out_obj->package.count, pr->id); + goto out_buf_free; + } cpc_ptr = kzalloc_obj(struct cpc_desc); if (!cpc_ptr) { @@ -814,12 +819,15 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr) /* First entry is NumEntries. */ cpc_obj = &out_obj->package.elements[0]; if (cpc_obj->type == ACPI_TYPE_INTEGER) { - num_ent = cpc_obj->integer.value; - if (num_ent <= 1) { - pr_debug("Unexpected _CPC NumEntries value (%d) for CPU:%d\n", - num_ent, pr->id); + if (cpc_obj->integer.value < 2 || + cpc_obj->integer.value > out_obj->package.count) { + pr_debug("Invalid _CPC NumEntries (%llu) for package count (%u) on CPU:%d\n", + cpc_obj->integer.value, out_obj->package.count, + pr->id); goto out_free; } + + num_ent = cpc_obj->integer.value; } else { pr_debug("Unexpected _CPC NumEntries entry type (%d) for CPU:%d\n", cpc_obj->type, pr->id); @@ -829,6 +837,12 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr) /* Second entry should be revision. */ cpc_obj = &out_obj->package.elements[1]; if (cpc_obj->type == ACPI_TYPE_INTEGER) { + if (cpc_obj->integer.value > U8_MAX) { + pr_debug("Invalid _CPC Revision (%llu) for CPU:%d\n", + cpc_obj->integer.value, pr->id); + ret = -EINVAL; + goto out_free; + } cpc_rev = cpc_obj->integer.value; } else { pr_debug("Unexpected _CPC Revision entry type (%d) for CPU:%d\n", -- 2.53.0