From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795016782; b=kQjsWtvSxSM+dm3SXIEsDD6X2zNbmn+TpMBC8sUhI4JMPtzdIjhIeaVyEc3KlDmVXVl5 yNj5U/AfGDSveGZjSNDVohq9B3YBs02NCMfxbt7caMm0wzDnX/zl8rTzUWEe5c1/5kmlT 7lK/5fxAankcI5fnF8X+WRhmHYgg4hQEH/kEU0CMvvq7chtCrjSQs30HueobW39/i8eWd KqC5vcbUrqgB8CNVp08GbKmwmz3nNfI53lqaQJv1EfspRprsUdgS434BM200crz/5zrzk sQwYkLn9jb+BfpJ03KZZ2VnuCSoM3xX+E+vVsiMtfVP4CuWFrV83S/UmqwZ7bnBq7GQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795016782; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=I8uDmT3ktqaXm4SSd9bvZ/jy1iJ0t+nHd+6EAOnhxLc=; b=TJ1vCy/yPqOC6mxv6nvePa6TlvvjjHuWDg62W7AkRsfHC0ExJTDWkTvj8UbAodkMuP2E PM4kIJZA1j8lms8S1QmAXUVszkVHr5LZRilAl11TnRXVYjecjibu/zpZ/yzlVWTuh19EH Hqkpe7cqmNkgToiYvnw8p74NBlaKrIFtTvYpQsHxYJ0sqNkr+qwA09dLRwwfGQq9dAXlE pX01vEOx7J/b5sDo0yfm4dYJ0+jbUU75VRrKQ1rk4XZ07mmZ8v6aIVFwV7lX+Js4tVTSl lz7iaGKNQo6eoV1vyukNRJXXVx04ZTxoQenj4JgKB7rTDxN3lWm+UiwMr1efkDRRVUw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=cuvIM3v4; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A568606A31C; Wed, 18 Nov 2026 15:46:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=cuvIM3v4 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92ECA1F000C4; Wed, 18 Nov 2026 15:46:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795016782; bh=I8uDmT3ktqaXm4SSd9bvZ/jy1iJ0t+nHd+6EAOnhxLc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=cuvIM3v4Fl7ucRleW+PKdCP7jyAOL0LF7KOqUpjM21sKX+gjuQHBRssBW//KCNkLS YdT078jxuUFE1Ujx25PCaesl0W+eYGbcFQMMtqncC4YfUmP5rAIubkAlCSxn0V/GMY hyrgLGbervaN4goCWOsG/NcBFvqr5TTXAfDOyOVY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Weiming Shi , Xiang Mei , Konstantin Komarov , Sasha Levin Subject: [PATCH 7.3 0610/2651] fs/ntfs3: validate $SDH entry size in ntfs_insert_security Date: Wed, 18 Nov 2026 15:30:50 +0100 Message-ID: <20261118150309.676594864@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150247.972732815@linuxfoundation.org> References: <20261118150247.972732815@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xiang Mei [ Upstream commit 5b76487f94dacc2884135ce9a7bda61ce7ffa209 ] ntfs_insert_security() walks the $Secure::$SDH index and reads e->sec_hdr.size for every entry returned by indx_find()/indx_find_sort(). Those only guarantee the NTFS_DE envelope (e->size), so a crafted $SDH entry shorter than a full NTFS_DE_SDH at the tail of an index buffer makes the read of e->sec_hdr.size run past the allocation. Triggerable by an unprivileged setxattr(2) on a crafted NTFS image. BUG: KASAN: slab-out-of-bounds in ntfs_insert_security (fs/ntfs3/fsntfs.c:2148) Read of size 4 at addr ffff88800fa1de00 by task exploit/142 ntfs_insert_security (fs/ntfs3/fsntfs.c:2148) ntfs_setxattr (fs/ntfs3/xattr.c:947) __vfs_setxattr (fs/xattr.c:223) __vfs_setxattr_noperm (fs/xattr.c:257) vfs_setxattr (fs/xattr.c:344) filename_setxattr (fs/xattr.c:690) path_setxattrat (fs/xattr.c:734) __x64_sys_setxattr (fs/xattr.c:764) [...] The buggy address is located 0 bytes to the right of allocated 512-byte region [ffff88800fa1dc00, ffff88800fa1de00) Stop the scan when an entry is too small to hold a SECURITY_HDR. Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block") Reported-by: Weiming Shi Signed-off-by: Xiang Mei Signed-off-by: Konstantin Komarov Signed-off-by: Sasha Levin --- fs/ntfs3/fsntfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/ntfs3/fsntfs.c b/fs/ntfs3/fsntfs.c index 97c04ab2763ab..b55311ccd229a 100644 --- a/fs/ntfs3/fsntfs.c +++ b/fs/ntfs3/fsntfs.c @@ -2153,6 +2153,9 @@ int ntfs_insert_security(struct ntfs_sb_info *sbi, goto out; while (e) { + if (le16_to_cpu(e->de.size) < SIZEOF_SDH_DIRENTRY) + break; + if (le32_to_cpu(e->sec_hdr.size) == new_sec_size) { err = ntfs_read_run_nb(sbi, &ni->file.run, le64_to_cpu(e->sec_hdr.off), -- 2.53.0