From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795016746; b=Y1kcT4X9AEXumoELf3fSzfjbChhWF3tZsnLWLrturb7qT7qaiDRZ2xJpWqWOQLowyIGg s9E6lLJYTBSwLq0RITxyMGozWkYiTPoXhAcTSet7KbLGMt4vZgv1wOwCphWOKj3MDoghS /jfr+YT0QnPOyZw4AbP494qif0cb3q2lJt+JdQBX0vnLn1U8xeQgemomGqw6EVeMq9rCn 3oMMX5Gjs304VU4LS4SZdwohOpKmcLQE67WwYaWCQ5ZL85wOnk2WTrqpZpxmZczV3BtaQ dw/d0NBpe7Q91A6iaK23RIvaZtJ7rq3J9Evx67P92GA9dDF/RMtFP7X1vB1VtebLhpQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795016746; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=JJsG5fu4XfSdcUjVNr5qAWqKihCDNrRIPZR4itTkIso=; b=fcLvre97kk+mHr+VAJSalbgEIulwth5WoTuDPgMGErY0kf/FhCvQDrcb/GZ1rINTY5U0 67it7C1XAnn2PJhJzAyPbDNGPdA/GkHLXRJ4Luvf5T4nsWz8kLkv2Ppc57R+G/c4cT8id DT7NMnPYPgDC4elEXGgLM8C2ZR7IZ2M/ZWZsfm2eEElz/sUTO+6UnHqLMyUXYIUSeQ6n9 iW1DrDdQbLrxwNTFjjdLNYqAgbu40M7Sh/gPdvC+t8nbbf4nu5pIl7Vzhk08FHxerpqJZ FZmJeEqYeOYGMk/je1gBUHRkPg0YlGHd3WT0AwVBUdK/5gZhdY5hv4zySUGoBHF2klQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=fpPGk2UN; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F3AF606A31C; Wed, 18 Nov 2026 15:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=fpPGk2UN Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88F1B1F000C4; Wed, 18 Nov 2026 15:45:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795016746; bh=JJsG5fu4XfSdcUjVNr5qAWqKihCDNrRIPZR4itTkIso=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=fpPGk2UNV1BCHdiWIwfR9ulN2R5S+peHedzK/tv8Rs7Ms17TBe5jUVPBjoS/GmUWF X9W07RifN5aTqPGM7c1Hu6bgWis6OuFNtfliVv6uaMSXLZZ+um46x8tG5J+yQn4zD/ VaLWiF14PbCatXS7RhyUmRzx8OOg+FCI8bLihQJ0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Haibo Chen , Frank Li , Lee Jones , Sasha Levin Subject: [PATCH 7.3 0637/2651] leds: pca9532: Check i2c_smbus_read_byte_data() return value Date: Wed, 18 Nov 2026 15:31:17 +0100 Message-ID: <20261118150310.621189232@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150247.972732815@linuxfoundation.org> References: <20261118150247.972732815@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haibo Chen [ Upstream commit 1b75f038e5f71ed32ce6593b5763f9776ec58a25 ] Coverity report INTEGER_OVERFLOW (tainted_data_return -> cast_underflow -> overflow) in pca9532_getled(). pca9532_getled() stored the return value of i2c_smbus_read_byte_data() into a char and used it directly to compute the LED state without checking for an error. i2c_smbus_read_byte_data() returns a negative error code on failure. On an I2C read error the negative value was assigned to an unsigned type, triggering an integer underflow/overflow, and a meaningless LED state was returned to the caller. Read the value into an int, check for the error, and fall back to PCA9532_OFF while emitting a warning when the read fails. Fixes: 28c5fe99016d ("leds: pca9532: Extend pca9532 device tree support") Assisted-by: VeroCoder:vero-1 [cli] Signed-off-by: Haibo Chen Reviewed-by: Frank Li Link: https://patch.msgid.link/20260727-led-fix-v1-1-d635c5037109@nxp.com Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/leds/leds-pca9532.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c index b2e081c8f1393..1133fa348e246 100644 --- a/drivers/leds/leds-pca9532.c +++ b/drivers/leds/leds-pca9532.c @@ -298,12 +298,15 @@ static enum pca9532_state pca9532_getled(struct pca9532_led *led) struct i2c_client *client = led->client; struct pca9532_data *data = i2c_get_clientdata(client); u8 maxleds = data->chip_info->num_leds; - char reg; - enum pca9532_state ret; + int reg; + enum pca9532_state ret = PCA9532_OFF; mutex_lock(&data->update_lock); reg = i2c_smbus_read_byte_data(client, LED_REG(maxleds, led->id)); - ret = (reg & LED_MASK(led->id)) >> LED_SHIFT(led->id); + if (reg >= 0) + ret = (reg & LED_MASK(led->id)) >> LED_SHIFT(led->id); + else + dev_warn(&client->dev, "failed to read LED register: %d\n", reg); mutex_unlock(&data->update_lock); return ret; } -- 2.53.0