From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795034934; b=zsV37kEpTdZ8pGHvZ997Ht1P//9ragHGmqdQyB8IzUofr2XyzCwZ7ANjMZbuSu7DHNqa IdZYyVsf1KX+/O8/+x0qdIkhu3DIAFoUbbKdnRspHWXd4dem7A4x83/gu8+hKs99K80c9 UwN5XMPnvykO9D5T9L4bBkS+HYvHfnbxht8F8YZKi5sqls52noc3BuX56ivDfnA0sWCbg 8lxlJnjHHHYpXJvOEx97hbr5Gdin5a43wFKysCYec+nLorptayIP4S/q7zk7nm9hl1gEC yjmTXiLDwK3GJhQzSfF54bHy/15UIGn9pPAadnSya9mGh0XmJ77x0HPoby1JH4in1yQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795034934; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=YPP3e9ohHC6kelwP0ejSpXNtFtHXAJPA1/j/x7c6/Zw=; b=fwhtd3UBhpHhUyRDHZEmB6bgPmC6k0NjNzpPaKpSRnqB87O0ITewaYoOIjvR91bgQGMY I0pmzkawHyIJfX6vHlboRzEbavST5BPj0B6aBZQzGaIojzpfwziGpYSOa7UJCFQVVU7Ut 3TqmQqC1ji5dFr110VpTtr7caPnjdJqFITwXqWIaT45M7RikBi4ZWpTHhCfKMJuTC4WQS xUY5guZhCzr0elUH3oFMP0bOOe9shL216PSHdfxKmVGCQQ38Iw5JmNoP39qMvcfghQeEb 5zR8cz+mEPyjmwtQHIN5m8MMDWar/qlmoN1qw9lx43Xlr34LmlVFdb+sm6iswt3DQpA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=rnw8YXGe; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EFF7606A320; Wed, 18 Nov 2026 20:48:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=rnw8YXGe Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA04F1F000C4; Wed, 18 Nov 2026 20:48:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1795034934; bh=YPP3e9ohHC6kelwP0ejSpXNtFtHXAJPA1/j/x7c6/Zw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=rnw8YXGelL+YFkDJouIwOwFgP64zN6zsoOYvK4c7S7o24WCPpoQ5DR8psrYX+1tGn BV7QLfPhtrPYZywDtkHA3Iv0gFnT8KixF83St05Hv2UdYWILquLXK9EezS3NLKbUnr TTUxXsj5qWuLQA135EYLzxClzZJYlENTnMgq0bt4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Donggeun Yoo , Steven Rostedt , Sasha Levin Subject: [PATCH 6.6 0547/3318] tracing: Fix NULL dereference when copying keys for a field variable Date: Wed, 18 Nov 2026 15:19:29 +0100 Message-ID: <20261118150333.702735537@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261118150313.527275416@linuxfoundation.org> References: <20261118150313.527275416@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Donggeun Yoo [ Upstream commit a0777b9e53157f1f6848a0fd0650f5465391ea81 ] In event_hist_trigger_parse() where it needs to create actions like "onmatch", it calls: event_hist_trigger_parse() { create_actions() { action_create() { trace_action_create() { trace_action_create_field_var() { create_field_var_hist() Where create_field_var_hist() does a loop on the hist_data representing the keys. The issue is, if the keys uses one of the pseudo field types (like common_cpu), the hist_data field element will have NULL for its field member causing a NULL pointer dereference when accessing the key_field->field->name. # echo 'hist:keys=common_cpu:ts0=common_timestamp.usecs' > \ events/sched/sched_waking/trigger # echo 'my_synth u64 lat; int prio' > synthetic_events # echo 'hist:keys=common_cpu:wakeup_lat=common_timestamp.usecs-$ts0:\ onmatch(sched.sched_waking).my_synth($wakeup_lat,prio)' > \ events/sched/sched_switch/trigger KASAN: null-ptr-deref in range [0x0000000000000010-0x0000000000000017] RIP: 0010:create_field_var_hist+0x771/0x1380 Call Trace: trace_action_create_field_var+0x360/0x600 trace_action_create+0x393/0xe80 event_hist_trigger_parse+0x3e47/0x69e0 trigger_process_regex+0x1a6/0x250 event_trigger_write+0xce/0x160 Instead of accessing it directly, use the proper handler expr_field_str() to get the name. The three previous patches are prerequisites: without them a .buckets key and a common_stacktrace key each render into a command that cannot be parsed back. Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260914053443.981201-5-donggeunyoo.kernel@gmail.com Fixes: 02205a6752f2 ("tracing: Add support for 'field variables'") Signed-off-by: Donggeun Yoo Assisted-by: Claude:claude-fable-5 Signed-off-by: Steven Rostedt Signed-off-by: Sasha Levin --- kernel/trace/trace_events_hist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index fa48566816c03..be6eb66a6808b 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -3075,7 +3075,7 @@ create_field_var_hist(struct hist_trigger_data *target_hist_data, key_field = hist_data->fields[i]; if (!first) seq_buf_putc(&s, ','); - seq_buf_puts(&s, key_field->field->name); + expr_field_str(key_field, &s); first = false; } -- 2.53.0