Re: [PATCH v20 16/18] x86/resctrl: Enable RMID shared RMID mode on Sub-NUMA Cluster (SNC) systems

[Reinette Chatre <reinette.chatre@intel.com>]

Hi Tony,

shortlog: "RMID shared RMID mode" -> "RMID shared mode" or "shared RMID mode"?

On 6/10/24 11:35 AM, Tony Luck wrote:
> Hardware has two RMID configuration options for SNC systems. The default
> mode divides RMID counters between SNC nodes. E.g. with 200 RMIDs and
> two SNC nodes per L3 cache RMIDs 0..99 are used on node 0, and 100..199
> on node 1. This isn't very compatible with Linux resctrl usage. On this

Could we head off potential tangents with "This isn't very compatible"
changed to "This isn't compatible"?

> example system a process using RMID 5 would only update monitor counters
> while running on SNC node 0.
> 
> The other mode is "RMID Sharing Mode". This is enabled by clearing bit
> 0 of the RMID_SNC_CONFIG (0xCA0) model specific register. In this mode
> the number of logical RMIDs is the number of physical RMIDs (from CPUID
> leaf 0xF) divided by the number of SNC nodes per L3 cache instance. A
> process can use the same RMID across different SNC nodes.
> 
> See the "Intel Resource Director Technology Architecture Specification"
> for additional details.
> 
> When SNC is enabled, update the MSR when a monitor domain is marked
> online. Tehcnically this is overkill. It only needs to be done once

Tehcnically -> Technically

> per L3 cache instance rather than per SNC domain. But there is no harm
> in doing it more than once, and this is not in a critical path.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>   arch/x86/include/asm/msr-index.h       |  1 +
>   arch/x86/kernel/cpu/resctrl/internal.h |  2 ++
>   arch/x86/kernel/cpu/resctrl/core.c     |  2 ++
>   arch/x86/kernel/cpu/resctrl/monitor.c  | 26 ++++++++++++++++++++++++++
>   4 files changed, 31 insertions(+)
> 
> diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h
> index e022e6eb766c..3cb8dd6311c3 100644
> --- a/arch/x86/include/asm/msr-index.h
> +++ b/arch/x86/include/asm/msr-index.h
> @@ -1164,6 +1164,7 @@
>   #define MSR_IA32_QM_CTR			0xc8e
>   #define MSR_IA32_PQR_ASSOC		0xc8f
>   #define MSR_IA32_L3_CBM_BASE		0xc90
> +#define MSR_RMID_SNC_CONFIG		0xca0
>   #define MSR_IA32_L2_CBM_BASE		0xd10
>   #define MSR_IA32_MBA_THRTL_BASE		0xd50
>   
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index 75bb1afc4842..324cf05858f5 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -529,6 +529,8 @@ static inline bool resctrl_arch_get_cdp_enabled(enum resctrl_res_level l)
>   
>   int resctrl_arch_set_cdp_enabled(enum resctrl_res_level l, bool enable);
>   
> +void arch_mon_domain_online(struct rdt_resource *r, struct rdt_mon_domain *d);
> +
>   /*
>    * To return the common struct rdt_resource, which is contained in struct
>    * rdt_hw_resource, walk the resctrl member of struct rdt_hw_resource.
> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
> index 95ef8fe3cb50..1930fce9dfe9 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -615,6 +615,8 @@ static void domain_add_cpu_mon(int cpu, struct rdt_resource *r)
>   	}
>   	cpumask_set_cpu(cpu, &d->hdr.cpu_mask);
>   
> +	arch_mon_domain_online(r, d);
> +
>   	if (arch_domain_mbm_alloc(r->num_rmid, hw_dom)) {
>   		mon_domain_free(hw_dom);
>   		return;
> diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
> index c4d9a8df8d2d..efbb84c00d79 100644
> --- a/arch/x86/kernel/cpu/resctrl/monitor.c
> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
> @@ -1082,6 +1082,32 @@ static void l3_mon_evt_init(struct rdt_resource *r)
>   		list_add_tail(&mbm_local_event.list, &r->evt_list);
>   }
>   
> +/*
> + * The power-on reset value of MSR_RMID_SNC_CONFIG is 0x1
> + * which indicates that RMIDs are configured in legacy mode.
> + * This mode is incompatible with Linux resctrl semantics
> + * as RMIDs are partitioned between SNC nodes, which requires
> + * a user to know which RMID is allocated to a task.
> + * Clearing bit 0 reconfigures the RMID counters for use

"Clearing bit 0 configures RMID sharing mode for use ..."? It is
strange to me that this whole comment has no mention of
"RMID sharing mode" that seems to be goal of this change.

> + * in Sub-NUMA Cluster mode. This mode is better for Linux.
> + * The RMID space is divided between all SNC nodes with the
> + * RMIDs renumbered to start from zero in each node when
> + * counting operations from tasks. Code to read the counters
> + * must adjust RMID counter numbers based on SNC node. See
> + * logical_rmid_to_physical_rmid() for code that does this.
> + */
> +void arch_mon_domain_online(struct rdt_resource *r, struct rdt_mon_domain *d)
> +{
> +	u64 val;
> +
> +	if (snc_nodes_per_l3_cache == 1)
> +		return;
> +
> +	rdmsrl(MSR_RMID_SNC_CONFIG, val);
> +	val &= ~BIT_ULL(0);
> +	wrmsrl(MSR_RMID_SNC_CONFIG, val);
> +}
> +
>   int __init rdt_get_mon_l3_config(struct rdt_resource *r)
>   {
>   	unsigned int mbm_offset = boot_cpu_data.x86_cache_mbm_width_offset;

Patch looks good to me.

Reinette