From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: broonie@kernel.org, lgirdwood@gmail.com,
peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com,
ranjani.sridharan@linux.intel.com, daniel.baluta@nxp.com,
kai.vehmanen@linux.intel.com, ndesaulniers@google.com,
trix@redhat.com, rander.wang@intel.com,
sound-open-firmware@alsa-project.org,
alsa-devel@alsa-project.org, llvm@lists.linux.dev,
patches@lists.linux.dev
Subject: Re: [PATCH] ASoC: SOF: Intel: Initialize chip in hda_sdw_check_wakeen_irq()
Date: Wed, 9 Aug 2023 14:57:13 -0500 [thread overview]
Message-ID: <2a2de1b5-4dd5-f170-bb0b-61d39230c3a7@linux.intel.com> (raw)
In-Reply-To: <20230809190212.GB3355565@dev-arch.thelio-3990X>
>> That said, we DO compile with clang and there was no warning
>> https://github.com/thesofproject/linux/actions/runs/5542372669/job/15010818307
>>
>> Is this dependent on a specific version of clang? I'd like to make sure
>> our tools and tests are updated.
>
> It should not be, I can reproduce it with all the versions of clang that
> the kernel supports (11.x+).
>
> Looking at your GitHub Actions files, I am not sure exporting CC works
> correctly so I don't think you are building with clang. If I do it
D'oh. I did not see this one coming... nice.
> locally:
>
> $ export CC=clang
>
> $ make -j$(nproc) defconfig
>
> $ grep -E 'CONFIG_(CC_IS|CLANG|GCC)' .config
> CONFIG_CC_IS_GCC=y
> CONFIG_GCC_VERSION=130201
> CONFIG_CLANG_VERSION=0
> CONFIG_GCC11_NO_ARRAY_BOUNDS=y
> CONFIG_GCC_PLUGINS=y
> # CONFIG_GCC_PLUGIN_LATENT_ENTROPY is not set
> # CONFIG_GCC_PLUGIN_STACKLEAK is not set
>
> $ make -j$(nproc) sound/soc/sof/intel/hda.o
>
> $ head -1 sound/soc/sof/intel/.hda.o.cmd
> savedcmd_sound/soc/sof/intel/hda.o := gcc ...
>
> This was brought up some time ago and Masahiro made a decent point that
> this might not be a desirable behavior change.
>
> https://lore.kernel.org/CAK7LNAT6Yp3oemUxSst+htnmM-St8WmSv+UZ2x2XF23cw-kU-Q@mail.gmail.com/
>
> Switching to passing CC via the actual make command should fix that.
Not quite. We generate our .config using "make defconfig" as a baseline
and then "merge_config.sh" to add a bunch of fragments we need [1]. And
of course the latter script does not understand CC=clang and switches
back to GCC.
Looks like I painted myself in a corner for the last 5 years...Any
recommendations would be welcome.
[1]
https://github.com/thesofproject/kconfig/blob/master/kconfig-sof-default.sh
next prev parent reply other threads:[~2023-08-09 19:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 18:12 [PATCH] ASoC: SOF: Intel: Initialize chip in hda_sdw_check_wakeen_irq() Nathan Chancellor
2023-08-09 18:41 ` Pierre-Louis Bossart
2023-08-09 19:02 ` Nathan Chancellor
2023-08-09 19:57 ` Pierre-Louis Bossart [this message]
2023-08-09 20:09 ` Nathan Chancellor
2023-08-09 20:42 ` Pierre-Louis Bossart
2023-08-10 14:33 ` Nathan Chancellor
2023-08-10 11:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a2de1b5-4dd5-f170-bb0b-61d39230c3a7@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=patches@lists.linux.dev \
--cc=peter.ujfalusi@linux.intel.com \
--cc=rander.wang@intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=trix@redhat.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox